You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/14 16:46:05 UTC
[GitHub] [spark] sunchao opened a new pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
sunchao opened a new pull request #33348:
URL: https://github.com/apache/spark/pull/33348
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In `CatalogFileIndex.filterPartitions`, check the config `spark.sql.hive.metastorePartitionPruning` and don't pushdown predicates to remote HMS if it is false. Instead, fallback to the `listPartitions` API and do the filtering on the client side.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently the config `spark.sql.hive.metastorePartitionPruning` is only effective for Hive tables, and for non-Hive tables we'd always use the `listPartitionsByFilter` API from HMS client. On the other hand, by default all data source tables also manage their partitions through HMS, when the config `spark.sql.hive.manageFilesourcePartitions` is turned on. Therefore, it seems reasonable to extend the above config for non-Hive tables as well.
In certain cases the remote HMS service could throw exceptions when using the `listPartitionsByFilter` API, which, on the Spark side, is unrecoverable at the current state. Therefore it would be better to allow users to disable the API by using the above config.
For instance, HMS only allow pushdown date column when direct SQL is used instead of JDO for interacting with the underlying RDBMS, and will throw exception otherwise. Even though the Spark Hive client will attempt to recover itself when the exception happens, it only does so when the config `hive.metastore.try.direct.sql` from remote HMS is `false`. There could be cases where the value of `hive.metastore.try.direct.sql` is true but remote HMS still throws exception.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes now the config `spark.sql.hive.metastorePartitionPruning` is extended for non-Hive tables which use HMS to manage their partition metadata.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a new unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880050139
**[Test build #141026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141026/testReport)** for PR 33348 at commit [`d69d2c2`](https://github.com/apache/spark/commit/d69d2c294500afe83b1d48c0145f510d2b822b29).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670125162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala
##########
@@ -94,6 +93,19 @@ class CatalogFileIndex(
}
}
+ private def listPartitionsByFilter(
+ table: CatalogTable,
+ partitionFilters: Seq[Expression]): Seq[CatalogTablePartition] = {
+ if (sparkSession.sessionState.conf.metastorePartitionPruning) {
+ sparkSession.sessionState.catalog.listPartitionsByFilter(
+ table.identifier, partitionFilters)
+ } else {
+ ExternalCatalogUtils.prunePartitionsByFilter(table,
+ sparkSession.sessionState.catalog.listPartitions(table.identifier),
+ partitionFilters, sparkSession.sessionState.conf.sessionLocalTimeZone)
+ }
+ }
Review comment:
Good suggestion. I tried this at the beginning but stopped since `SparkSession` was not visible in `catalyst` module, but seems we can just pass the `SessionCatalog` as method parameter instead.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala
##########
@@ -94,6 +93,19 @@ class CatalogFileIndex(
}
}
+ private def listPartitionsByFilter(
+ table: CatalogTable,
+ partitionFilters: Seq[Expression]): Seq[CatalogTablePartition] = {
+ if (sparkSession.sessionState.conf.metastorePartitionPruning) {
+ sparkSession.sessionState.catalog.listPartitionsByFilter(
+ table.identifier, partitionFilters)
+ } else {
+ ExternalCatalogUtils.prunePartitionsByFilter(table,
+ sparkSession.sessionState.catalog.listPartitions(table.identifier),
+ partitionFilters, sparkSession.sessionState.conf.sessionLocalTimeZone)
+ }
+ }
Review comment:
Good suggestion. I tried this at the beginning but stopped since `SparkSession` is not visible in `catalyst` module, but seems we can just pass the `SessionCatalog` as method parameter instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881711887
Thanks all for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670075180
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala
##########
@@ -94,6 +93,19 @@ class CatalogFileIndex(
}
}
+ private def listPartitionsByFilter(
+ table: CatalogTable,
+ partitionFilters: Seq[Expression]): Seq[CatalogTablePartition] = {
+ if (sparkSession.sessionState.conf.metastorePartitionPruning) {
+ sparkSession.sessionState.catalog.listPartitionsByFilter(
+ table.identifier, partitionFilters)
+ } else {
+ ExternalCatalogUtils.prunePartitionsByFilter(table,
+ sparkSession.sessionState.catalog.listPartitions(table.identifier),
+ partitionFilters, sparkSession.sessionState.conf.sessionLocalTimeZone)
+ }
+ }
Review comment:
Could you move this function to `ExternalCatalogUtils` like `prunePartitionsByFilter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881697376
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45688/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880224086
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141026/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880117666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880078898
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881701731
GA passed. Thanks. Merging to master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670089634
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
Review comment:
Is it okay to reuse the hive config for the purpose? Sounds more like `spark.sql.metastorePartitionPruning` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880806168
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45595/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880805912
**[Test build #141081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141081/testReport)** for PR 33348 at commit [`7cb042a`](https://github.com/apache/spark/commit/7cb042a34f4f2ec487c70927e007a662ec7de8fb).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880121896
cc @cloud-fan @viirya @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881677155
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45688/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881604050
Thanks @viirya @cloud-fan . Rebased and addressed your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880800322
**[Test build #141081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141081/testReport)** for PR 33348 at commit [`7cb042a`](https://github.com/apache/spark/commit/7cb042a34f4f2ec487c70927e007a662ec7de8fb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881619765
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45684/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881644688
**[Test build #141176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141176/testReport)** for PR 33348 at commit [`f686496`](https://github.com/apache/spark/commit/f686496a2a21b1075ff182dc936643d71e1e85e3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880800322
**[Test build #141081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141081/testReport)** for PR 33348 at commit [`7cb042a`](https://github.com/apache/spark/commit/7cb042a34f4f2ec487c70927e007a662ec7de8fb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880805971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881139835
I have no objection as long as it's consistent with other similar confs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881647825
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141176/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881611774
**[Test build #141172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141172/testReport)** for PR 33348 at commit [`abfca8c`](https://github.com/apache/spark/commit/abfca8c1831ce6ebe51be82884c6239e92da9d28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r669861529
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala
##########
@@ -94,6 +93,19 @@ class CatalogFileIndex(
}
}
+ private def listPartitionsByFilter(
Review comment:
this code is duplicated from the one in `PruneHiveTablePartitions`, and hopefully we can remove it once we combine `PruneHiveTablePartitions` and `PruneFileSourcePartitions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r671413398
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
buildConf("spark.sql.hive.metastorePartitionPruning")
.doc("When true, some predicates will be pushed down into the Hive metastore so that " +
- "unmatching partitions can be eliminated earlier. This only affects Hive tables " +
- "not converted to filesource relations (see HiveUtils.CONVERT_METASTORE_PARQUET and " +
- "HiveUtils.CONVERT_METASTORE_ORC for more information).")
+ "unmatching partitions can be eliminated earlier.")
Review comment:
Oh, I see. I should mention `spark.sql.hive.metastorePartitionPruning` there. Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881619783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45684/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880806201
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45595/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881611774
**[Test build #141172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141172/testReport)** for PR 33348 at commit [`abfca8c`](https://github.com/apache/spark/commit/abfca8c1831ce6ebe51be82884c6239e92da9d28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880102502
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881644688
**[Test build #141176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141176/testReport)** for PR 33348 at commit [`f686496`](https://github.com/apache/spark/commit/f686496a2a21b1075ff182dc936643d71e1e85e3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880221808
**[Test build #141026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141026/testReport)** for PR 33348 at commit [`d69d2c2`](https://github.com/apache/spark/commit/d69d2c294500afe83b1d48c0145f510d2b822b29).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670092631
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
Review comment:
yeah I agree, that's the exactly same point I mentioned in the JIRA ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670126962
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
buildConf("spark.sql.hive.metastorePartitionPruning")
.doc("When true, some predicates will be pushed down into the Hive metastore so that " +
- "unmatching partitions can be eliminated earlier. This only affects Hive tables " +
- "not converted to filesource relations (see HiveUtils.CONVERT_METASTORE_PARQUET and " +
- "HiveUtils.CONVERT_METASTORE_ORC for more information).")
+ "unmatching partitions can be eliminated earlier.")
Review comment:
Yea, we should mention that it only does so when `spark.sql.hive.metastorePartitionPruning` is turned on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #33348:
URL: https://github.com/apache/spark/pull/33348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r671412864
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
buildConf("spark.sql.hive.metastorePartitionPruning")
.doc("When true, some predicates will be pushed down into the Hive metastore so that " +
- "unmatching partitions can be eliminated earlier. This only affects Hive tables " +
- "not converted to filesource relations (see HiveUtils.CONVERT_METASTORE_PARQUET and " +
- "HiveUtils.CONVERT_METASTORE_ORC for more information).")
+ "unmatching partitions can be eliminated earlier.")
Review comment:
Hmm I thought this needs to be updated if we don't have this PR, since Spark doesn't prune partitions for file data source tables on metastore side. But with this PR the description becomes correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881261705
SGTM. Can you resolve the conflict? @sunchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881619783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45684/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880947890
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45602/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880886453
**[Test build #141088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141088/testReport)** for PR 33348 at commit [`6c481ce`](https://github.com/apache/spark/commit/6c481ceabdd40791f05e60c9cc64af2232018833).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881705178
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45688/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880050139
**[Test build #141026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141026/testReport)** for PR 33348 at commit [`d69d2c2`](https://github.com/apache/spark/commit/d69d2c294500afe83b1d48c0145f510d2b822b29).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880334059
Thank you for pinging me, @sunchao .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881053741
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881616002
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141172/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670096762
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
buildConf("spark.sql.hive.metastorePartitionPruning")
.doc("When true, some predicates will be pushed down into the Hive metastore so that " +
- "unmatching partitions can be eliminated earlier. This only affects Hive tables " +
- "not converted to filesource relations (see HiveUtils.CONVERT_METASTORE_PARQUET and " +
- "HiveUtils.CONVERT_METASTORE_ORC for more information).")
+ "unmatching partitions can be eliminated earlier.")
Review comment:
`HIVE_MANAGE_FILESOURCE_PARTITIONS` mentions that when it is enabled, it uses the metastore to prune partitions during query planning. Maybe we should update the doc too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880886453
**[Test build #141088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141088/testReport)** for PR 33348 at commit [`6c481ce`](https://github.com/apache/spark/commit/6c481ceabdd40791f05e60c9cc64af2232018833).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r671053579
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
buildConf("spark.sql.hive.metastorePartitionPruning")
.doc("When true, some predicates will be pushed down into the Hive metastore so that " +
- "unmatching partitions can be eliminated earlier. This only affects Hive tables " +
- "not converted to filesource relations (see HiveUtils.CONVERT_METASTORE_PARQUET and " +
- "HiveUtils.CONVERT_METASTORE_ORC for more information).")
+ "unmatching partitions can be eliminated earlier.")
Review comment:
Seems not update yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881615962
**[Test build #141172 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141172/testReport)** for PR 33348 at commit [`abfca8c`](https://github.com/apache/spark/commit/abfca8c1831ce6ebe51be82884c6239e92da9d28).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881647794
**[Test build #141176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141176/testReport)** for PR 33348 at commit [`f686496`](https://github.com/apache/spark/commit/f686496a2a21b1075ff182dc936643d71e1e85e3).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880959734
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45602/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880959734
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45602/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881053741
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880117666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670074389
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala
##########
@@ -94,6 +93,19 @@ class CatalogFileIndex(
}
}
+ private def listPartitionsByFilter(
Review comment:
Shall we use the same name, `private def prunePartitions`, explicitly?
When we consolidate both code later, that will reduce the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880805971
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141081/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880224086
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141026/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881092608
Thanks @dongjoon-hyun @HyukjinKwon and @viirya ! I've shared on the rationale why I went with the existing conf but please share your thoughts on this. If we go with a new config, it'll require a migration and I'm not sure how easy that is.
> I'd like to recommend to put those two functions together in the same place which means moving PruneHiveTablePartitions.prunePartitions to ExternalCatalogUtils and adding the new function there too instead of here. HiveTableRelation is in catalyst module. WDYT
Thanks for the suggestion. This is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #33348:
URL: https://github.com/apache/spark/pull/33348#discussion_r670126640
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -979,9 +979,7 @@ object SQLConf {
val HIVE_METASTORE_PARTITION_PRUNING =
Review comment:
The reason I reused the config is because it is not about Hive tables, but HMS-based catalog which is shared by both Hive tables and non-Hive tables in Spark. This is similar to `spark.sql.hive.manageFilesourcePartitions` which is used by data source tables even though it has `hive` in its name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881647825
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141176/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-880924358
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45602/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881048119
**[Test build #141088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141088/testReport)** for PR 33348 at commit [`6c481ce`](https://github.com/apache/spark/commit/6c481ceabdd40791f05e60c9cc64af2232018833).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881616002
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141172/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33348: [SPARK-36128][SQL] Apply spark.sql.hive.metastorePartitionPruning for non-Hive tables that uses Hive metastore for partition management
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33348:
URL: https://github.com/apache/spark/pull/33348#issuecomment-881705178
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45688/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org