[jira] [Commented] (NIFI-4951) convertToAvroObject does not utilize AvroTypeUtil when trying to convert Date, Time, or Timestamps

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391922#comment-16391922 ] 

ASF GitHub Bot commented on NIFI-4951:
--------------------------------------

GitHub user derekstraka opened a pull request:

    https://github.com/apache/nifi/pull/2526

    NIFI-4951: Update convertToAvroObject to use the DataTypeUtils conversion function

    The feature allows users to convert from non-integral types to the correct underlying type.  The
    original behavior is maintained; however, now simple conversions take place automatically for some
    logical types (date, time, and timestamp).
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/derekstraka/nifi fix-misc-avro-conversions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2526
    
----
commit 28b50ff985d9db9a6ef0626a182e3fc0ab5e4bfd
Author: Derek Straka <de...@...>
Date:   2018-03-08T21:10:02Z

    NIFI-4951: Update convertToAvroObject to use the DataTypeUtils conversion function
    
    The feature allows users to convert from non-integral types to the correct underlying type.  The
    original behavior is maintained; however, now simple conversions take place automatically for some
    logical types (date, time, and timestamp).
    
    Signed-off-by: Derek Straka <de...@asterius.io>

----


> convertToAvroObject does not utilize AvroTypeUtil when trying to convert Date, Time, or Timestamps
> --------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4951
>                 URL: https://issues.apache.org/jira/browse/NIFI-4951
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Derek Straka
>            Assignee: Derek Straka
>            Priority: Major
>
> Currently, AvroTypeUtil::convertToAvroObject assumes that the logical types have already been converted into their internal representation.  While this may sometimes be the case, it would be useful to allow String->Logical type conversion.  The feature can be added by using the appropriate DataTypeUtils::to<Logical Type> method rather than blindly attempting to use the underlying type.  The DataTypeUtils already performs the integral type parsing, so the existing functionality remains intact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)