You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/04/03 16:56:16 UTC

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require DROP privilege

Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9905


Change subject: IMPALA-6800: Add test cases for statements that require DROP privilege
......................................................................

IMPALA-6800: Add test cases for statements that require DROP privilege

Testing:
- Added new test cases
- Ran front-end tests

Cherry-picks: not for 2.x

Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/9905/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require ALTER privilege

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require ALTER privilege
......................................................................

IMPALA-6800: Add test cases for statements that require ALTER privilege

Testing:
- Added new test cases
- Ran front-end tests

Cherry-picks: not for 2.x

Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Reviewed-on: http://gerrit.cloudera.org:8080/9905
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require ALTER privilege

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require ALTER privilege
......................................................................

IMPALA-6800: Add test cases for statements that require ALTER privilege

Testing:
- Added new test cases
- Ran front-end tests

Cherry-picks: not for 2.x

Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/9905/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require ALTER privilege

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require ALTER privilege
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2227/


-- 
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 03 Apr 2018 17:20:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require DROP privilege

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require DROP privilege
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Good catch, thanks for adding these!

http://gerrit.cloudera.org:8080/#/c/9905/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9905/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-6800: Add test cases for statements that require DROP privilege
ALTER privilege?



-- 
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 17:17:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6800: Add test cases for statements that require ALTER privilege

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9905 )

Change subject: IMPALA-6800: Add test cases for statements that require ALTER privilege
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:20:43 +0000
Gerrit-HasComments: No