[jira] [Comment Edited] (CALCITE-1584) ProjectRemoveRule loses field names

["Arina Ielchiieva (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028280#comment-16028280 ] 

Arina Ielchiieva edited comment on CALCITE-1584 at 5/29/17 12:23 PM:
---------------------------------------------------------------------

[~julianhyde] in email thread you have mentioned:
{noformat}
ProjectRemoveRule currently takes one argument (the trivial project) but to see the real type of that project's input the rule would needto take two arguments.
{noformat}

I was going to prepare the fix for this issue but I did not quite get this comment. Actually, I was going to modify RexUtil.isIdentity method to take three arguments and compare field names as well as field types (as it was before Vladimir changes). If I am not correct, could you please explain your comment? Thank you in advance!



was (Author: arina):
[~julianhyde] in email thread you have mentioned:
{noformat}
ProjectRemoveRule currently takes one argument (the trivial project) but to see the real type of that project's input the rule would needto take two arguments.
{noformat}

I was going to preparethe fix for this issue but I did not quite get this comment. Actually, I was going to modify RexUtil.isIdentity method to take three arguments and compare field names as well as field types (as it was before Vladimir changes). If I am not correct, could you please explain your comment? Thank you in advance!


> ProjectRemoveRule loses field names
> -----------------------------------
>
>                 Key: CALCITE-1584
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1584
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Jess Balint
>            Assignee: Julian Hyde
>            Priority: Minor
>
> the rule doesn't properly identify a child {{Project}} node



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)