[GitHub] [arrow] amol- commented on a change in pull request #10713: ARROW-12837: [C++] Do not crash when printing invalid arrays

[GitBox <gi...@apache.org>]

amol- commented on a change in pull request #10713:
URL: https://github.com/apache/arrow/pull/10713#discussion_r677336324



##########
File path: cpp/src/arrow/pretty_print.cc
##########
@@ -325,6 +325,12 @@ class ArrayPrinter : public PrettyPrinter {
                   std::is_base_of<FixedSizeListArray, T>::value,
               Status>
   Visit(const T& array) {
+    Status validArrayState = array.Validate();
+    if (!validArrayState.ok()) {
+      (*sink_) << "<InvalidArray: " << validArrayState.message() << ">";

Review comment:
       Applied your suggested change! I should have used underscores, 
   
   Even thought, a bit more talkative variable name would have helped ;)
   Even if I get that `st` is a `Status`, it doesn't tell me much about what status it is and I have to navigate to the line of code that returned it to be able to guess, but in this case it's a 3 lines of code block, so I guess that having to look at the top of it to get more context probably doesn't matter too much.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org