You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/21 03:53:59 UTC

[GitHub] jessebrizzi opened a new pull request #11009: [MXNET-434] update scala api to properly track reshaped size

jessebrizzi opened a new pull request #11009: [MXNET-434] update scala api to properly track reshaped size
URL: https://github.com/apache/incubator-mxnet/pull/11009
 
 
   ## Description ##
   Jira ticket [here](https://issues.apache.org/jira/browse/MXNET-434)
   
   Attempt to fix (this)[https://github.com/apache/incubator-mxnet/issues/10866] bug.
   
   The scala api currently does not track the datashape and labelshape of the module after a reshape call. Thus when the module forward pass checks to see if it needs a reshape it will always be comparing the new databatch shape to the originally binded shape instead of the current resized shape. 
   
   This change attempts to mimic the python API to properly track the current module shape. 
   
   The scala API overall looks to try to mimic the python api where it can but given the general default immutability of Scala objects, there may be other issue like this. 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services