You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/17 08:50:40 UTC
[GitHub] [shardingsphere] gxxiong opened a new pull request, #23613: Refactor TelephoneRandomReplaceAlgorithm
gxxiong opened a new pull request, #23613:
URL: https://github.com/apache/shardingsphere/pull/23613
Ref #22759 .
Changes proposed in this pull request:
-TelephoneRandomReplaceAlgorithm
Before committing this PR, I'm sure that I have checked the following options:
- [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [X] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [X] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23613: Refactor TelephoneRandomReplaceAlgorithm
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23613:
URL: https://github.com/apache/shardingsphere/pull/23613#issuecomment-1385085572
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23613?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23613](https://codecov.io/gh/apache/shardingsphere/pull/23613?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b43721f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a5bf03ce0c09e8ba37ed65ebadb7f900e3d08202?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5bf03c) will **increase** coverage by `0.03%`.
> The diff coverage is `88.88%`.
> :exclamation: Current head b43721f differs from pull request most recent head 364b06b. Consider uploading reports for the commit 364b06b to get more accurate results
```diff
@@ Coverage Diff @@
## master #23613 +/- ##
============================================
+ Coverage 49.73% 49.76% +0.03%
+ Complexity 2498 2487 -11
============================================
Files 4102 4102
Lines 58363 58369 +6
Branches 10120 10121 +1
============================================
+ Hits 29026 29049 +23
+ Misses 26834 26813 -21
- Partials 2503 2507 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23613?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rithm/replace/TelephoneRandomReplaceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23613?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9yZXBsYWNlL1RlbGVwaG9uZVJhbmRvbVJlcGxhY2VBbGdvcml0aG0uamF2YQ==) | `93.54% <88.88%> (-2.46%)` | :arrow_down: |
| [...ngsphere/infra/util/reflection/ReflectionUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/23613?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9yZWZsZWN0aW9uL1JlZmxlY3Rpb25VdGlsLmphdmE=) | `73.80% <0.00%> (+42.85%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #23613: Refactor TelephoneRandomReplaceAlgorithm
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #23613:
URL: https://github.com/apache/shardingsphere/pull/23613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org