You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by babokim <gi...@git.apache.org> on 2014/07/14 06:49:36 UTC
[GitHub] tajo pull request: TAJO-904: ORDER BY with a null column miss some...
GitHub user babokim opened a pull request:
https://github.com/apache/tajo/pull/70
TAJO-904: ORDER BY with a null column miss some data.
Currently Tajo ignores null value when calculates range partition range. I added a MaxValueNull flag variable in ColumnStats. If ColumnStats's max value is null, ColumnStats's max value is a non-null value and MaxValueNull flag is true. So Repartitioner calculates range cardinality with non-null value. Finally Repartitioner set null value to last range.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/babokim/tajo TAJO-904
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/70.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #70
----
commit 3acb265add415a9f4722935f9a69d6cd97b6f987
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date: 2014-07-14T03:31:21Z
TAJO-904: ORDER BY with a null column miss some data.
commit 89a35fd24bc7a8f9ab3ec7db0edfa5dad8e328a6
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date: 2014-07-14T03:31:59Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-904: ORDER BY with a null column miss some...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/70#issuecomment-48993979
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-904: ORDER BY with a null column miss some...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-904: ORDER BY with a null column miss some...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/70#issuecomment-48992032
It works well for null first case. But, in null last case, the query results in empty rows.
In my view, null last supports is not trivial and requires a bunch of codes. In contrast, the current patch looks reasonable for only null first.
If there is no objection, I'll change the issue name to 'ORDER BY NULL FIRST support', and I'll create another issue for null last.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-904: ORDER BY with a null column miss some...
Posted by babokim <gi...@git.apache.org>.
Github user babokim commented on the pull request:
https://github.com/apache/tajo/pull/70#issuecomment-48993442
Hyunsik, I agree your opinion. Please go ahead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-904: ORDER BY with a null column miss some...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/70#discussion_r14870602
--- Diff: tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java ---
@@ -169,4 +177,46 @@ public final void testTopkWithJson() throws Exception {
assertResultSet(res);
cleanupQuery(res);
}
+
+ @Test
+ public final void testSortNullColumn() throws Exception {
+ try {
+ executeString("DROP TABLE table1 PURGE;").close();
--- End diff --
It should be ```DROP TABLE IF EXISTS table 1 PURGE```. Otherwise, it will cause 'no such table error' when a developer executes this test separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---