[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2324: Adding support for workspace/symbol to both the LSP client and Java LSP server.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2324:
URL: https://github.com/apache/netbeans/pull/2324#discussion_r511329756



##########
File path: ide/parsing.lucene/nbproject/project.xml
##########
@@ -85,6 +85,7 @@
             </test-dependencies>
             <friend-packages>
                 <friend>org.netbeans.modules.cnd.indexing</friend>
+                <friend>org.netbeans.modules.java.lsp.server</friend>

Review comment:
       I'd slightly prefer to open up the module to public to adding yet another friend.
   
   In any case, you have to do proper versioning. Increase the module spec version and make the new friend request that version. See the [friend dependencies](http://wiki.apidesign.org/wiki/FriendDependencies) essay.

##########
File path: ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
##########
@@ -232,6 +250,8 @@ private static InitializeResult initServer(Process p, LanguageServer server, Fil
        wcc.setWorkspaceEdit(new WorkspaceEditCapabilities());
        wcc.getWorkspaceEdit().setDocumentChanges(true);
        wcc.getWorkspaceEdit().setResourceOperations(Arrays.asList(ResourceOperationKind.Create, ResourceOperationKind.Delete, ResourceOperationKind.Rename));
+       SymbolCapabilities sc = new SymbolCapabilities(new SymbolKindCapabilities(Arrays.asList(SymbolKind.values())));
+       wcc.setSymbol(sc);
        initParams.setCapabilities(new ClientCapabilities(wcc, tdcc, null));

Review comment:
       I see. This is the way to specify client capabilities! CCing @sdedic.

##########
File path: cpplite/cpplite.editor/src/org/netbeans/modules/cpplite/editor/lsp/LanguageServerImpl.java
##########
@@ -64,9 +64,10 @@
 })
 public class LanguageServerImpl implements LanguageServerProvider {
 
+    private static final boolean DEBUG = Boolean.getBoolean("cpplite.lsp.debug");

Review comment:
       Using `Logger` would be more standard. See [Logging in NetBeans](http://bits.netbeans.org/dev/javadoc/org-openide-util/org/openide/util/doc-files/logging.html) document.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists