You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/06 09:32:48 UTC
[GitHub] [flink] liyubin117 opened a new pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
liyubin117 opened a new pull request #16738:
URL: https://github.com/apache/flink/pull/16738
## What is the purpose of the change
using maven protobuf plugin will encount problem in a proxy networking
## Brief change log
* use <protocArtifact>
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16738:
URL: https://github.com/apache/flink/pull/16738#issuecomment-894157245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "858177dbd89b8e3bc062cd629f8d7d0a19f095ab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21684",
"triggerID" : "858177dbd89b8e3bc062cd629f8d7d0a19f095ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 858177dbd89b8e3bc062cd629f8d7d0a19f095ab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21684)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liyubin117 commented on pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
liyubin117 commented on pull request #16738:
URL: https://github.com/apache/flink/pull/16738#issuecomment-894183761
@zentol thanks for your comment.
I resolve the problem as the maintainer of protobuf plugin said
https://github.com/os72/protoc-jar-maven-plugin/issues/68#issuecomment-455424245
the parquet-mr project also encount the problem , and fix in the same way
https://github.com/apache/parquet-mr/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #16738:
URL: https://github.com/apache/flink/pull/16738#issuecomment-894178534
What exactly does this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16738:
URL: https://github.com/apache/flink/pull/16738#issuecomment-894157245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "858177dbd89b8e3bc062cd629f8d7d0a19f095ab",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21684",
"triggerID" : "858177dbd89b8e3bc062cd629f8d7d0a19f095ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 858177dbd89b8e3bc062cd629f8d7d0a19f095ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21684)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liyubin117 edited a comment on pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
liyubin117 edited a comment on pull request #16738:
URL: https://github.com/apache/flink/pull/16738#issuecomment-894183761
@zentol thanks for your comment.
I compile flink on my computer in company where have complex network environment, then encounted the problem.
I resolve the problem as the maintainer of protobuf plugin said
https://github.com/os72/protoc-jar-maven-plugin/issues/68#issuecomment-455424245
the parquet-mr project also encount the problem , and fix in the same way
https://github.com/apache/parquet-mr/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16738:
URL: https://github.com/apache/flink/pull/16738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16738:
URL: https://github.com/apache/flink/pull/16738#issuecomment-894157245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "858177dbd89b8e3bc062cd629f8d7d0a19f095ab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "858177dbd89b8e3bc062cd629f8d7d0a19f095ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 858177dbd89b8e3bc062cd629f8d7d0a19f095ab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16738: [FLINK-23661][build] Fix protobuf plugin proxy issue
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16738:
URL: https://github.com/apache/flink/pull/16738#issuecomment-894139392
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 858177dbd89b8e3bc062cd629f8d7d0a19f095ab (Fri Aug 06 09:40:35 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23661).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org