[GitHub] nwangtw commented on a change in pull request #3154: Fix docker build artifacts script to have the correct version string

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3154: Fix docker build artifacts script to have the correct version string
URL: https://github.com/apache/incubator-heron/pull/3154#discussion_r247317372
 
 

 ##########
 File path: docker/scripts/compile-docker.sh
 ##########
 @@ -51,7 +51,7 @@ echo "Running build in container"
 docker run \
     --rm \
     -e TARGET_PLATFORM=$TARGET_PLATFORM \
-    -e SCRATCH_DIR="/scratch" \
+    -e SCRATCH_DIR="/$HERON_VERSION" \
 
 Review comment:
   In status.sh, version string is decided in two steps:
   1. if [ -d .git ];, find the branch name and use it as version string,
   2. otherwise, use the current directory name as version string.
   
   In docker script, .git file is not available because tarball doesn't include this hidden file. This directory name is used as version number.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services