[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19821: test(native filter): refactor and add new test

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #19821:
URL: https://github.com/apache/superset/pull/19821#discussion_r859488101


##########
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilter.helper.ts:
##########
@@ -0,0 +1,412 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { dashboardView, nativeFilters } from 'cypress/support/directories';
+import { testItems } from './dashboard.helper';
+
+export const nativeFilterTooltips = {
+  searchAllFilterOptions:
+    'By default, each filter loads at most 1000 choices at the initial page load. Check this box if you have more than 1000 filter values and want to enable dynamically searching that loads filter values as users type (may add stress to your database).',
+  defaultToFirstItem: 'When using this option, default value can’t be set',
+  inverseSelection: 'Exclude selected values',
+  required: 'User must select a value before applying the filter',
+  multipleSelect: 'Allow selecting multiple values',
+  defaultValue:
+    'Default value must be set when "Filter value is required" is checked',
+};

Review Comment:
   I am considering the constants whether uses the _original text_ of components rather than hard code in the test case. How about you see this? @michael-s-molina 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org