[GitHub] [kyuubi] huangzhir commented on a diff in pull request #4749: Fix flaky test issues in SchedulerPoolSuite

["huangzhir (via GitHub)" <gi...@apache.org>]

huangzhir commented on code in PR #4749:
URL: https://github.com/apache/kyuubi/pull/4749#discussion_r1173700397


##########
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/SchedulerPoolSuite.scala:
##########
@@ -101,6 +101,10 @@ class SchedulerPoolSuite extends WithSparkSQLEngine with HiveJDBCTestHelper {
       })
       threads.shutdown()
       threads.awaitTermination(20, SECONDS)
+      // make sure the SparkListener has received the finished events for job1 and job2.

Review Comment:
   Thank you for pointing out, KyuubiSparkContextHelper.waitListenerBus is indeed a better idea.The average execution time is reduced by 1 second.
   
   total_time: 882 ,avg_time: 17
   total: 50, success: 50, fail: 0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org