You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lkishalmi (via GitHub)" <gi...@apache.org> on 2025/02/23 01:24:43 UTC
[PR] No wait cursor on CSL navigator expand [netbeans]
lkishalmi opened a new pull request, #8274:
URL: https://github.com/apache/netbeans/pull/8274
Well, I find it a bit annoying, that almost every time I edit a Yaml, HCL file, there is a flickering on the mouse cursor changing to wait cursor and then back.
It turned out that is because the navigator is expanding it's tree to the current location, so when the structure changes it issues an expand and the `TreeView.autoWaitCursor` is `true` by default and put the cursor in wait mode for a brief moment.
That led me to try other parts of the IDE, and expanding nodes could result with a brief mouse cursor change. That made me think to change the `TreeView` behavior. It would be good to have the default for the wait cursor to be `false`, though since it is down in the core I think it's being used many places outside of NetBeans.
Probably the best would be delaying the wait cursor change by 500ms or so, and if the tree could expand it in that time we just do not do that. Might try to create a PR for that one, however for the default CSL provided navigator, I do not thing that we need the `autoWaitCursor` functionality at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] No wait cursor on CSL navigator expand [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #8274:
URL: https://github.com/apache/netbeans/pull/8274#issuecomment-2764286490
Removed the wait cursor form the Java Navigator, also from the Form Designer (Component Explorer), where everything shall be in memory anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] No wait cursor on CSL navigator expand [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi merged PR #8274:
URL: https://github.com/apache/netbeans/pull/8274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] No wait cursor on CSL navigator expand [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8274:
URL: https://github.com/apache/netbeans/pull/8274#discussion_r1966665468
##########
ide/csl.api/src/org/netbeans/modules/csl/navigation/ClassMemberPanelUI.java:
##########
@@ -328,7 +328,6 @@ public void run() {
elementView.setScrollOnExpand( scrollOnExpand );
}
});
- elementView.setAutoWaitCursor(true);
Review Comment:
nothing against this but we should try to keep functionality in sync across the codebase.
the java navigator has the same disable/enable trick in the refresh method:
https://github.com/apache/netbeans/blob/b2bdb81e3893f018bb158d4b5a8826c5787e1bb6/java/java.navigation/src/org/netbeans/modules/java/navigation/ClassMemberPanelUI.java#L427-L429
(there are no other usages looks like)
I think I can see the cursor change for a split second when I toggle collapse/expand in the java navigator.
Disabling the cursor change should be fine UX-wise, since the tree itself has a please-wait placeholder node for situations where it takes longer until the file structure is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists