You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anjiahao1 (via GitHub)" <gi...@apache.org> on 2023/01/28 12:14:25 UTC
[GitHub] [nuttx] anjiahao1 opened a new pull request, #8326: Lisencse:Use BSD & MIT default
anjiahao1 opened a new pull request, #8326:
URL: https://github.com/apache/nuttx/pull/8326
## Summary
Both BSD and MIT lisencse are less different from apache in terms of usage, so modifying them to default is more convenient for code development
## Impact
all
## Testing
Vela
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407411640
@xiaoxiang781216 maybe an better option is to that the original author of this code and ask if he agree to re-license it under Apache. Or, you can do just like Samsung did with NuttX some years ago: add Apache license in the head and keep the BSD license and its author under it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407461131
Yes, I think it is better to remove the #ifdef CONFIG_ALLOW_BSD_COMPONENTS from that file than making ALLOW_BSD_COMPONENTS =y default. If you really want to make ALLOW_BSD_COMPONENTS please include some tainted kernel logic to warn the user at the end of compilation that the generated nuttx.bin is using BSD code that are not protected by Apache license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407408712
@anjiahao1 if BSD or MIT licenses are enabled by default and some BSD or MIT code are included in the final binary we need some way alert the user and ask him to confirm (pressing Y/N question) with this decision.
It is because Apache license theoretically protects again patent litigation, so if some company are using NuttX and has some patented code that was included on NuttX, they cannot sue other company using NuttX, because the license protect that company in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407412253
Other thing I'm thinking now: to use the "tainted kernel" flag like in the Linux kernel. In their case they want all code been GPL without proprietary license. In your case we want all code Apache, so when some code that is BSD/MIT/Other is enabled this flag will change. Then in the final binary we can identify if this flag is enabled and alert the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8326: sys/queue.h:remove CONFIG_ALLOW_MIT_COMPONENTS
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407660721
@acassis done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407412675
> What's the difference if we keep the original BSD license and author without and Apache llicense?
I'm not a lawyer, but when I contacted Samsung many years ago they told me their legal department explained to them this was the right way to do. i.e.: https://github.com/Samsung/TizenRT/blob/master/os/fs/smartfs/smartfs_smart.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407416756
> If so, how about remove CONFIG_ALLOW_BSD_COMPONENTS from the well documented algo(e.g. list, hash...) and pretend Apache copyright before BSD copyright? All these algo exist in the public domain for many years and implement in all OS, I don't believe anyone will raise IP issue for them.
Ok, if you are sure it is Public Domain then you can go ahead and remove this #ifdef. BTW, seems like it was @anjiahao himself that included this code (at least according to git blame)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407434044
> > If so, how about remove CONFIG_ALLOW_BSD_COMPONENTS from the well documented algo(e.g. list, hash...) and pretend Apache copyright before BSD copyright? All these algo exist in the public domain for many years and implement in all OS, I don't believe anyone will raise IP issue for them.
>
> Ok, if you are sure it is Public Domain then you can go ahead and remove this #ifdef.
The code base comes from FreeBSD, I think it's enough to keep the original copyright/owner and record it in LISENCSE since the code just contain the well-known algorithm, no any special/unusual code.
> BTW, seems like it was @anjiahao himself that included this code (at least according to git blame)
It's added during the review(https://github.com/apache/nuttx/pull/6828#pullrequestreview-1068872746), but we found that it's too annoy to condition the frequent used feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8326: sys/queue.h:remove CONFIG_ALLOW_MIT_COMPONENTS
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8326:
URL: https://github.com/apache/nuttx/pull/8326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407410098
If so, for this simple code:
https://github.com/apache/nuttx/blob/master/include/sys/queue.h#L46
does it make sense to be guarded by CONFIG_ALLOW_BSD_COMPONENTS? It's definitely doesn't have any patent issue, but very annoy the end user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407413429
If so, how about remove CONFIG_ALLOW_BSD_COMPONENTS from the well documented algo(e.g. list, hash...) and pretend Apache copyright before BSD copyright? All these algo exist in the public domain for many years and implement in all OS, I don't believe anyone will raise IP issue for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8326: Lisencse:Use BSD & MIT default
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8326:
URL: https://github.com/apache/nuttx/pull/8326#issuecomment-1407412016
What's just keep the original BSD license and author without and Apache llicense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org