[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation
URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r305226295
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/initialization/jetty/ChatHandlerServerModule.java
 ##########
 @@ -67,11 +69,21 @@ public void configure(Binder binder)
 
     Multibinder.newSetBinder(binder, ServletFilterHolder.class).addBinding().to(TaskIdResponseHeaderFilterHolder.class);
 
-    /**
-     * We bind {@link DruidNode} annotated with {@link RemoteChatHandler} to {@literal @}{@link Self} {@link DruidNode}
-     * so that same Jetty Server is used for querying as well as ingestion.
-     */
-    binder.bind(DruidNode.class).annotatedWith(RemoteChatHandler.class).to(Key.get(DruidNode.class, Self.class));
+    if (useSeparatePort) {
+      // bind a modified DruidNode that will be used by the Jetty server installed below
+      binder.bind(DruidNode.class)
 
 Review comment:
   This ends up being unfortunate in that it _requires_ that `druid.service` be set since the 'default' value is not available on the binding at the point that this runs, however I'm not sure how to better fix it :cry:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org