[GitHub] [maven] AlexanderAshitkin edited a comment on issue #288: [MNG-6773] Slow extension key creation in DefaultExtensionRealmCache under lock

[GitBox <gi...@apache.org>]

AlexanderAshitkin edited a comment on issue #288: [MNG-6773] Slow extension key creation in DefaultExtensionRealmCache under lock
URL: https://github.com/apache/maven/pull/288#issuecomment-590137951
 
 
   > For this type of changes I would like to see an ICLA. I'd like to see the results with https://github.com/quick-perf/maven-test-bench to get the confirmation of this fix.
   
   Robert, performance depends on file system. Slower FS - better numbers. In my case (rather slow virtual desktop which nowadays is guess a common case in enterprise worlds) results are:
   Old -T1
   [main] Phase 1: 1406 // phase1 - parse files
   [main] Phase 2: 6539 // phase2 - process references
   [main] Project graph built in: 7958
   
   New -T1
   [main] Phase 1: 1413
   [main] Phase 2: 2450 // this is 4 seconds win for me each time i run any maven command

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services