You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/14 02:00:53 UTC
Review Request 36465: Updated scheduler driver to send REVIVE call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2913
https://issues.apache.org/jira/browse/MESOS-2913
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
Diff: https://reviews.apache.org/r/36465/diff/
Testing
-------
make check
(NOTE: There is already an existing test that tests the revive workflow, but it didn't need any update)
Thanks,
Vinod Kone
Re: Review Request 36465: Updated scheduler driver to send REVIVE
call.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/#review91778
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 14, 2015, midnight, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36465/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, midnight)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2913
> https://issues.apache.org/jira/browse/MESOS-2913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
>
> Diff: https://reviews.apache.org/r/36465/diff/
>
>
> Testing
> -------
>
> make check
>
> (NOTE: There is already an existing test that tests the revive workflow, but it didn't need any update)
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36465: Updated scheduler driver to send REVIVE
call.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 15, 2015, 5:58 p.m., Ben Mahler wrote:
> > src/sched/sched.cpp, line 1029
> > <https://reviews.apache.org/r/36465/diff/1/?file=1010283#file1010283line1029>
> >
> > newline before setting the type, like your other reviews?
i'm doing new line after setting type. i'll make sure it's consistent.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/#review91765
-----------------------------------------------------------
On July 14, 2015, midnight, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36465/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, midnight)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2913
> https://issues.apache.org/jira/browse/MESOS-2913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
>
> Diff: https://reviews.apache.org/r/36465/diff/
>
>
> Testing
> -------
>
> make check
>
> (NOTE: There is already an existing test that tests the revive workflow, but it didn't need any update)
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36465: Updated scheduler driver to send REVIVE
call.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/#review91765
-----------------------------------------------------------
src/sched/sched.cpp (line 1029)
<https://reviews.apache.org/r/36465/#comment145398>
newline before setting the type, like your other reviews?
- Ben Mahler
On July 14, 2015, midnight, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36465/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, midnight)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2913
> https://issues.apache.org/jira/browse/MESOS-2913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
>
> Diff: https://reviews.apache.org/r/36465/diff/
>
>
> Testing
> -------
>
> make check
>
> (NOTE: There is already an existing test that tests the revive workflow, but it didn't need any update)
>
>
> Thanks,
>
> Vinod Kone
>
>