[GitHub] ivankelly closed pull request #2733: Extra logging for offloaders

[GitBox <gi...@apache.org>]

ivankelly closed pull request #2733: Extra logging for offloaders
URL: https://github.com/apache/pulsar/pull/2733
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index 6083c6471a..e9b4c9034b 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -2153,6 +2153,8 @@ private void offloadLoop(CompletableFuture<PositionImpl> promise, Queue<LedgerIn
                     })
                 .whenComplete((ignore, exception) -> {
                         if (exception != null) {
+                            log.info("[{}] Exception occurred during offload", name, exception);
+
                             PositionImpl newFirstUnoffloaded = PositionImpl.get(ledgerId, 0);
                             if (newFirstUnoffloaded.compareTo(firstUnoffloaded) > 0) {
                                 newFirstUnoffloaded = firstUnoffloaded;
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java
index a1d334906c..8726704147 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java
@@ -114,7 +114,7 @@ public static OffloaderDefinition getOffloaderDefinition(String narPath) throws
 
     public static Offloaders searchForOffloaders(String connectorsDirectory) throws IOException {
         Path path = Paths.get(connectorsDirectory).toAbsolutePath();
-        log.info("Searching for connectors in {}", path);
+        log.info("Searching for offloaders in {}", path);
 
         Offloaders offloaders = new Offloaders();
 
@@ -142,6 +142,7 @@ public static Offloaders searchForOffloaders(String connectorsDirectory) throws
                 }
             });
         }
+        log.info("Found and loaded {} offloaders", offloaders.getOffloaders().size());
         return offloaders;
     }
 
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
index 8925c072d6..195f4d57f8 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
@@ -710,6 +710,7 @@ public synchronized LedgerOffloader createManagedLedgerOffloader(ServiceConfigur
                     throw new PulsarServerException(ioe.getMessage(), ioe.getCause());
                 }
             } else {
+                LOG.info("No ledger offloader configured, using NULL instance");
                 return NullLedgerOffloader.INSTANCE;
             }
         } catch (Throwable t) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services