You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/16 12:18:42 UTC

[GitHub] [systemds] Baunsgaard commented on pull request #1277: [SYSTEMDS-2922] Federated Fused Codegen Operator - Multi Aggregate

Baunsgaard commented on pull request #1277:
URL: https://github.com/apache/systemds/pull/1277#issuecomment-841809589


   > Hi,
   > This is a PR for adding federated code generation for multi aggregate templates, and the respective tests (hybrid execution mode to reduce the test time).
   > NOTE: All three test modes are working (SingleNode, Spark, Hybrid) for all testcases (also the outcommented tests).
   > 
   > Thanks for review :)
   
   I would suggest adding an @ignore flag on the tests that you outcommented. This makes them not run, but be part of the output so that it is easy to spot that there are some extra tests, and furthermore it should be possible to force them to run without having to change a single line of code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org