[jira] [Comment Edited] (YARN-3945) maxApplicationsPerUser is wrongly calculated

["Wangda Tan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106191#comment-15106191 ] 

Wangda Tan edited comment on YARN-3945 at 1/19/16 3:31 AM:
-----------------------------------------------------------

bq. i feel better not to consider userLimit and userLimitFactor at all, to reduce the confusion for the number of applications per user.
I would prefer this proposal.

bq. IMO numAppsPerUser can be greater than numAppsPerQueue and user-resource and user-am-resource greater than the queue's resource or queue's AM resource only when userLimitFactor is of really greater value, so is it actually required to be greater than 1, Is it sufficient to restrict this to 1 ?
I think it's better to only cap it by the max possible value of queue (queue's max capacity / queue's max application number). User can still set ULF as he wants, but we will return capped value to user.

Changing max value of ULF will be an incompatible changes, since lots of cluster are using very high ULF (e.g. 100). 


was (Author: leftnoteasy):
bq. i feel better not to consider userLimit and userLimitFactor at all, to reduce the confusion for the number of applications per user.
I would prefer this proposal.

bq. IMO numAppsPerUser can be greater than numAppsPerQueue and user-resource and user-am-resource greater than the queue's resource or queue's AM resource only when userLimitFactor is of really greater value, so is it actually required to be greater than 1, Is it sufficient to restrict this to 1 ?
I think it's better to only cap it by the max possible value of queue (queue's max capacity / queue's max application number). User can still set ULF as he wants, but we will return capped value to user.

> maxApplicationsPerUser is wrongly calculated
> --------------------------------------------
>
>                 Key: YARN-3945
>                 URL: https://issues.apache.org/jira/browse/YARN-3945
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>    Affects Versions: 2.7.1
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3945.20150728-1.patch, YARN-3945.20150729-1.patch, YARN-3945.V1.003.patch
>
>
> maxApplicationsPerUser is currently calculated based on the formula
> {{maxApplicationsPerUser = (int)(maxApplications * (userLimit / 100.0f) * userLimitFactor)}} but description of userlimit is 
> {quote}
> Each queue enforces a limit on the percentage of resources allocated to a user at any given time, if there is demand for resources. The user limit can vary between a minimum and maximum value.{color:red} The the former (the minimum value) is set to this property value {color} and the latter (the maximum value) depends on the number of users who have submitted applications. For e.g., suppose the value of this property is 25. If two users have submitted applications to a queue, no single user can use more than 50% of the queue resources. If a third user submits an application, no single user can use more than 33% of the queue resources. With 4 or more users, no user can use more than 25% of the queues resources. A value of 100 implies no user limits are imposed. The default is 100. Value is specified as a integer.
> {quote}
> configuration related to minimum limit should not be made used in a formula to calculate max applications for a user



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)