You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/01 01:29:43 UTC

[kudu-CR] KuduRPC integration with OpenSSL

Dan Burkert has posted comments on this change.

Change subject: KuduRPC integration with OpenSSL
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

LGTM, just a few small nits.

http://gerrit.cloudera.org:8080/#/c/4789/7/src/kudu/util/net/ssl_socket.cc
File src/kudu/util/net/ssl_socket.cc:

PS7, Line 77: retreive
retrieve


PS7, Line 86: NULL
nullptr


-- 
To view, visit http://gerrit.cloudera.org:8080/4789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27167faa4e6a78e59b46093055b16682c93af0ea
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes