You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/30 10:21:49 UTC

[GitHub] [arrow-datafusion] Dandandan opened a new issue #444: Make AggregateFunction take a single argument

Dandandan opened a new issue #444:
URL: https://github.com/apache/arrow-datafusion/issues/444


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   This makes the representation of aggregate functions more correct, makes code dealing with aggregate functions more simple.
   
   **Describe the solution you'd like**
   Instead of `Vec<Expr>` use `Box<Expr>`
   
   **Describe alternatives you've considered**
   Keeping it as is.
   
   **Additional context**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan closed issue #444: Make AggregateFunction take a single argument

Posted by GitBox <gi...@apache.org>.
Dandandan closed issue #444:
URL: https://github.com/apache/arrow-datafusion/issues/444


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #444: Make AggregateFunction take a single argument

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on issue #444:
URL: https://github.com/apache/arrow-datafusion/issues/444#issuecomment-850976838


   fyi, the goal of being `Vec` was to allow multi-argument aggregates. An example is the person correlation between two columns (which can currently be implemented via a UDAF)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on issue #444: Make AggregateFunction take a single argument

Posted by GitBox <gi...@apache.org>.
Dandandan commented on issue #444:
URL: https://github.com/apache/arrow-datafusion/issues/444#issuecomment-850977249


   @jorgecarleitao Ah, yeah I think that makes sense. I'll just take care of it.
   
   I think there is still some code (e.g. in Ballista protobuf I believe) that assumes only 1 argument, so when we are going to support that, it should be adapted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jorgecarleitao edited a comment on issue #444: Make AggregateFunction take a single argument

Posted by GitBox <gi...@apache.org>.
jorgecarleitao edited a comment on issue #444:
URL: https://github.com/apache/arrow-datafusion/issues/444#issuecomment-850976838


   fyi, the goal of being `Vec` was to allow multi-argument aggregates. An example is the pearson correlation between two columns (which can currently be implemented via a UDAF)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org