You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/03/25 16:33:21 UTC
[kudu-CR] gutil: bump up linux-syscall-support.h
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15557
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
gutil: bump up linux-syscall-support.h
Bump up linux-syscall-support.h to newest version
which support aarch64
This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).
Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
3 files changed, 1,746 insertions(+), 891 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15557/1
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 2:
(1 comment)
FYI there's another outstanding patch that also bumps the file: https://gerrit.cloudera.org/c/14964/7/src/kudu/gutil/linux_syscall_support.h
It hasn't moved in a while so don't feel like you need to coordinate, but it'd be good to compare the version you're bumping to and that version just to make sure they're roughly the same (or ideally, exactly the same).
http://gerrit.cloudera.org:8080/#/c/15557/2/src/kudu/gutil/spinlock_linux-inl.h
File src/kudu/gutil/spinlock_linux-inl.h:
PS2:
Here and elsewhere, use nullptr in C++ code.
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 20:11:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 22:59:36 +0000
Gerrit-HasComments: No
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 2:
(1 comment)
It looks like the other patch has an older version of linux-syscall-support.h. It seems better to bring it up to date with upstream.
TSAN error that caused the test failure is below. I couldn't find a related JIRA but couldn't reproduce locally or see how it might've been caused by this patch (maybe messing with futex did something?). Not sure how to proceed with debugging this.
WARNING: ThreadSanitizer: data race (pid=12896)
Write of size 8 at 0x7b2c000672b8 by main thread:
#0 operator delete(void*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:126 (tablet_server_quiescing-itest+0x4f5119)
#1 std::__1::default_delete<kudu::ThreadPoolToken>::operator()(kudu::ThreadPoolToken*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_util.so+0x2f48b6)
#2 std::__1::unique_ptr<kudu::ThreadPoolToken, std::__1::default_delete<kudu::ThreadPoolToken> >::reset(kudu::ThreadPoolToken*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (libkudu_util.so+0x2f481d)
#3 std::__1::unique_ptr<kudu::ThreadPoolToken, std::__1::default_delete<kudu::ThreadPoolToken> >::~unique_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19 (libkudu_util.so+0x2eeccb)
#4 kudu::ThreadPool::~ThreadPool() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:300:1 (libkudu_util.so+0x2eb29e)
#5 std::__1::default_delete<kudu::ThreadPool>::operator()(kudu::ThreadPool*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_util.so+0x23638e)
#6 std::__1::unique_ptr<kudu::ThreadPool, std::__1::default_delete<kudu::ThreadPool> >::reset(kudu::ThreadPool*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (libkudu_util.so+0x2362fd)
#7 std::__1::unique_ptr<kudu::ThreadPool, std::__1::default_delete<kudu::ThreadPool> >::~unique_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19 (libkudu_util.so+0x230d6b)
#8 kudu::DnsResolver::~DnsResolver() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/net/dns_resolver.cc:72:1 (libkudu_util.so+0x27ae63)
#9 std::__1::default_delete<kudu::DnsResolver>::operator()(kudu::DnsResolver*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_client.so+0x1eb22e)
#10 std::__1::unique_ptr<kudu::DnsResolver, std::__1::default_delete<kudu::DnsResolver> >::reset(kudu::DnsResolver*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (libkudu_client.so+0x1e20fd)
#11 kudu::client::KuduClient::Data::~Data() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client-internal.cc:184:17 (libkudu_client.so+0x1dd71d)
#12 kudu::client::KuduClient::~KuduClient() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client.cc:396:3 (libkudu_client.so+0x1981dc)
#13 std::__1::default_delete<kudu::client::KuduClient>::operator()(kudu::client::KuduClient*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_client.so+0x1bd11e)
#14 std::__1::__shared_ptr_pointer<kudu::client::KuduClient*, std::__1::default_delete<kudu::client::KuduClient>, std::__1::allocator<kudu::client::KuduClient> >::__on_zero_shared() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3511:5 (libkudu_client.so+0x1bce62)
#15 std::__1::__shared_count::__release_shared() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3415:9 (tablet_server_quiescing-itest+0x520b55)
#16 std::__1::__shared_weak_count::__release_shared() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3457:27 (tablet_server_quiescing-itest+0x520af9)
#17 std::__1::shared_ptr<kudu::client::KuduClient>::~shared_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:4393:19 (tablet_server_quiescing-itest+0x520688)
#18 kudu::TestWorkload::~TestWorkload() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/test_workload.cc:96:1 (libitest_util.so+0xc1922)
#19 std::__1::default_delete<kudu::TestWorkload>::operator()(kudu::TestWorkload*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (tablet_server_quiescing-itest+0x52edde)
#20 std::__1::unique_ptr<kudu::TestWorkload, std::__1::default_delete<kudu::TestWorkload> >::reset(kudu::TestWorkload*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (tablet_server_quiescing-itest+0x52ed4d)
#21 std::__1::unique_ptr<kudu::TestWorkload, std::__1::default_delete<kudu::TestWorkload> >::~unique_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19 (tablet_server_quiescing-itest+0x51d27b)
#22 kudu::itest::TServerQuiescingITest_TestDoesntAllowNewScansLeadersOnly_Test::TestBody() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc:305:1 (tablet_server_quiescing-itest+0x4f94b7)
#23 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x54f9f)
#24 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x54f9f)
#25 testing::Test::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2474:5 (libgmock.so+0x33f38)
#26 testing::TestInfo::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x351dc)
#27 testing::TestCase::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x35ef6)
#28 testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x423a6)
#29 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x55e4f)
#30 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x55e4f)
#31 testing::UnitTest::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x41c61)
#32 RUN_ALL_TESTS() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x47bb)
#33 main /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x3636)
Previous read of size 8 at 0x7b2c000672b8 by thread T15:
#0 scoped_refptr<kudu::Histogram>::operator kudu::Histogram* scoped_refptr<kudu::Histogram>::*() const /home/jenkins-slave/workspace/kudu-master/1/src/kudu/gutil/ref_counted.h:280:38 (tablet_server_quiescing-itest+0x527eb9)
#1 kudu::ThreadPool::DoSubmit(std::__1::function<void ()>, kudu::ThreadPoolToken*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:501:7 (libkudu_util.so+0x2ea20a)
#2 kudu::ThreadPool::Submit(std::__1::function<void ()>) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:408:10 (libkudu_util.so+0x2ebb12)
#3 kudu::DnsResolver::ResolveAddressesAsync(kudu::HostPort const&, std::__1::vector<kudu::Sockaddr, std::__1::allocator<kudu::Sockaddr> >*, kudu::Callback<void (kudu::Status const&)> const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/net/dns_resolver.cc:88:25 (libkudu_util.so+0x27b3a7)
#4 kudu::client::internal::RemoteTabletServer::InitProxy(kudu::client::KuduClient*, kudu::Callback<void (kudu::Status const&)> const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/meta_cache.cc:135:33 (libkudu_client.so+0x235074)
#5 kudu::client::internal::MetaCacheServerPicker::PickLeader(kudu::Callback<void (kudu::Status const&, kudu::client::internal::RemoteTabletServer*)> const&, kudu::MonoTime const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/meta_cache.cc:465:11 (libkudu_client.so+0x23713d)
#6 kudu::rpc::RetriableRpc<kudu::client::internal::RemoteTabletServer, kudu::tserver::WriteRequestPB, kudu::tserver::WriteResponsePB>::SendRpc() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/retriable_rpc.h:165:19 (libkudu_client.so+0x1870e5)
#7 kudu::rpc::RpcRetrier::DelayedRetryCb(kudu::rpc::Rpc*, kudu::Status const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/rpc.cc:81:10 (libkrpc.so+0x12d5b5)
#8 boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>::operator()(kudu::rpc::RpcRetrier*, kudu::rpc::Rpc*, kudu::Status const&) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/mem_fn_template.hpp:280:29 (libkrpc.so+0x12e03a)
#9 void boost::_bi::list3<boost::_bi::value<kudu::rpc::RpcRetrier*>, boost::_bi::value<kudu::rpc::Rpc*>, boost::arg<1> >::operator()<boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>, boost::_bi::rrlist1<kudu::Status const&> >(boost::_bi::type<void>, boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>&, boost::_bi::rrlist1<kudu::Status const&>&, int) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/bind.hpp:398:9 (libkrpc.so+0x12df72)
#10 void boost::_bi::bind_t<void, boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>, boost::_bi::list3<boost::_bi::value<kudu::rpc::RpcRetrier*>, boost::_bi::value<kudu::rpc::Rpc*>, boost::arg<1> > >::operator()<kudu::Status const&>(kudu::Status const&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/bind.hpp:1234:16 (libkrpc.so+0x12de98)
#11 boost::detail::function::void_function_obj_invoker1<boost::_bi::bind_t<void, boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>, boost::_bi::list3<boost::_bi::value<kudu::rpc::RpcRetrier*>, boost::_bi::value<kudu::rpc::Rpc*>, boost::arg<1> > >, void, kudu::Status const&>::invoke(boost::detail::function::function_buffer&, kudu::Status const&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/function/function_template.hpp:159:11 (libkrpc.so+0x12dc33)
#12 boost::function1<void, kudu::Status const&>::operator()(kudu::Status const&) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/function/function_template.hpp:770:14 (libkrpc.so+0x10ce54)
#13 kudu::rpc::DelayedTask::TimerHandler(ev::timer&, int) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:747:5 (libkrpc.so+0x1075b4)
#14 void ev::base<ev_timer, ev::timer>::method_thunk<kudu::rpc::DelayedTask, &(kudu::rpc::DelayedTask::TimerHandler(ev::timer&, int))>(ev_loop*, ev_timer*, int) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/ev++.h:479:7 (libkrpc.so+0x114cba)
#15 ev_invoke_pending /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/libev-4.20/ev.c:3155:11 (libev.so.4+0x9a52)
#16 kudu::rpc::ReactorThread::InvokePendingCb(ev_loop*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:197:3 (libkrpc.so+0x103695)
#17 ev_run /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/libev-4.20/ev.c:3555:7 (libev.so.4+0xabfc)
#18 ev::loop_ref::run(int) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/ev++.h:211:7 (libkrpc.so+0x10c4e8)
#19 kudu::rpc::ReactorThread::RunThread() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:498:9 (libkrpc.so+0x10685b)
#20 kudu::rpc::ReactorThread::Init()::$_0::operator()() const /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:189:48 (libkrpc.so+0x1097f1)
#21 decltype(std::__1::forward<kudu::rpc::ReactorThread::Init()::$_0&>(fp)()) std::__1::__invoke<kudu::rpc::ReactorThread::Init()::$_0&>(kudu::rpc::ReactorThread::Init()::$_0&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/type_traits:3530:1 (libkrpc.so+0x109781)
#22 void std::__1::__invoke_void_return_wrapper<void>::__call<kudu::rpc::ReactorThread::Init()::$_0&>(kudu::rpc::ReactorThread::Init()::$_0&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/__functional_base:348:9 (libkrpc.so+0x109711)
#23 std::__1::__function::__alloc_func<kudu::rpc::ReactorThread::Init()::$_0, std::__1::allocator<kudu::rpc::ReactorThread::Init()::$_0>, void ()>::operator()() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:1533:16 (libkrpc.so+0x1096d1)
#24 std::__1::__function::__func<kudu::rpc::ReactorThread::Init()::$_0, std::__1::allocator<kudu::rpc::ReactorThread::Init()::$_0>, void ()>::operator()() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:1707:12 (libkrpc.so+0x10876d)
#25 std::__1::__function::__value_func<void ()>::operator()() const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:1860:16 (libkrpc.so+0x100744)
#26 std::__1::function<void ()>::operator()() const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:2419:12 (libkrpc.so+0xfe469)
#27 kudu::Thread::SuperviseThread(void*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/thread.cc:674:3 (libkudu_util.so+0x2d473a)
As if synchronized via sleep:
#0 usleep /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:354 (tablet_server_quiescing-itest+0x45a342)
#1 sq_stop /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/squeasel-030ccce87359d892e22fb368c5fc5b75d9a2a5f7/squeasel.c:4960:12 (libserver_process.so+0x111229)
#2 kudu::Webserver::Stop() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/server/webserver.cc:392:5 (libserver_process.so+0xe4db2)
#3 kudu::server::ServerBase::ShutdownImpl() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/server/server_base.cc:719:18 (libserver_process.so+0xb9782)
#4 kudu::server::ServerBase::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/server/server_base.h:145:5 (libkserver.so+0xb389)
#5 kudu::kserver::KuduServer::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/kserver/kserver.cc:199:15 (libkserver.so+0xa6b3)
#6 kudu::tserver::TabletServer::ShutdownImpl() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server.cc:167:17 (libtserver.so+0x16e6ce)
#7 kudu::tserver::TabletServer::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server.h:64:5 (libtserver.so+0x1702b9)
#8 kudu::tserver::MiniTabletServer::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/mini_tablet_server.cc:116:14 (libtserver.so+0x10d843)
#9 kudu::itest::TServerQuiescingITest_TestDoesntAllowNewScansLeadersOnly_Test::TestBody() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc:301:7 (tablet_server_quiescing-itest+0x4f941f)
#10 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x54f9f)
#11 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x54f9f)
#12 testing::Test::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2474:5 (libgmock.so+0x33f38)
#13 testing::TestInfo::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x351dc)
#14 testing::TestCase::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x35ef6)
#15 testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x423a6)
#16 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x55e4f)
#17 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x55e4f)
#18 testing::UnitTest::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x41c61)
#19 RUN_ALL_TESTS() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x47bb)
#20 main /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x3636)
Thread T15 'rpc reactor-145' (tid=14548, running) created by main thread at:
#0 pthread_create /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:967 (tablet_server_quiescing-itest+0x451e29)
#1 kudu::Thread::StartThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::function<void ()>, unsigned long, scoped_refptr<kudu::Thread>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/thread.cc:618:15 (libkudu_util.so+0x2d3faa)
#2 kudu::Thread::Create(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::function<void ()>, scoped_refptr<kudu::Thread>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/thread.h:146:12 (libmaster.so+0x18e829)
#3 kudu::rpc::ReactorThread::Init() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:188:10 (libkrpc.so+0x1033e6)
#4 kudu::rpc::Reactor::Init() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:764:18 (libkrpc.so+0x107931)
#5 kudu::rpc::Messenger::Init() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/messenger.cc:447:5 (libkrpc.so+0xe21dd)
#6 kudu::rpc::MessengerBuilder::Build(std::__1::shared_ptr<kudu::rpc::Messenger>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/messenger.cc:203:3 (libkrpc.so+0xe1d07)
#7 kudu::client::KuduClientBuilder::Build(std::__1::shared_ptr<kudu::client::KuduClient>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client.cc:351:3 (libkudu_client.so+0x197767)
#8 kudu::cluster::InternalMiniCluster::CreateClient(kudu::client::KuduClientBuilder*, std::__1::shared_ptr<kudu::client::KuduClient>*) const /home/jenkins-slave/workspace/kudu-master/1/src/kudu/mini-cluster/internal_mini_cluster.cc:350:19 (libmini_cluster.so+0x75d76)
#9 kudu::TestWorkload::Setup() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/test_workload.cc:290:5 (libitest_util.so+0xc3712)
#10 kudu::itest::TServerQuiescingITest_TestDoesntAllowNewScansLeadersOnly_Test::TestBody() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc:279:16 (tablet_server_quiescing-itest+0x4f9337)
#11 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x54f9f)
#12 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x54f9f)
#13 testing::Test::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2474:5 (libgmock.so+0x33f38)
#14 testing::TestInfo::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x351dc)
#15 testing::TestCase::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x35ef6)
#16 testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x423a6)
#17 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x55e4f)
#18 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x55e4f)
#19 testing::UnitTest::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x41c61)
#20 RUN_ALL_TESTS() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x47bb)
#21 main /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x3636)
http://gerrit.cloudera.org:8080/#/c/15557/2/src/kudu/gutil/spinlock_linux-inl.h
File src/kudu/gutil/spinlock_linux-inl.h:
PS2:
> Here and elsewhere, use nullptr in C++ code.
Updated all the files except linux_syscall_support.h, where it seemed better to keep the file in sync with upstream (it seems like the file is meant to be C-compatible anyways so they're unlikely to replace NULL with nullptr). I can fix up that file too if you prefer.
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 22:47:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, zhaorenhai@hotmail.com, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15557
to look at the new patch set (#2).
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
gutil: bump up linux-syscall-support.h
Bump up linux-syscall-support.h to newest version
which support aarch64 - commit fd00dbb from
https://chromium.googlesource.com/linux-syscall-support/
This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).
Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
M src/kudu/util/notification.h
4 files changed, 1,748 insertions(+), 893 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15557/2
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG@9
PS1, Line 9: linux-syscall-support.h
> Could you add information on the original upstream source (if any) of the l
Done
http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc
File src/kudu/util/debug-util.cc:
http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc@166
PS1, Line 166:
> nit: spacing -- using spaces instead of tabs for the indent
Done
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 17:52:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 3:
(1 comment)
> Patch Set 2:
>
> (1 comment)
>
> It looks like the other patch has an older version of linux-syscall-support.h. It seems better to bring it up to date with upstream.
>
> TSAN error that caused the test failure is below. I couldn't find a related JIRA but couldn't reproduce locally or see how it might've been caused by this patch (maybe messing with futex did something?). Not sure how to proceed with debugging this.
>
> WARNING: ThreadSanitizer: data race (pid=12896)
> Write of size 8 at 0x7b2c000672b8 by main thread:
> #0 operator delete(void*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:126 (tablet_server_quiescing-itest+0x4f5119)
> #1 std::__1::default_delete<kudu::ThreadPoolToken>::operator()(kudu::ThreadPoolToken*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_util.so+0x2f48b6)
> #2 std::__1::unique_ptr<kudu::ThreadPoolToken, std::__1::default_delete<kudu::ThreadPoolToken> >::reset(kudu::ThreadPoolToken*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (libkudu_util.so+0x2f481d)
> #3 std::__1::unique_ptr<kudu::ThreadPoolToken, std::__1::default_delete<kudu::ThreadPoolToken> >::~unique_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19 (libkudu_util.so+0x2eeccb)
> #4 kudu::ThreadPool::~ThreadPool() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:300:1 (libkudu_util.so+0x2eb29e)
> #5 std::__1::default_delete<kudu::ThreadPool>::operator()(kudu::ThreadPool*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_util.so+0x23638e)
> #6 std::__1::unique_ptr<kudu::ThreadPool, std::__1::default_delete<kudu::ThreadPool> >::reset(kudu::ThreadPool*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (libkudu_util.so+0x2362fd)
> #7 std::__1::unique_ptr<kudu::ThreadPool, std::__1::default_delete<kudu::ThreadPool> >::~unique_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19 (libkudu_util.so+0x230d6b)
> #8 kudu::DnsResolver::~DnsResolver() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/net/dns_resolver.cc:72:1 (libkudu_util.so+0x27ae63)
> #9 std::__1::default_delete<kudu::DnsResolver>::operator()(kudu::DnsResolver*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_client.so+0x1eb22e)
> #10 std::__1::unique_ptr<kudu::DnsResolver, std::__1::default_delete<kudu::DnsResolver> >::reset(kudu::DnsResolver*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (libkudu_client.so+0x1e20fd)
> #11 kudu::client::KuduClient::Data::~Data() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client-internal.cc:184:17 (libkudu_client.so+0x1dd71d)
> #12 kudu::client::KuduClient::~KuduClient() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client.cc:396:3 (libkudu_client.so+0x1981dc)
> #13 std::__1::default_delete<kudu::client::KuduClient>::operator()(kudu::client::KuduClient*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (libkudu_client.so+0x1bd11e)
> #14 std::__1::__shared_ptr_pointer<kudu::client::KuduClient*, std::__1::default_delete<kudu::client::KuduClient>, std::__1::allocator<kudu::client::KuduClient> >::__on_zero_shared() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3511:5 (libkudu_client.so+0x1bce62)
> #15 std::__1::__shared_count::__release_shared() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3415:9 (tablet_server_quiescing-itest+0x520b55)
> #16 std::__1::__shared_weak_count::__release_shared() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3457:27 (tablet_server_quiescing-itest+0x520af9)
> #17 std::__1::shared_ptr<kudu::client::KuduClient>::~shared_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:4393:19 (tablet_server_quiescing-itest+0x520688)
> #18 kudu::TestWorkload::~TestWorkload() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/test_workload.cc:96:1 (libitest_util.so+0xc1922)
> #19 std::__1::default_delete<kudu::TestWorkload>::operator()(kudu::TestWorkload*) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5 (tablet_server_quiescing-itest+0x52edde)
> #20 std::__1::unique_ptr<kudu::TestWorkload, std::__1::default_delete<kudu::TestWorkload> >::reset(kudu::TestWorkload*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7 (tablet_server_quiescing-itest+0x52ed4d)
> #21 std::__1::unique_ptr<kudu::TestWorkload, std::__1::default_delete<kudu::TestWorkload> >::~unique_ptr() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19 (tablet_server_quiescing-itest+0x51d27b)
> #22 kudu::itest::TServerQuiescingITest_TestDoesntAllowNewScansLeadersOnly_Test::TestBody() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc:305:1 (tablet_server_quiescing-itest+0x4f94b7)
> #23 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x54f9f)
> #24 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x54f9f)
> #25 testing::Test::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2474:5 (libgmock.so+0x33f38)
> #26 testing::TestInfo::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x351dc)
> #27 testing::TestCase::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x35ef6)
> #28 testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x423a6)
> #29 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x55e4f)
> #30 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x55e4f)
> #31 testing::UnitTest::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x41c61)
> #32 RUN_ALL_TESTS() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x47bb)
> #33 main /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x3636)
>
> Previous read of size 8 at 0x7b2c000672b8 by thread T15:
> #0 scoped_refptr<kudu::Histogram>::operator kudu::Histogram* scoped_refptr<kudu::Histogram>::*() const /home/jenkins-slave/workspace/kudu-master/1/src/kudu/gutil/ref_counted.h:280:38 (tablet_server_quiescing-itest+0x527eb9)
> #1 kudu::ThreadPool::DoSubmit(std::__1::function<void ()>, kudu::ThreadPoolToken*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:501:7 (libkudu_util.so+0x2ea20a)
> #2 kudu::ThreadPool::Submit(std::__1::function<void ()>) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:408:10 (libkudu_util.so+0x2ebb12)
> #3 kudu::DnsResolver::ResolveAddressesAsync(kudu::HostPort const&, std::__1::vector<kudu::Sockaddr, std::__1::allocator<kudu::Sockaddr> >*, kudu::Callback<void (kudu::Status const&)> const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/net/dns_resolver.cc:88:25 (libkudu_util.so+0x27b3a7)
> #4 kudu::client::internal::RemoteTabletServer::InitProxy(kudu::client::KuduClient*, kudu::Callback<void (kudu::Status const&)> const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/meta_cache.cc:135:33 (libkudu_client.so+0x235074)
> #5 kudu::client::internal::MetaCacheServerPicker::PickLeader(kudu::Callback<void (kudu::Status const&, kudu::client::internal::RemoteTabletServer*)> const&, kudu::MonoTime const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/meta_cache.cc:465:11 (libkudu_client.so+0x23713d)
> #6 kudu::rpc::RetriableRpc<kudu::client::internal::RemoteTabletServer, kudu::tserver::WriteRequestPB, kudu::tserver::WriteResponsePB>::SendRpc() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/retriable_rpc.h:165:19 (libkudu_client.so+0x1870e5)
> #7 kudu::rpc::RpcRetrier::DelayedRetryCb(kudu::rpc::Rpc*, kudu::Status const&) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/rpc.cc:81:10 (libkrpc.so+0x12d5b5)
> #8 boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>::operator()(kudu::rpc::RpcRetrier*, kudu::rpc::Rpc*, kudu::Status const&) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/mem_fn_template.hpp:280:29 (libkrpc.so+0x12e03a)
> #9 void boost::_bi::list3<boost::_bi::value<kudu::rpc::RpcRetrier*>, boost::_bi::value<kudu::rpc::Rpc*>, boost::arg<1> >::operator()<boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>, boost::_bi::rrlist1<kudu::Status const&> >(boost::_bi::type<void>, boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>&, boost::_bi::rrlist1<kudu::Status const&>&, int) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/bind.hpp:398:9 (libkrpc.so+0x12df72)
> #10 void boost::_bi::bind_t<void, boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>, boost::_bi::list3<boost::_bi::value<kudu::rpc::RpcRetrier*>, boost::_bi::value<kudu::rpc::Rpc*>, boost::arg<1> > >::operator()<kudu::Status const&>(kudu::Status const&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/bind.hpp:1234:16 (libkrpc.so+0x12de98)
> #11 boost::detail::function::void_function_obj_invoker1<boost::_bi::bind_t<void, boost::_mfi::mf2<void, kudu::rpc::RpcRetrier, kudu::rpc::Rpc*, kudu::Status const&>, boost::_bi::list3<boost::_bi::value<kudu::rpc::RpcRetrier*>, boost::_bi::value<kudu::rpc::Rpc*>, boost::arg<1> > >, void, kudu::Status const&>::invoke(boost::detail::function::function_buffer&, kudu::Status const&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/function/function_template.hpp:159:11 (libkrpc.so+0x12dc33)
> #12 boost::function1<void, kudu::Status const&>::operator()(kudu::Status const&) const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/function/function_template.hpp:770:14 (libkrpc.so+0x10ce54)
> #13 kudu::rpc::DelayedTask::TimerHandler(ev::timer&, int) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:747:5 (libkrpc.so+0x1075b4)
> #14 void ev::base<ev_timer, ev::timer>::method_thunk<kudu::rpc::DelayedTask, &(kudu::rpc::DelayedTask::TimerHandler(ev::timer&, int))>(ev_loop*, ev_timer*, int) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/ev++.h:479:7 (libkrpc.so+0x114cba)
> #15 ev_invoke_pending /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/libev-4.20/ev.c:3155:11 (libev.so.4+0x9a52)
> #16 kudu::rpc::ReactorThread::InvokePendingCb(ev_loop*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:197:3 (libkrpc.so+0x103695)
> #17 ev_run /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/libev-4.20/ev.c:3555:7 (libev.so.4+0xabfc)
> #18 ev::loop_ref::run(int) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/ev++.h:211:7 (libkrpc.so+0x10c4e8)
> #19 kudu::rpc::ReactorThread::RunThread() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:498:9 (libkrpc.so+0x10685b)
> #20 kudu::rpc::ReactorThread::Init()::$_0::operator()() const /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:189:48 (libkrpc.so+0x1097f1)
> #21 decltype(std::__1::forward<kudu::rpc::ReactorThread::Init()::$_0&>(fp)()) std::__1::__invoke<kudu::rpc::ReactorThread::Init()::$_0&>(kudu::rpc::ReactorThread::Init()::$_0&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/type_traits:3530:1 (libkrpc.so+0x109781)
> #22 void std::__1::__invoke_void_return_wrapper<void>::__call<kudu::rpc::ReactorThread::Init()::$_0&>(kudu::rpc::ReactorThread::Init()::$_0&) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/__functional_base:348:9 (libkrpc.so+0x109711)
> #23 std::__1::__function::__alloc_func<kudu::rpc::ReactorThread::Init()::$_0, std::__1::allocator<kudu::rpc::ReactorThread::Init()::$_0>, void ()>::operator()() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:1533:16 (libkrpc.so+0x1096d1)
> #24 std::__1::__function::__func<kudu::rpc::ReactorThread::Init()::$_0, std::__1::allocator<kudu::rpc::ReactorThread::Init()::$_0>, void ()>::operator()() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:1707:12 (libkrpc.so+0x10876d)
> #25 std::__1::__function::__value_func<void ()>::operator()() const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:1860:16 (libkrpc.so+0x100744)
> #26 std::__1::function<void ()>::operator()() const /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/functional:2419:12 (libkrpc.so+0xfe469)
> #27 kudu::Thread::SuperviseThread(void*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/thread.cc:674:3 (libkudu_util.so+0x2d473a)
>
> As if synchronized via sleep:
> #0 usleep /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:354 (tablet_server_quiescing-itest+0x45a342)
> #1 sq_stop /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/squeasel-030ccce87359d892e22fb368c5fc5b75d9a2a5f7/squeasel.c:4960:12 (libserver_process.so+0x111229)
> #2 kudu::Webserver::Stop() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/server/webserver.cc:392:5 (libserver_process.so+0xe4db2)
> #3 kudu::server::ServerBase::ShutdownImpl() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/server/server_base.cc:719:18 (libserver_process.so+0xb9782)
> #4 kudu::server::ServerBase::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/server/server_base.h:145:5 (libkserver.so+0xb389)
> #5 kudu::kserver::KuduServer::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/kserver/kserver.cc:199:15 (libkserver.so+0xa6b3)
> #6 kudu::tserver::TabletServer::ShutdownImpl() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server.cc:167:17 (libtserver.so+0x16e6ce)
> #7 kudu::tserver::TabletServer::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server.h:64:5 (libtserver.so+0x1702b9)
> #8 kudu::tserver::MiniTabletServer::Shutdown() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/mini_tablet_server.cc:116:14 (libtserver.so+0x10d843)
> #9 kudu::itest::TServerQuiescingITest_TestDoesntAllowNewScansLeadersOnly_Test::TestBody() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc:301:7 (tablet_server_quiescing-itest+0x4f941f)
> #10 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x54f9f)
> #11 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x54f9f)
> #12 testing::Test::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2474:5 (libgmock.so+0x33f38)
> #13 testing::TestInfo::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x351dc)
> #14 testing::TestCase::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x35ef6)
> #15 testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x423a6)
> #16 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x55e4f)
> #17 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x55e4f)
> #18 testing::UnitTest::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x41c61)
> #19 RUN_ALL_TESTS() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x47bb)
> #20 main /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x3636)
>
> Thread T15 'rpc reactor-145' (tid=14548, running) created by main thread at:
> #0 pthread_create /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:967 (tablet_server_quiescing-itest+0x451e29)
> #1 kudu::Thread::StartThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::function<void ()>, unsigned long, scoped_refptr<kudu::Thread>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/thread.cc:618:15 (libkudu_util.so+0x2d3faa)
> #2 kudu::Thread::Create(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::function<void ()>, scoped_refptr<kudu::Thread>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/thread.h:146:12 (libmaster.so+0x18e829)
> #3 kudu::rpc::ReactorThread::Init() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:188:10 (libkrpc.so+0x1033e6)
> #4 kudu::rpc::Reactor::Init() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/reactor.cc:764:18 (libkrpc.so+0x107931)
> #5 kudu::rpc::Messenger::Init() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/messenger.cc:447:5 (libkrpc.so+0xe21dd)
> #6 kudu::rpc::MessengerBuilder::Build(std::__1::shared_ptr<kudu::rpc::Messenger>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/rpc/messenger.cc:203:3 (libkrpc.so+0xe1d07)
> #7 kudu::client::KuduClientBuilder::Build(std::__1::shared_ptr<kudu::client::KuduClient>*) /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client.cc:351:3 (libkudu_client.so+0x197767)
> #8 kudu::cluster::InternalMiniCluster::CreateClient(kudu::client::KuduClientBuilder*, std::__1::shared_ptr<kudu::client::KuduClient>*) const /home/jenkins-slave/workspace/kudu-master/1/src/kudu/mini-cluster/internal_mini_cluster.cc:350:19 (libmini_cluster.so+0x75d76)
> #9 kudu::TestWorkload::Setup() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/test_workload.cc:290:5 (libitest_util.so+0xc3712)
> #10 kudu::itest::TServerQuiescingITest_TestDoesntAllowNewScansLeadersOnly_Test::TestBody() /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc:279:16 (tablet_server_quiescing-itest+0x4f9337)
> #11 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x54f9f)
> #12 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x54f9f)
> #13 testing::Test::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2474:5 (libgmock.so+0x33f38)
> #14 testing::TestInfo::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x351dc)
> #15 testing::TestCase::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x35ef6)
> #16 testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x423a6)
> #17 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x55e4f)
> #18 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438:14 (libgmock.so+0x55e4f)
> #19 testing::UnitTest::Run() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x41c61)
> #20 RUN_ALL_TESTS() /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x47bb)
> #21 main /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x3636)
That looks like KUDU-2059. Unrelated to this patch.
http://gerrit.cloudera.org:8080/#/c/15557/2/src/kudu/gutil/spinlock_linux-inl.h
File src/kudu/gutil/spinlock_linux-inl.h:
PS2:
> Updated all the files except linux_syscall_support.h, where it seemed bette
Nah, let's leave linux_syscall_support.h pristine, for the reasons you described.
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 22:59:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, zhaorenhai@hotmail.com, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15557
to look at the new patch set (#3).
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
gutil: bump up linux-syscall-support.h
Bump up linux-syscall-support.h to newest version
which support aarch64 - commit fd00dbb from
https://chromium.googlesource.com/linux-syscall-support/
This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).
Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
M src/kudu/util/notification.h
4 files changed, 1,749 insertions(+), 894 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15557/3
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Mar 2020 03:55:19 +0000
Gerrit-HasComments: No
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
gutil: bump up linux-syscall-support.h
Bump up linux-syscall-support.h to newest version
which support aarch64 - commit fd00dbb from
https://chromium.googlesource.com/linux-syscall-support/
This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).
Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Reviewed-on: http://gerrit.cloudera.org:8080/15557
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
M src/kudu/util/notification.h
4 files changed, 1,749 insertions(+), 894 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG@9
PS1, Line 9: linux-syscall-support.h
Could you add information on the original upstream source (if any) of the linux-syscall-suppor.h file?
http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc
File src/kudu/util/debug-util.cc:
http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc@166
PS1, Line 166:
nit: spacing -- using spaces instead of tabs for the indent
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 17:38:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] gutil: bump up linux-syscall-support.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 )
Change subject: gutil: bump up linux-syscall-support.h
......................................................................
Patch Set 1:
Please ignore for now, I'm going to look at the failures
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 17:00:30 +0000
Gerrit-HasComments: No