[GitHub] [unomi] jkevan commented on a diff in pull request #411: UNOMI-565 : add code coverage report

[GitBox <gi...@apache.org>]

jkevan commented on code in PR #411:
URL: https://github.com/apache/unomi/pull/411#discussion_r862827851


##########
itests/pom.xml:
##########
@@ -238,6 +280,49 @@
                             </execution>
                         </executions>
                     </plugin>
+                    <plugin>
+                        <artifactId>exec-maven-plugin</artifactId>
+                        <groupId>org.codehaus.mojo</groupId>
+                        <executions>
+                            <execution>
+                                <id>Generate code coverage report</id>
+                                <phase>verify</phase>
+                                <goals>
+                                    <goal>exec</goal>
+                                </goals>
+                                <configuration>
+                                    <executable>${basedir}/jacoco-report.sh</executable>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+        <profile>
+            <id>Jacoco code coverage report profile</id>

Review Comment:
   Strange format for a profile id, shouldn't be lower case and dash separated ?



##########
itests/pom.xml:
##########
@@ -151,13 +152,53 @@
     </dependencies>
 
     <profiles>
+
         <profile>
             <id>run-tests</id>
             <activation>
                 <activeByDefault>true</activeByDefault>
             </activation>
             <build>
                 <plugins>
+                    <plugin>
+                        <groupId>com.googlecode.maven-download-plugin</groupId>
+                        <artifactId>download-maven-plugin</artifactId>
+                        <version>1.3.0</version>
+                        <executions>
+                            <execution>
+                                <!-- the wget goal actually binds itself to this phase by default -->
+                                <phase>pre-integration-test</phase>
+                                <goals>
+                                    <goal>wget</goal>
+                                </goals>
+                                <configuration>
+                                    <url>
+                                        https://search.maven.org/remotecontent?filepath=org/jacoco/jacoco/0.8.8/jacoco-0.8.8.zip
+                                    </url>
+                                    <outputFileName>jacoco.zip</outputFileName>
+                                    <!-- default target location, just to demonstrate the parameter -->
+                                    <outputDirectory>${project.build.directory}/jacoco/</outputDirectory>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>

Review Comment:
   Using the jacoco maven plugin should provide better support to avoid such download operation that will block us when working offline.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org