You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/14 05:05:08 UTC
[GitHub] [airflow] houqp opened a new pull request #7416: [AIRFLOW-6802]
honor dag.max_active_run in scheduler
houqp opened a new pull request #7416: [AIRFLOW-6802] honor dag.max_active_run in scheduler
URL: https://github.com/apache/airflow/pull/7416
commit 50efda5c69c1ddfaa869b408540182fb19f1a286 introduced a bug that
prevents the scheduler from enforcing max active run config for all
DAGs.
this commit fixes the regression as well as the test.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb merged pull request #7416: [AIRFLOW-6802] honor
dag.max_active_run in scheduler
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #7416: [AIRFLOW-6802] honor dag.max_active_run in scheduler
URL: https://github.com/apache/airflow/pull/7416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7416: [AIRFLOW-6802] honor
dag.max_active_run in scheduler
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7416: [AIRFLOW-6802] honor dag.max_active_run in scheduler
URL: https://github.com/apache/airflow/pull/7416#issuecomment-586112833
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7416?src=pr&el=h1) Report
> Merging [#7416](https://codecov.io/gh/apache/airflow/pull/7416?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/967930c0cb6e2293f2a49e5c9add5aa1917f3527?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7416?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7416 +/- ##
==========================================
- Coverage 86.61% 86.33% -0.28%
==========================================
Files 873 874 +1
Lines 40757 40921 +164
==========================================
+ Hits 35300 35329 +29
- Misses 5457 5592 +135
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7416?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.65% <100%> (+0.3%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `65.38% <0%> (-6.36%)` | :arrow_down: |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `85.29% <0%> (-5.19%)` | :arrow_down: |
| [airflow/www/api/experimental/endpoints.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBpL2V4cGVyaW1lbnRhbC9lbmRwb2ludHMucHk=) | `89.81% <0%> (ø)` | :arrow_up: |
| [...low/providers/google/cloud/operators/sql\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9zcWxfdG9fZ2NzLnB5) | `92.07% <0%> (ø)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7416/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7416?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7416?src=pr&el=footer). Last update [967930c...d3b5cc3](https://codecov.io/gh/apache/airflow/pull/7416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services