[jira] [Commented] (OAK-4066) Suggestion dictionary don't update after suggestUpdateFrequencyMinutes unless something else causes index update

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171557#comment-15171557 ] 

Chetan Mehrotra commented on OAK-4066:
--------------------------------------

One problem would be how to avoid the second forced update. For example for following sequence

# T1 - Indexing happened in index IdxA
# T2 - Async index cycle trigger but no changes in IdxA. But T2-T1 > suggestUpdateFrequencyMinutes. We update dict but {{lastUpdated}} is still T1
# T3 - Still no change in IdxA. However {{shouldUpdateSuggestions}} says T3 - T1 > suggestUpdateFrequencyMinutes so update the dict. This would be redundant as there would be no change. 

And thus dict would start getting rebuild without any changes to IdxA. May be we should always update the {{lastUpdated}} time (wether forced or not) And in {{shouldUpdateSuggestions}} also make use of {{indexNodes}} count. If its 0 then no need to update

Couple of points
# You can drop the last if in {{closeWriter}}. Changes they do are fine even for forced update. Not much benefit on treating them differently
# Log a debug message if its forced update

> Suggestion dictionary don't update after suggestUpdateFrequencyMinutes unless something else causes index update
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-4066
>                 URL: https://issues.apache.org/jira/browse/OAK-4066
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.3.16
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Blocker
>             Fix For: 1.3.17
>
>         Attachments: OAK-4066.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)