You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "lindong28 (via GitHub)" <gi...@apache.org> on 2023/04/19 09:14:59 UTC

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #233: [FLINK-31373] Fix NPE thrown in ProxyOutput

lindong28 commented on code in PR #233:
URL: https://github.com/apache/flink-ml/pull/233#discussion_r1171058278


##########
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/allround/OneInputAllRoundWrapperOperator.java:
##########
@@ -87,7 +90,9 @@ public void setKeyContextElement(StreamRecord<IterationRecord<IN>> record) throw
     @Override
     public void endInput() throws Exception {
         if (wrappedOperator instanceof BoundedOneInput) {
+            setIterationContextRound(iterationContextRound);

Review Comment:
   Would it be simpler to do `setIterationContextRound(Integer.MAX_VALUE)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org