You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/04/13 12:07:04 UTC

[camel] 07/10: CAMEL-17763: cleaned up unused exceptions in camel-smpp

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 1f1a1ee082957b3160eb19e351dc9d79222a25a3
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Wed Apr 13 11:01:39 2022 +0200

    CAMEL-17763: cleaned up unused exceptions in camel-smpp
---
 .../camel/component/smpp/AbstractSmppCommandTest.java      |  2 +-
 .../org/apache/camel/component/smpp/SmppBindingTest.java   |  4 ++--
 .../org/apache/camel/component/smpp/SmppComponentTest.java |  4 ++--
 .../component/smpp/integration/SmppComponentManualIT.java  | 14 +++++++-------
 .../smpp/integration/SmppComponentSpringManualIT.java      | 10 +++++-----
 .../smpp/integration/SmppConsumerReconnectManualIT.java    |  4 ++--
 .../smpp/integration/SmppProducerReconnectManualIT.java    |  4 ++--
 7 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/AbstractSmppCommandTest.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/AbstractSmppCommandTest.java
index e8f852a67d5..00fe9fdc9c1 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/AbstractSmppCommandTest.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/AbstractSmppCommandTest.java
@@ -42,7 +42,7 @@ public class AbstractSmppCommandTest {
 
         command = new AbstractSmppCommand(session, config) {
             @Override
-            public void execute(Exchange exchange) throws SmppException {
+            public void execute(Exchange exchange) {
             }
         };
     }
diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppBindingTest.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppBindingTest.java
index c97052f8d1b..9aa6eace93f 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppBindingTest.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppBindingTest.java
@@ -199,7 +199,7 @@ public class SmppBindingTest {
     }
 
     @Test
-    public void createSmppMessageFromDeliveryReceiptWithoutShortMessageShouldNotThrowException() throws Exception {
+    public void createSmppMessageFromDeliveryReceiptWithoutShortMessageShouldNotThrowException() {
         DeliverSm deliverSm = new DeliverSm();
         deliverSm.setSmscDeliveryReceipt();
         deliverSm.setOptionalParameters(new OptionalParameter.Short((short) 0x2153, (short) 0));
@@ -280,7 +280,7 @@ public class SmppBindingTest {
     }
 
     @Test
-    public void createSmppMessageFromDataSmShouldReturnASmppMessage() throws Exception {
+    public void createSmppMessageFromDataSmShouldReturnASmppMessage() {
         DataSm dataSm = new DataSm();
         dataSm.setSequenceNumber(1);
         dataSm.setCommandId(1);
diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java
index bb6973beacc..7da536ce15e 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java
@@ -136,7 +136,7 @@ public class SmppComponentTest {
     }
 
     @Test
-    public void createEndpointSmppConfigurationShouldReturnASmppEndpoint() throws Exception {
+    public void createEndpointSmppConfigurationShouldReturnASmppEndpoint() {
         SmppConfiguration configuration = new SmppConfiguration();
         Endpoint endpoint = component.createEndpoint(configuration);
         SmppEndpoint smppEndpoint = (SmppEndpoint) endpoint;
@@ -152,7 +152,7 @@ public class SmppComponentTest {
     }
 
     @Test
-    public void createEndpointStringSmppConfigurationShouldReturnASmppEndpoint() throws Exception {
+    public void createEndpointStringSmppConfigurationShouldReturnASmppEndpoint() {
         SmppConfiguration configuration = new SmppConfiguration();
         Endpoint endpoint = component.createEndpoint("smpp://smppclient@localhost:2775?password=password", configuration);
         SmppEndpoint smppEndpoint = (SmppEndpoint) endpoint;
diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentManualIT.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentManualIT.java
index 7448eb93c90..97ba6a8e5a6 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentManualIT.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentManualIT.java
@@ -116,7 +116,7 @@ public class SmppComponentManualIT extends CamelTestSupport {
     }
 
     @Test
-    public void sendCancelSM() throws Exception {
+    public void sendCancelSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "CancelSm");
         exchange.getIn().setHeader(SmppConstants.ID, "1");
@@ -127,7 +127,7 @@ public class SmppComponentManualIT extends CamelTestSupport {
     }
 
     @Test
-    public void sendQuerySM() throws Exception {
+    public void sendQuerySM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "QuerySm");
         exchange.getIn().setHeader(SmppConstants.ID, "1");
@@ -141,7 +141,7 @@ public class SmppComponentManualIT extends CamelTestSupport {
     }
 
     @Test
-    public void sendReplaceSM() throws Exception {
+    public void sendReplaceSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "ReplaceSm");
         exchange.getIn().setBody("Hello Camel World!");
@@ -153,7 +153,7 @@ public class SmppComponentManualIT extends CamelTestSupport {
     }
 
     @Test
-    public void sendDataSM() throws Exception {
+    public void sendDataSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "DataSm");
 
@@ -163,7 +163,7 @@ public class SmppComponentManualIT extends CamelTestSupport {
     }
 
     @Test
-    public void sendSubmitMultiSM() throws Exception {
+    public void sendSubmitMultiSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "SubmitMulti");
         exchange.getIn().setBody("Hello SMPP World! Hello SMPP World! Hello SMPP World! Hello SMPP World! Hello SMPP World! "
@@ -177,10 +177,10 @@ public class SmppComponentManualIT extends CamelTestSupport {
     }
 
     @Override
-    protected RouteBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             @Override
-            public void configure() throws Exception {
+            public void configure() {
                 from("direct:start")
                         .to("smpp://smppclient@localhost:2775?password=password&enquireLinkTimer=3000&transactionTimer=5000&systemType=producer");
 
diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentSpringManualIT.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentSpringManualIT.java
index 93e903b382f..0c7bfdb6b65 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentSpringManualIT.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppComponentSpringManualIT.java
@@ -116,7 +116,7 @@ public class SmppComponentSpringManualIT extends CamelSpringTestSupport {
     }
 
     @Test
-    public void sendCancelSM() throws Exception {
+    public void sendCancelSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "CancelSm");
         exchange.getIn().setHeader(SmppConstants.ID, "1");
@@ -127,7 +127,7 @@ public class SmppComponentSpringManualIT extends CamelSpringTestSupport {
     }
 
     @Test
-    public void sendQuerySM() throws Exception {
+    public void sendQuerySM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "QuerySm");
         exchange.getIn().setHeader(SmppConstants.ID, "1");
@@ -141,7 +141,7 @@ public class SmppComponentSpringManualIT extends CamelSpringTestSupport {
     }
 
     @Test
-    public void sendReplaceSM() throws Exception {
+    public void sendReplaceSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "ReplaceSm");
         exchange.getIn().setBody("Hello Camel World!");
@@ -153,7 +153,7 @@ public class SmppComponentSpringManualIT extends CamelSpringTestSupport {
     }
 
     @Test
-    public void sendDataSM() throws Exception {
+    public void sendDataSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "DataSm");
 
@@ -163,7 +163,7 @@ public class SmppComponentSpringManualIT extends CamelSpringTestSupport {
     }
 
     @Test
-    public void sendSubmitMultiSM() throws Exception {
+    public void sendSubmitMultiSM() {
         Exchange exchange = start.createExchange(ExchangePattern.InOut);
         exchange.getIn().setHeader(SmppConstants.COMMAND, "SubmitMulti");
         exchange.getIn().setBody("Hello SMPP World! Hello SMPP World! Hello SMPP World! Hello SMPP World! Hello SMPP World! "
diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppConsumerReconnectManualIT.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppConsumerReconnectManualIT.java
index 4063ed3402a..7ee2bf3d770 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppConsumerReconnectManualIT.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppConsumerReconnectManualIT.java
@@ -39,10 +39,10 @@ public class SmppConsumerReconnectManualIT extends CamelTestSupport {
     }
 
     @Override
-    protected RouteBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             @Override
-            public void configure() throws Exception {
+            public void configure() {
                 from("smpp://smppclient@localhost:2775?password=password&enquireLinkTimer=3000&transactionTimer=5000&systemType=consumer")
                         .to("mock:result");
             }
diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppProducerReconnectManualIT.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppProducerReconnectManualIT.java
index 3f74b2c7182..8e088c3b8e6 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppProducerReconnectManualIT.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/integration/SmppProducerReconnectManualIT.java
@@ -39,10 +39,10 @@ public class SmppProducerReconnectManualIT extends CamelTestSupport {
     }
 
     @Override
-    protected RouteBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             @Override
-            public void configure() throws Exception {
+            public void configure() {
                 from("direct:start")
                         .to("smpp://smppclient@localhost:2775?password=password&enquireLinkTimer=3000&transactionTimer=5000&systemType=producerr");
             }