You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by ti...@apache.org on 2024/09/20 15:09:22 UTC
(incubator-kie-tools) branch main updated: kie-issues#980: On the DMN Editor it's not possible to use the Palette if the focus is on another element (#2598)
This is an automated email from the ASF dual-hosted git repository.
tiagobento pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
The following commit(s) were added to refs/heads/main by this push:
new e1a5c69dd25 kie-issues#980: On the DMN Editor it's not possible to use the Palette if the focus is on another element (#2598)
e1a5c69dd25 is described below
commit e1a5c69dd25e6b8f813001a2eda56f551a1e9b22
Author: Jozef Marko <Jo...@ibm.com>
AuthorDate: Fri Sep 20 17:09:18 2024 +0200
kie-issues#980: On the DMN Editor it's not possible to use the Palette if the focus is on another element (#2598)
---
packages/dmn-editor/src/diagram/Palette.tsx | 10 +++++-
.../add-2-group-nodes-from-palette.png | Bin 0 -> 38302 bytes
.../add-2-text-annotation-nodes-from-palette.png | Bin 0 -> 34419 bytes
.../drgElements/add-2-bkm-nodes-from-palette.png | Bin 0 -> 32745 bytes
.../add-2-decision-nodes-from-palette.png | Bin 0 -> 33071 bytes
.../add-2-decision-service-nodes-from-palette.png | Bin 0 -> 41156 bytes
.../add-2-input-data-nodes-from-palette.png | Bin 0 -> 38660 bytes
.../add-2-knowledge-source-nodes-from-palette.png | Bin 0 -> 39464 bytes
.../add-2-group-nodes-from-palette.png | Bin 0 -> 33946 bytes
.../add-2-text-annotation-nodes-from-palette.png | Bin 0 -> 30221 bytes
.../drgElements/add-2-bkm-nodes-from-palette.png | Bin 0 -> 28736 bytes
.../add-2-decision-nodes-from-palette.png | Bin 0 -> 28949 bytes
.../add-2-decision-service-nodes-from-palette.png | Bin 0 -> 36300 bytes
.../add-2-input-data-nodes-from-palette.png | Bin 0 -> 34086 bytes
.../add-2-knowledge-source-nodes-from-palette.png | Bin 0 -> 34677 bytes
.../add-2-group-nodes-from-palette.png | Bin 0 -> 35890 bytes
.../add-2-text-annotation-nodes-from-palette.png | Bin 0 -> 30647 bytes
.../drgElements/add-2-bkm-nodes-from-palette.png | Bin 0 -> 29819 bytes
.../add-2-decision-nodes-from-palette.png | Bin 0 -> 29516 bytes
.../add-2-decision-service-nodes-from-palette.png | Bin 0 -> 37386 bytes
.../add-2-input-data-nodes-from-palette.png | Bin 0 -> 35135 bytes
.../add-2-knowledge-source-nodes-from-palette.png | Bin 0 -> 35287 bytes
.../tests-e2e/drdArtifacts/addAssociation.spec.ts | 36 ++++++++++++-------
.../tests-e2e/drdArtifacts/addGroup.spec.ts | 23 +++++++++++-
.../drdArtifacts/addTextAnnotation.spec.ts | 40 +++++++++++++++++----
.../drdArtifacts/deleteAssociation.spec.ts | 8 +++--
.../tests-e2e/drgElements/addBkm.spec.ts | 32 ++++++++++++++---
.../tests-e2e/drgElements/addDecision.spec.ts | 35 ++++++++++++++----
.../drgElements/addDecisionService.spec.ts | 24 +++++++++++--
.../tests-e2e/drgElements/addInputData.spec.ts | 23 +++++++++++-
.../drgElements/addKnowledgeSource.spec.ts | 31 +++++++++++++---
.../addAuthorityRequirement.spec.ts | 14 +++++---
.../addInformationRequirement.spec.ts | 4 +--
.../addKnowledgeRequirement.spec.ts | 10 +++---
.../deleteAuthorityRequirement.spec.ts | 8 +++--
.../deleteInformationRequirement.spec.ts | 10 ++++--
.../deleteKnowledgeRequirement.spec.ts | 6 ++--
.../invalidAuthorityRequirement.spec.ts | 8 ++---
.../invalidInformationRequirement.spec.ts | 24 ++++++-------
.../invalidKnowledgeRequirement.spec.ts | 8 ++---
.../tests-e2e/readOnly/readOnlyDiagram.spec.ts | 10 +++---
41 files changed, 278 insertions(+), 86 deletions(-)
diff --git a/packages/dmn-editor/src/diagram/Palette.tsx b/packages/dmn-editor/src/diagram/Palette.tsx
index 64f74263bc9..05fe4938571 100644
--- a/packages/dmn-editor/src/diagram/Palette.tsx
+++ b/packages/dmn-editor/src/diagram/Palette.tsx
@@ -101,6 +101,10 @@ export function Palette({ pulse }: { pulse: boolean }) {
const { maxHeight } = useInViewSelect(dmnEditorRootElementRef, nodesPalletePopoverRef);
+ const clearCurrentFocusToAllowDraggingNewNode = useCallback(() => {
+ (document.activeElement as any)?.blur?.();
+ }, []);
+
return (
<>
<RF.Panel position={"top-left"}>
@@ -162,7 +166,11 @@ export function Palette({ pulse }: { pulse: boolean }) {
</aside>
</RF.Panel>
{!settings.isReadOnly && (
- <RF.Panel position={"top-left"} style={{ marginTop: "78px" }}>
+ <RF.Panel
+ position={"top-left"}
+ style={{ marginTop: "78px" }}
+ onMouseDownCapture={clearCurrentFocusToAllowDraggingNewNode}
+ >
<div ref={nodesPalletePopoverRef} style={{ position: "absolute", left: 0, height: 0, zIndex: -1 }} />
<aside className={`kie-dmn-editor--palette ${pulse ? "pulse" : ""}`}>
<div
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-2-group-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-2-group-nodes-from-palette.png
new file mode 100644
index 00000000000..2844450f1c0
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-2-group-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-2-text-annotation-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-2-text-annotation-nodes-from-palette.png
new file mode 100644
index 00000000000..a13b4256cd4
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-2-text-annotation-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-bkm-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-bkm-nodes-from-palette.png
new file mode 100644
index 00000000000..15dc1257003
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-bkm-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-decision-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-decision-nodes-from-palette.png
new file mode 100644
index 00000000000..7bc77f83007
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-decision-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-decision-service-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-decision-service-nodes-from-palette.png
new file mode 100644
index 00000000000..56d97ba1d8f
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-decision-service-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-input-data-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-input-data-nodes-from-palette.png
new file mode 100644
index 00000000000..7c60486d4cb
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-input-data-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-knowledge-source-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-knowledge-source-nodes-from-palette.png
new file mode 100644
index 00000000000..8e7c64ac210
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drgElements/add-2-knowledge-source-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-2-group-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-2-group-nodes-from-palette.png
new file mode 100644
index 00000000000..674a54b15d9
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-2-group-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-2-text-annotation-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-2-text-annotation-nodes-from-palette.png
new file mode 100644
index 00000000000..39e5cbdcc6a
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-2-text-annotation-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-bkm-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-bkm-nodes-from-palette.png
new file mode 100644
index 00000000000..3ec727001b1
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-bkm-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-decision-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-decision-nodes-from-palette.png
new file mode 100644
index 00000000000..ee01ebed0e2
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-decision-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-decision-service-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-decision-service-nodes-from-palette.png
new file mode 100644
index 00000000000..c12ef629154
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-decision-service-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-input-data-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-input-data-nodes-from-palette.png
new file mode 100644
index 00000000000..c41493698ee
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-input-data-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-knowledge-source-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-knowledge-source-nodes-from-palette.png
new file mode 100644
index 00000000000..02c2674b5ea
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drgElements/add-2-knowledge-source-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-2-group-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-2-group-nodes-from-palette.png
new file mode 100644
index 00000000000..def7abbfb6f
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-2-group-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-2-text-annotation-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-2-text-annotation-nodes-from-palette.png
new file mode 100644
index 00000000000..7582ea9f1b2
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-2-text-annotation-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-bkm-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-bkm-nodes-from-palette.png
new file mode 100644
index 00000000000..aa29db077e6
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-bkm-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-decision-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-decision-nodes-from-palette.png
new file mode 100644
index 00000000000..07077d605a0
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-decision-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-decision-service-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-decision-service-nodes-from-palette.png
new file mode 100644
index 00000000000..1546344def3
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-decision-service-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-input-data-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-input-data-nodes-from-palette.png
new file mode 100644
index 00000000000..02a7489f205
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-input-data-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-knowledge-source-nodes-from-palette.png b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-knowledge-source-nodes-from-palette.png
new file mode 100644
index 00000000000..ca0cca69386
Binary files /dev/null and b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drgElements/add-2-knowledge-source-nodes-from-palette.png differ
diff --git a/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts b/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts
index 1526752da8b..11e155d82a3 100644
--- a/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts
@@ -50,7 +50,7 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.BKM, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -70,7 +70,9 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: DefaultNodeName.DECISION, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.DECISION, to: DefaultNodeName.TEXT_ANNOTATION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -97,7 +99,7 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.KNOWLEDGE_SOURCE, to: DefaultNodeName.TEXT_ANNOTATION })
).toBeAttached();
expect(
@@ -121,7 +123,9 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -143,7 +147,7 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.TEXT_ANNOTATION })
).toBeAttached();
expect(
@@ -167,7 +171,9 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: DefaultNodeName.GROUP, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.GROUP, to: DefaultNodeName.TEXT_ANNOTATION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.GROUP, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -198,7 +204,7 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.BKM,
});
- expect(await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.BKM })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.BKM })).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.BKM })).toEqual(
EdgeType.ASSOCIATION
);
@@ -218,7 +224,9 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.DECISION,
});
- expect(await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.DECISION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.DECISION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -240,7 +248,7 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.KNOWLEDGE_SOURCE,
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.KNOWLEDGE_SOURCE })
).toBeAttached();
expect(
@@ -264,7 +272,9 @@ test.describe("Add edge - Association", () => {
to: DefaultNodeName.INPUT_DATA,
});
- expect(await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.INPUT_DATA })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.INPUT_DATA })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.INPUT_DATA })).toEqual(
EdgeType.ASSOCIATION
);
@@ -287,7 +297,7 @@ test.describe("Add edge - Association", () => {
position: NodePosition.TOP,
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.DECISION_SERVICE })
).toBeAttached();
expect(
@@ -316,7 +326,9 @@ test.describe("Add edge - Association", () => {
position: NodePosition.TOP,
});
- expect(await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.GROUP })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.GROUP })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.TEXT_ANNOTATION, to: DefaultNodeName.GROUP })).toEqual(
EdgeType.ASSOCIATION
);
diff --git a/packages/dmn-editor/tests-e2e/drdArtifacts/addGroup.spec.ts b/packages/dmn-editor/tests-e2e/drdArtifacts/addGroup.spec.ts
index 89affdae8af..144576f7c56 100644
--- a/packages/dmn-editor/tests-e2e/drdArtifacts/addGroup.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drdArtifacts/addGroup.spec.ts
@@ -17,6 +17,7 @@
* under the License.
*/
+import { TestAnnotations } from "@kie-tools/playwright-base/annotations";
import { test, expect } from "../__fixtures__/base";
import { DefaultNodeName, NodeType } from "../__fixtures__/nodes";
@@ -29,8 +30,28 @@ test.describe("Add node - Group", () => {
test("should add Group node from palette", async ({ palette, nodes, diagram }) => {
await palette.dragNewNode({ type: NodeType.GROUP, targetPosition: { x: 100, y: 100 } });
- expect(nodes.get({ name: DefaultNodeName.GROUP })).toBeAttached();
+ await expect(nodes.get({ name: DefaultNodeName.GROUP })).toBeAttached();
await expect(diagram.get()).toHaveScreenshot("add-group-node-from-palette.png");
});
+
+ test("should add multiple Group nodes from palette in a row", async ({ palette, nodes, diagram }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/980",
+ });
+
+ await palette.dragNewNode({ type: NodeType.GROUP, targetPosition: { x: 100, y: 100 } });
+ await palette.dragNewNode({
+ type: NodeType.GROUP,
+ targetPosition: { x: 300, y: 300 },
+ thenRenameTo: "Second Group",
+ });
+
+ await diagram.resetFocus();
+
+ await expect(nodes.get({ name: DefaultNodeName.GROUP })).toBeAttached();
+ await expect(nodes.get({ name: "Second Group" })).toBeAttached();
+ await expect(diagram.get()).toHaveScreenshot("add-2-group-nodes-from-palette.png");
+ });
});
});
diff --git a/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts b/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts
index 868ce7b91b2..e57db2e7d53 100644
--- a/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts
@@ -31,9 +31,29 @@ test.describe("Add node - Text Annotation", () => {
test("should add Text Annotation node from palette", async ({ palette, nodes, diagram }) => {
await palette.dragNewNode({ type: NodeType.TEXT_ANNOTATION, targetPosition: { x: 100, y: 100 } });
- expect(nodes.get({ name: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(nodes.get({ name: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
await expect(diagram.get()).toHaveScreenshot("add-text-annotation-node-from-palette.png");
});
+
+ test("should add two Text Annotation nodes from palette in a row", async ({ palette, nodes, diagram }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/980",
+ });
+
+ await palette.dragNewNode({ type: NodeType.TEXT_ANNOTATION, targetPosition: { x: 100, y: 100 } });
+ await palette.dragNewNode({
+ type: NodeType.TEXT_ANNOTATION,
+ targetPosition: { x: 300, y: 300 },
+ thenRenameTo: "Second Text Annotation",
+ });
+
+ await diagram.resetFocus();
+
+ await expect(nodes.get({ name: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(nodes.get({ name: "Second Text Annotation" })).toBeAttached();
+ await expect(diagram.get()).toHaveScreenshot("add-2-text-annotation-nodes-from-palette.png");
+ });
});
test.describe("add from nodes", () => {
@@ -53,7 +73,9 @@ test.describe("Add node - Text Annotation", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -71,7 +93,9 @@ test.describe("Add node - Text Annotation", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: DefaultNodeName.DECISION, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.DECISION, to: DefaultNodeName.TEXT_ANNOTATION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -89,7 +113,7 @@ test.describe("Add node - Text Annotation", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.BKM, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
@@ -112,7 +136,7 @@ test.describe("Add node - Text Annotation", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.TEXT_ANNOTATION })
).toBeAttached();
expect(
@@ -142,7 +166,7 @@ test.describe("Add node - Text Annotation", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.KNOWLEDGE_SOURCE, to: DefaultNodeName.TEXT_ANNOTATION })
).toBeAttached();
expect(
@@ -162,7 +186,9 @@ test.describe("Add node - Text Annotation", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(await edges.get({ from: DefaultNodeName.GROUP, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.GROUP, to: DefaultNodeName.TEXT_ANNOTATION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.GROUP, to: DefaultNodeName.TEXT_ANNOTATION })).toEqual(
EdgeType.ASSOCIATION
);
diff --git a/packages/dmn-editor/tests-e2e/drdArtifacts/deleteAssociation.spec.ts b/packages/dmn-editor/tests-e2e/drdArtifacts/deleteAssociation.spec.ts
index afa7f65e27e..9435015230e 100644
--- a/packages/dmn-editor/tests-e2e/drdArtifacts/deleteAssociation.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drdArtifacts/deleteAssociation.spec.ts
@@ -34,14 +34,16 @@ test.describe("Delete edge - Association", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })
+ ).toBeAttached();
});
test("should delete an Association using the delete key", async ({ diagram, edges, nodes }) => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION });
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })
).not.toBeAttached();
@@ -53,7 +55,7 @@ test.describe("Delete edge - Association", () => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION, isBackspace: true });
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.TEXT_ANNOTATION })
).not.toBeAttached();
diff --git a/packages/dmn-editor/tests-e2e/drgElements/addBkm.spec.ts b/packages/dmn-editor/tests-e2e/drgElements/addBkm.spec.ts
index 82f855262f0..8dd4e3e644e 100644
--- a/packages/dmn-editor/tests-e2e/drgElements/addBkm.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgElements/addBkm.spec.ts
@@ -17,6 +17,7 @@
* under the License.
*/
+import { TestAnnotations } from "@kie-tools/playwright-base/annotations";
import { test, expect } from "../__fixtures__/base";
import { EdgeType } from "../__fixtures__/edges";
import { DefaultNodeName, NodeType } from "../__fixtures__/nodes";
@@ -31,7 +32,7 @@ test.describe("Add node - BKM", () => {
test("should add new BKM node from palette", async ({ jsonModel, palette, nodes, diagram }) => {
await palette.dragNewNode({ type: NodeType.BKM, targetPosition: { x: 100, y: 100 } });
- expect(nodes.get({ name: DefaultNodeName.BKM })).toBeAttached();
+ await expect(nodes.get({ name: DefaultNodeName.BKM })).toBeAttached();
await expect(diagram.get()).toHaveScreenshot("add-bkm-node-from-palette.png");
// JSON model assertions
@@ -52,6 +53,25 @@ test.describe("Add node - BKM", () => {
"@_height": 80,
});
});
+
+ test("should add two new BKM nodes from palette in a row", async ({ palette, nodes, diagram }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/980",
+ });
+ await palette.dragNewNode({ type: NodeType.BKM, targetPosition: { x: 100, y: 100 } });
+ await palette.dragNewNode({
+ type: NodeType.BKM,
+ targetPosition: { x: 300, y: 300 },
+ thenRenameTo: "Second BKM",
+ });
+
+ await diagram.resetFocus();
+
+ await expect(nodes.get({ name: DefaultNodeName.BKM })).toBeAttached();
+ await expect(nodes.get({ name: "Second BKM" })).toBeAttached();
+ await expect(diagram.get()).toHaveScreenshot("add-2-bkm-nodes-from-palette.png");
+ });
});
test.describe("add from nodes", () => {
@@ -67,7 +87,7 @@ test.describe("Add node - BKM", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: "BKM - A", to: DefaultNodeName.BKM })).toBeAttached();
+ await expect(await edges.get({ from: "BKM - A", to: DefaultNodeName.BKM })).toBeAttached();
expect(await edges.getType({ from: "BKM - A", to: DefaultNodeName.BKM })).toEqual(
EdgeType.KNOWLEDGE_REQUIREMENT
);
@@ -85,7 +105,9 @@ test.describe("Add node - BKM", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.BKM })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.BKM })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.BKM })).toEqual(
EdgeType.KNOWLEDGE_REQUIREMENT
);
@@ -103,7 +125,9 @@ test.describe("Add node - BKM", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: DefaultNodeName.KNOWLEDGE_SOURCE, to: DefaultNodeName.BKM })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.KNOWLEDGE_SOURCE, to: DefaultNodeName.BKM })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.KNOWLEDGE_SOURCE, to: DefaultNodeName.BKM })).toEqual(
EdgeType.AUTHORITY_REQUIREMENT
);
diff --git a/packages/dmn-editor/tests-e2e/drgElements/addDecision.spec.ts b/packages/dmn-editor/tests-e2e/drgElements/addDecision.spec.ts
index 9134334c9cc..368fa7de1f0 100644
--- a/packages/dmn-editor/tests-e2e/drgElements/addDecision.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgElements/addDecision.spec.ts
@@ -17,6 +17,7 @@
* under the License.
*/
+import { TestAnnotations } from "@kie-tools/playwright-base/annotations";
import { test, expect } from "../__fixtures__/base";
import { EdgeType } from "../__fixtures__/edges";
import { DefaultNodeName, NodeType } from "../__fixtures__/nodes";
@@ -31,7 +32,7 @@ test.describe("Add node - Decision", () => {
test("should add Decision node from palette", async ({ jsonModel, palette, nodes, diagram }) => {
await palette.dragNewNode({ type: NodeType.DECISION, targetPosition: { x: 100, y: 100 } });
- expect(nodes.get({ name: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(nodes.get({ name: DefaultNodeName.DECISION })).toBeAttached();
await expect(diagram.get()).toHaveScreenshot("add-decision-node-from-palette.png");
// JSON model assertions
@@ -52,6 +53,26 @@ test.describe("Add node - Decision", () => {
"@_height": 80,
});
});
+
+ test("should add two Decision nodes from palette in a row", async ({ palette, nodes, diagram }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/980",
+ });
+
+ await palette.dragNewNode({ type: NodeType.DECISION, targetPosition: { x: 100, y: 100 } });
+ await palette.dragNewNode({
+ type: NodeType.DECISION,
+ targetPosition: { x: 300, y: 300 },
+ thenRenameTo: "Second Decision",
+ });
+
+ await diagram.resetFocus();
+
+ await expect(nodes.get({ name: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(nodes.get({ name: "Second Decision" })).toBeAttached();
+ await expect(diagram.get()).toHaveScreenshot("add-2-decision-nodes-from-palette.png");
+ });
});
test.describe("add from nodes", () => {
@@ -72,7 +93,9 @@ test.describe("Add node - Decision", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).toEqual(
EdgeType.INFORMATION_REQUIREMENT
);
@@ -121,7 +144,7 @@ test.describe("Add node - Decision", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: "Decision - A", to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: "Decision - A", to: DefaultNodeName.DECISION })).toBeAttached();
expect(await edges.getType({ from: "Decision - A", to: DefaultNodeName.DECISION })).toEqual(
EdgeType.INFORMATION_REQUIREMENT
);
@@ -139,7 +162,7 @@ test.describe("Add node - Decision", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).toEqual(
EdgeType.KNOWLEDGE_REQUIREMENT
);
@@ -162,7 +185,7 @@ test.describe("Add node - Decision", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.DECISION })
).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.DECISION })).toEqual(
@@ -187,7 +210,7 @@ test.describe("Add node - Decision", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.KNOWLEDGE_SOURCE, to: DefaultNodeName.DECISION })
).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.KNOWLEDGE_SOURCE, to: DefaultNodeName.DECISION })).toEqual(
diff --git a/packages/dmn-editor/tests-e2e/drgElements/addDecisionService.spec.ts b/packages/dmn-editor/tests-e2e/drgElements/addDecisionService.spec.ts
index b89385ce237..efbc781ad5e 100644
--- a/packages/dmn-editor/tests-e2e/drgElements/addDecisionService.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgElements/addDecisionService.spec.ts
@@ -17,6 +17,7 @@
* under the License.
*/
+import { TestAnnotations } from "@kie-tools/playwright-base/annotations";
import { test, expect } from "../__fixtures__/base";
import { DefaultNodeName, NodeType } from "../__fixtures__/nodes";
@@ -30,10 +31,9 @@ test.describe("Add node - Decision Service", () => {
test("should add Decision Service node from palette", async ({ jsonModel, palette, nodes, diagram }) => {
await palette.dragNewNode({ type: NodeType.DECISION_SERVICE, targetPosition: { x: 100, y: 100 } });
- expect(nodes.get({ name: DefaultNodeName.DECISION_SERVICE })).toBeAttached();
+ await expect(nodes.get({ name: DefaultNodeName.DECISION_SERVICE })).toBeAttached();
await expect(diagram.get()).toHaveScreenshot("add-decision-service-node-from-palette.png");
- // JSON model assertions
// JSON model assertions
const decisionService = await jsonModel.drgElements.getDecisionService({ drgElementIndex: 0, drdIndex: 0 });
expect(decisionService).toEqual({
@@ -54,6 +54,26 @@ test.describe("Add node - Decision Service", () => {
"@_height": 320,
});
});
+
+ test("should add two Decision Service nodes from palette in a row", async ({ palette, nodes, diagram }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/980",
+ });
+
+ await palette.dragNewNode({ type: NodeType.DECISION_SERVICE, targetPosition: { x: 100, y: 100 } });
+ await palette.dragNewNode({
+ type: NodeType.DECISION_SERVICE,
+ targetPosition: { x: 300, y: 300 },
+ thenRenameTo: "Second DS",
+ });
+
+ await diagram.resetFocus();
+
+ await expect(nodes.get({ name: DefaultNodeName.DECISION_SERVICE })).toBeAttached();
+ await expect(nodes.get({ name: "Second DS" })).toBeAttached();
+ await expect(diagram.get()).toHaveScreenshot("add-2-decision-service-nodes-from-palette.png");
+ });
});
});
});
diff --git a/packages/dmn-editor/tests-e2e/drgElements/addInputData.spec.ts b/packages/dmn-editor/tests-e2e/drgElements/addInputData.spec.ts
index e6204313cee..070ee925733 100644
--- a/packages/dmn-editor/tests-e2e/drgElements/addInputData.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgElements/addInputData.spec.ts
@@ -17,6 +17,7 @@
* under the License.
*/
+import { TestAnnotations } from "@kie-tools/playwright-base/annotations";
import { test, expect } from "../__fixtures__/base";
import { DefaultNodeName, NodeType } from "../__fixtures__/nodes";
@@ -30,7 +31,7 @@ test.describe("Add node - Input Data", () => {
test("should add Input Data node from palette", async ({ jsonModel, palette, nodes, diagram }) => {
await palette.dragNewNode({ type: NodeType.INPUT_DATA, targetPosition: { x: 100, y: 100 } });
- expect(nodes.get({ name: DefaultNodeName.INPUT_DATA })).toBeAttached();
+ await expect(nodes.get({ name: DefaultNodeName.INPUT_DATA })).toBeAttached();
await expect(diagram.get()).toHaveScreenshot("add-input-data-node-from-palette.png");
// JSON model assertions
@@ -51,6 +52,26 @@ test.describe("Add node - Input Data", () => {
"@_height": 80,
});
});
+
+ test("should add two Input Data nodes from palette in a row", async ({ palette, nodes, diagram }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/980",
+ });
+
+ await palette.dragNewNode({ type: NodeType.INPUT_DATA, targetPosition: { x: 100, y: 100 } });
+ await palette.dragNewNode({
+ type: NodeType.INPUT_DATA,
+ targetPosition: { x: 300, y: 300 },
+ thenRenameTo: "Second Input Data",
+ });
+
+ await diagram.resetFocus();
+
+ await expect(nodes.get({ name: DefaultNodeName.INPUT_DATA })).toBeAttached();
+ await expect(nodes.get({ name: "Second Input Data" })).toBeAttached();
+ await expect(diagram.get()).toHaveScreenshot("add-2-input-data-nodes-from-palette.png");
+ });
});
});
});
diff --git a/packages/dmn-editor/tests-e2e/drgElements/addKnowledgeSource.spec.ts b/packages/dmn-editor/tests-e2e/drgElements/addKnowledgeSource.spec.ts
index 28ef3c99185..434c8f3564b 100644
--- a/packages/dmn-editor/tests-e2e/drgElements/addKnowledgeSource.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgElements/addKnowledgeSource.spec.ts
@@ -17,6 +17,7 @@
* under the License.
*/
+import { TestAnnotations } from "@kie-tools/playwright-base/annotations";
import { test, expect } from "../__fixtures__/base";
import { EdgeType } from "../__fixtures__/edges";
import { DefaultNodeName, NodeType } from "../__fixtures__/nodes";
@@ -31,7 +32,7 @@ test.describe("Add node - Knowledge Source", () => {
test("should add Knowledge Source node from palette", async ({ jsonModel, palette, nodes, diagram }) => {
await palette.dragNewNode({ type: NodeType.KNOWLEDGE_SOURCE, targetPosition: { x: 100, y: 100 } });
- expect(nodes.get({ name: DefaultNodeName.KNOWLEDGE_SOURCE })).toBeAttached();
+ await expect(nodes.get({ name: DefaultNodeName.KNOWLEDGE_SOURCE })).toBeAttached();
await expect(diagram.get()).toHaveScreenshot("add-knowledge-source-node-from-palette.png");
// JSON model assertions
@@ -48,6 +49,26 @@ test.describe("Add node - Knowledge Source", () => {
"@_height": 80,
});
});
+
+ test("should add two Knowledge Source nodes from palette in a row", async ({ palette, nodes, diagram }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/980",
+ });
+
+ await palette.dragNewNode({ type: NodeType.KNOWLEDGE_SOURCE, targetPosition: { x: 100, y: 100 } });
+ await palette.dragNewNode({
+ type: NodeType.KNOWLEDGE_SOURCE,
+ targetPosition: { x: 300, y: 300 },
+ thenRenameTo: "Second Knowledge Source",
+ });
+
+ await diagram.resetFocus();
+
+ await expect(nodes.get({ name: DefaultNodeName.KNOWLEDGE_SOURCE })).toBeAttached();
+ await expect(nodes.get({ name: "Second Knowledge Source" })).toBeAttached();
+ await expect(diagram.get()).toHaveScreenshot("add-2-knowledge-source-nodes-from-palette.png");
+ });
});
test.describe("add from nodes", () => {
@@ -67,7 +88,7 @@ test.describe("Add node - Knowledge Source", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })
).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })).toEqual(
@@ -92,7 +113,7 @@ test.describe("Add node - Knowledge Source", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.DECISION, to: DefaultNodeName.KNOWLEDGE_SOURCE })
).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION, to: DefaultNodeName.KNOWLEDGE_SOURCE })).toEqual(
@@ -118,7 +139,9 @@ test.describe("Add node - Knowledge Source", () => {
targetPosition: { x: 500, y: 500 },
});
- expect(await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.KNOWLEDGE_SOURCE })).toBeAttached();
+ await expect(
+ await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.KNOWLEDGE_SOURCE })
+ ).toBeAttached();
expect(await edges.getType({ from: "Knowledge Source - A", to: DefaultNodeName.KNOWLEDGE_SOURCE })).toEqual(
EdgeType.AUTHORITY_REQUIREMENT
);
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/addAuthorityRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/addAuthorityRequirement.spec.ts
index 0ad8c7c0f99..cb70fffde39 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/addAuthorityRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/addAuthorityRequirement.spec.ts
@@ -55,7 +55,7 @@ test.describe("Add edge - Authority Requirement", () => {
to: DefaultNodeName.DECISION,
});
- expect(await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.DECISION })).toBeAttached();
expect(await edges.getType({ from: "Knowledge Source - A", to: DefaultNodeName.DECISION })).toEqual(
EdgeType.AUTHORITY_REQUIREMENT
);
@@ -78,7 +78,7 @@ test.describe("Add edge - Authority Requirement", () => {
to: DefaultNodeName.BKM,
});
- expect(await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.BKM })).toBeAttached();
+ await expect(await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.BKM })).toBeAttached();
expect(await edges.getType({ from: "Knowledge Source - A", to: DefaultNodeName.BKM })).toEqual(
EdgeType.AUTHORITY_REQUIREMENT
);
@@ -104,7 +104,9 @@ test.describe("Add edge - Authority Requirement", () => {
to: DefaultNodeName.KNOWLEDGE_SOURCE,
});
- expect(await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.KNOWLEDGE_SOURCE })).toBeAttached();
+ await expect(
+ await edges.get({ from: "Knowledge Source - A", to: DefaultNodeName.KNOWLEDGE_SOURCE })
+ ).toBeAttached();
expect(await edges.getType({ from: "Knowledge Source - A", to: DefaultNodeName.KNOWLEDGE_SOURCE })).toEqual(
EdgeType.AUTHORITY_REQUIREMENT
);
@@ -140,7 +142,9 @@ test.describe("Add edge - Authority Requirement", () => {
to: DefaultNodeName.KNOWLEDGE_SOURCE,
});
- expect(await edges.get({ from: DefaultNodeName.DECISION, to: DefaultNodeName.KNOWLEDGE_SOURCE })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.DECISION, to: DefaultNodeName.KNOWLEDGE_SOURCE })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION, to: DefaultNodeName.KNOWLEDGE_SOURCE })).toEqual(
EdgeType.AUTHORITY_REQUIREMENT
);
@@ -166,7 +170,7 @@ test.describe("Add edge - Authority Requirement", () => {
to: DefaultNodeName.KNOWLEDGE_SOURCE,
});
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })
).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })).toEqual(
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/addInformationRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/addInformationRequirement.spec.ts
index 412ab8960cc..1e28fd5d1e1 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/addInformationRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/addInformationRequirement.spec.ts
@@ -52,7 +52,7 @@ test.describe("Add edge - Information Requirement", () => {
to: DefaultNodeName.DECISION,
});
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).toEqual(
EdgeType.INFORMATION_REQUIREMENT
);
@@ -88,7 +88,7 @@ test.describe("Add edge - Information Requirement", () => {
to: DefaultNodeName.DECISION,
});
- expect(await edges.get({ from: "Decision - A", to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: "Decision - A", to: DefaultNodeName.DECISION })).toBeAttached();
expect(await edges.getType({ from: "Decision - A", to: DefaultNodeName.DECISION })).toEqual(
EdgeType.INFORMATION_REQUIREMENT
);
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/addKnowledgeRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/addKnowledgeRequirement.spec.ts
index a9058f4d89b..a7e41d5a9a8 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/addKnowledgeRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/addKnowledgeRequirement.spec.ts
@@ -51,7 +51,7 @@ test.describe("Add edge - Knowledge Requirement", () => {
to: DefaultNodeName.DECISION,
});
- expect(await edges.get({ from: "BKM - A", to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: "BKM - A", to: DefaultNodeName.DECISION })).toBeAttached();
expect(await edges.getType({ from: "BKM - A", to: DefaultNodeName.DECISION })).toEqual(
EdgeType.KNOWLEDGE_REQUIREMENT
);
@@ -71,7 +71,7 @@ test.describe("Add edge - Knowledge Requirement", () => {
to: DefaultNodeName.BKM,
});
- expect(await edges.get({ from: "BKM - A", to: DefaultNodeName.BKM })).toBeAttached();
+ await expect(await edges.get({ from: "BKM - A", to: DefaultNodeName.BKM })).toBeAttached();
expect(await edges.getType({ from: "BKM - A", to: DefaultNodeName.BKM })).toEqual(EdgeType.KNOWLEDGE_REQUIREMENT);
await expect(diagram.get()).toHaveScreenshot("add-knowledge-requirement-edge-from-bkm-node-to-bkm-node.png");
});
@@ -100,7 +100,9 @@ test.describe("Add edge - Knowledge Requirement", () => {
to: DefaultNodeName.DECISION,
});
- expect(await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.DECISION })
+ ).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.DECISION })).toEqual(
EdgeType.KNOWLEDGE_REQUIREMENT
);
@@ -122,7 +124,7 @@ test.describe("Add edge - Knowledge Requirement", () => {
to: DefaultNodeName.BKM,
});
- expect(await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.BKM })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.BKM })).toBeAttached();
expect(await edges.getType({ from: DefaultNodeName.DECISION_SERVICE, to: DefaultNodeName.BKM })).toEqual(
EdgeType.KNOWLEDGE_REQUIREMENT
);
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/deleteAuthorityRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/deleteAuthorityRequirement.spec.ts
index 29c68a705ea..30af9d7ff1f 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/deleteAuthorityRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/deleteAuthorityRequirement.spec.ts
@@ -34,14 +34,16 @@ test.describe("Delete edge - Authority Requirement", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })).toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })
+ ).toBeAttached();
});
test("should delete an Authority Requirement using the delete key", async ({ diagram, edges, nodes }) => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE });
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })
).not.toBeAttached();
@@ -53,7 +55,7 @@ test.describe("Delete edge - Authority Requirement", () => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE, isBackspace: true });
- expect(
+ await expect(
await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.KNOWLEDGE_SOURCE })
).not.toBeAttached();
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/deleteInformationRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/deleteInformationRequirement.spec.ts
index f7603a27ced..87773a0b304 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/deleteInformationRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/deleteInformationRequirement.spec.ts
@@ -34,14 +34,16 @@ test.describe("Delete edge - Information Requirement", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).toBeAttached();
});
test("should delete an Information Requirement using the delete key", async ({ diagram, edges, nodes }) => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION });
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).not.toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })
+ ).not.toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.INPUT_DATA })).toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.DECISION })).toBeAttached();
@@ -51,7 +53,9 @@ test.describe("Delete edge - Information Requirement", () => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION, isBackspace: true });
- expect(await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })).not.toBeAttached();
+ await expect(
+ await edges.get({ from: DefaultNodeName.INPUT_DATA, to: DefaultNodeName.DECISION })
+ ).not.toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.INPUT_DATA })).toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.DECISION })).toBeAttached();
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/deleteKnowledgeRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/deleteKnowledgeRequirement.spec.ts
index fc00cd79216..8a92187ac1a 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/deleteKnowledgeRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/deleteKnowledgeRequirement.spec.ts
@@ -34,14 +34,14 @@ test.describe("Delete edge - Knowledge Requirement", () => {
targetPosition: { x: 100, y: 300 },
});
- expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).toBeAttached();
});
test("should delete a Knowledge Requirement using the delete key", async ({ diagram, edges, nodes }) => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION });
- expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).not.toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).not.toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.BKM })).toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.DECISION })).toBeAttached();
@@ -51,7 +51,7 @@ test.describe("Delete edge - Knowledge Requirement", () => {
await diagram.resetFocus();
await edges.delete({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION, isBackspace: true });
- expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).not.toBeAttached();
+ await expect(await edges.get({ from: DefaultNodeName.BKM, to: DefaultNodeName.DECISION })).not.toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.BKM })).toBeAttached();
await expect(nodes.get({ name: DefaultNodeName.DECISION })).toBeAttached();
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/invalidAuthorityRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/invalidAuthorityRequirement.spec.ts
index 8d4205ab017..b5ba8935a31 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/invalidAuthorityRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/invalidAuthorityRequirement.spec.ts
@@ -51,7 +51,7 @@ test.describe("Invalid edge - Authority Requirement", () => {
to: DefaultNodeName.INPUT_DATA,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
});
test("should dim the target Input Data node", async ({ palette, nodes }) => {
@@ -94,7 +94,7 @@ test.describe("Invalid edge - Authority Requirement", () => {
position: NodePosition.TOP,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.DECISION_SERVICE })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.DECISION_SERVICE })).not.toBeAttached();
});
test("should dim the target Decision Service node", async ({ palette, nodes }) => {
@@ -125,7 +125,7 @@ test.describe("Invalid edge - Authority Requirement", () => {
position: NodePosition.TOP,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
});
test("should dim the target Group node", async ({ palette, nodes }) => {
@@ -155,7 +155,7 @@ test.describe("Invalid edge - Authority Requirement", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
});
test("should dim the target Text Annotation node", async ({ palette, nodes }) => {
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/invalidInformationRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/invalidInformationRequirement.spec.ts
index 147faf2ce32..9d8f3032b8a 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/invalidInformationRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/invalidInformationRequirement.spec.ts
@@ -51,7 +51,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.INPUT_DATA,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
});
test("should dim the target Input Data node", async ({ palette, nodes }) => {
@@ -93,7 +93,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.BKM,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.BKM })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.BKM })).not.toBeAttached();
});
test("should dim the target BKM node", async ({ palette, nodes }) => {
@@ -123,7 +123,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.DECISION_SERVICE,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.DECISION_SERVICE })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.DECISION_SERVICE })).not.toBeAttached();
});
test("should dim the target Decision Service node", async ({ palette, nodes }) => {
@@ -153,7 +153,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.KNOWLEDGE_SOURCE,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.KNOWLEDGE_SOURCE })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.KNOWLEDGE_SOURCE })).not.toBeAttached();
});
test("should dim the target Knowledge Source node", async ({ palette, nodes }) => {
@@ -184,7 +184,7 @@ test.describe("Invalid edge - Information Requirement", () => {
position: NodePosition.TOP,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
});
test("should dim the target Group node", async ({ palette, nodes }) => {
@@ -214,7 +214,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
});
test("should dim the target Text Annotation node", async ({ palette, nodes }) => {
@@ -254,7 +254,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.INPUT_DATA,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
});
test("shouldn't add an Information Requirement edge from Decision node to BKM node", async ({
@@ -273,7 +273,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.BKM,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.BKM })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.BKM })).not.toBeAttached();
});
test("shouldn't add an Information Requirement edge from Decision node to Decision Service node", async ({
@@ -292,7 +292,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.DECISION_SERVICE,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.DECISION_SERVICE })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.DECISION_SERVICE })).not.toBeAttached();
});
test("shouldn't add an Information Requirement edge from Decision node to Knowledge Source node", async ({
@@ -311,7 +311,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.KNOWLEDGE_SOURCE,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.KNOWLEDGE_SOURCE })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.KNOWLEDGE_SOURCE })).not.toBeAttached();
});
test("shouldn't add an Information Requirement edge from Decision node to Group node", async ({
@@ -331,7 +331,7 @@ test.describe("Invalid edge - Information Requirement", () => {
position: NodePosition.TOP,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
});
test("shouldn't add an Information Requirement edge from Decision node to Text Annotation node", async ({
@@ -350,7 +350,7 @@ test.describe("Invalid edge - Information Requirement", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
});
});
});
diff --git a/packages/dmn-editor/tests-e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts b/packages/dmn-editor/tests-e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts
index bb331d11390..171959aa120 100644
--- a/packages/dmn-editor/tests-e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts
@@ -51,7 +51,7 @@ test.describe("Invalid edge - Knowledge Requirement", () => {
to: DefaultNodeName.INPUT_DATA,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.INPUT_DATA })).not.toBeAttached();
});
test("should dim the target Input Data node", async ({ palette, nodes }) => {
@@ -93,7 +93,7 @@ test.describe("Invalid edge - Knowledge Requirement", () => {
to: DefaultNodeName.KNOWLEDGE_SOURCE,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.KNOWLEDGE_SOURCE })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.KNOWLEDGE_SOURCE })).not.toBeAttached();
});
test("should dim the target Knowledge Source node", async ({ palette, nodes }) => {
@@ -124,7 +124,7 @@ test.describe("Invalid edge - Knowledge Requirement", () => {
position: NodePosition.TOP,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.GROUP })).not.toBeAttached();
});
test("should dim the target Group node", async ({ palette, nodes }) => {
@@ -154,7 +154,7 @@ test.describe("Invalid edge - Knowledge Requirement", () => {
to: DefaultNodeName.TEXT_ANNOTATION,
});
- expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
+ await expect(await edges.get({ from: "Source Node", to: DefaultNodeName.TEXT_ANNOTATION })).not.toBeAttached();
});
test("should dim the target Text Annotation node", async ({ palette, nodes }) => {
diff --git a/packages/dmn-editor/tests-e2e/readOnly/readOnlyDiagram.spec.ts b/packages/dmn-editor/tests-e2e/readOnly/readOnlyDiagram.spec.ts
index c5793cd4e93..53549d4c492 100644
--- a/packages/dmn-editor/tests-e2e/readOnly/readOnlyDiagram.spec.ts
+++ b/packages/dmn-editor/tests-e2e/readOnly/readOnlyDiagram.spec.ts
@@ -31,12 +31,12 @@ test.describe("Read Only mode - Diagram", () => {
});
test("should not be able to rename node", async ({ nodes }) => {
await nodes.selectLabel({ name: "Loan Pre-Qualification" });
- await expect(await nodes.get({ name: "Loan Pre-Qualification" }).getByRole("textbox").nth(0)).toBeDisabled();
+ await expect(nodes.get({ name: "Loan Pre-Qualification" }).getByRole("textbox").nth(0)).toBeDisabled();
});
test("should not be able to change node type", async ({ nodes }) => {
await nodes.hover({ name: "Loan Pre-Qualification" });
await expect(
- await nodes.get({ name: "Loan Pre-Qualification" }).getByPlaceholder("Select a data type...")
+ nodes.get({ name: "Loan Pre-Qualification" }).getByPlaceholder("Select a data type...")
).toBeDisabled();
});
test("should not be able to drag node", async ({ page, nodes }) => {
@@ -45,8 +45,8 @@ test.describe("Read Only mode - Diagram", () => {
});
test("should not be able to edit node", async ({ nodes }) => {
await nodes.get({ name: "Loan Pre-Qualification" }).hover();
- expect(await nodes.get({ name: "Loan Pre-Qualification" }).getByText("Edit")).not.toBeAttached();
- expect(await nodes.get({ name: "Loan Pre-Qualification" }).getByText("View")).toBeAttached();
+ await expect(nodes.get({ name: "Loan Pre-Qualification" }).getByText("Edit")).not.toBeAttached();
+ await expect(nodes.get({ name: "Loan Pre-Qualification" }).getByText("View")).toBeAttached();
});
test("should not be able to add edges", async ({ page, nodes }) => {
await nodes.get({ name: "Loan Pre-Qualification" }).hover();
@@ -54,6 +54,6 @@ test.describe("Read Only mode - Diagram", () => {
});
test("should not be able to delete nodes", async ({ nodes }) => {
await nodes.delete({ name: "Loan Pre-Qualification" });
- await expect(await nodes.get({ name: "Loan Pre-Qualification" })).toBeAttached();
+ await expect(nodes.get({ name: "Loan Pre-Qualification" })).toBeAttached();
});
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org