You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/10/18 03:49:11 UTC
Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
-The slave now stores completed frameworks, executors, and tasks in memory.
-They are also exported via the state JSON endpoint.
-The webui has been updated accordingly.
This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
Diffs
-----
src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
Diff: https://reviews.apache.org/r/7642/diff/
Testing
-------
OSX + CentOS: make check
local run with long-lived-framework
Thanks,
Ben Mahler
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 19, 2012, 6:13 p.m., Vinod Kone wrote:
> > src/messages/messages.proto, line 39
> > <https://reviews.apache.org/r/7642/diff/1/?file=177782#file177782line39>
> >
> > s/itself//
done
> On Oct. 19, 2012, 6:13 p.m., Vinod Kone wrote:
> > src/slave/constants.hpp, lines 34-41
> > <https://reviews.apache.org/r/7642/diff/1/?file=177783#file177783line34>
> >
> > these numbers dont match the ones in master. why the discrepancy?
Well the contants are semantically different. I did just bump these down after some memory use estimations.
Feel free to suggest other values, I would like ones that fit for many mesos use cases while not consuming too much memory.
> On Oct. 19, 2012, 6:13 p.m., Vinod Kone wrote:
> > src/webui/master/static/controllers.js, lines 472-476
> > <https://reviews.apache.org/r/7642/diff/1/?file=177788#file177788line472>
> >
> > how can a completed framework have un-completed executors?
It cannot, but let's keep the symmetry.
> On Oct. 19, 2012, 6:13 p.m., Vinod Kone wrote:
> > src/slave/http.cpp, lines 241-243
> > <https://reviews.apache.org/r/7642/diff/1/?file=177784#file177784line241>
> >
> > sounds like boost::circular_buffer is perfect fit here and in master. not sure if we already pull it, but its a useful data structure to have in our arsenal.
So as discussed, not using circular_buffer as it requires assignment operators to be defined, which means we can't have const members.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12614
-----------------------------------------------------------
On Oct. 18, 2012, 1:49 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 1:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 19, 2012, 6:13 p.m., Vinod Kone wrote:
> > src/webui/master/static/controllers.js, lines 472-476
> > <https://reviews.apache.org/r/7642/diff/1/?file=177788#file177788line472>
> >
> > how can a completed framework have un-completed executors?
>
> Ben Mahler wrote:
> It cannot, but let's keep the symmetry.
I disagree. I would rather you do a check here that there are no un-completed executors.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12614
-----------------------------------------------------------
On Oct. 25, 2012, 1:08 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2012, 1:08 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> This addresses bug MESOS-263.
> https://issues.apache.org/jira/browse/MESOS-263
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 19, 2012, 6:13 p.m., Vinod Kone wrote:
> > src/webui/master/static/controllers.js, lines 472-476
> > <https://reviews.apache.org/r/7642/diff/1/?file=177788#file177788line472>
> >
> > how can a completed framework have un-completed executors?
>
> Ben Mahler wrote:
> It cannot, but let's keep the symmetry.
>
> Vinod Kone wrote:
> I disagree. I would rather you do a check here that there are no un-completed executors.
Breaking the symmetry means special casing the webui, in particular the completed framework html.
Right now it's just one html page, regardless of whether the framework is completed or not.
What did you want the check to do?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12614
-----------------------------------------------------------
On Oct. 25, 2012, 1:08 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2012, 1:08 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> This addresses bug MESOS-263.
> https://issues.apache.org/jira/browse/MESOS-263
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12614
-----------------------------------------------------------
src/master/master.hpp
<https://reviews.apache.org/r/7642/#comment26915>
+1
src/messages/messages.proto
<https://reviews.apache.org/r/7642/#comment26916>
s/itself//
src/slave/constants.hpp
<https://reviews.apache.org/r/7642/#comment26917>
these numbers dont match the ones in master. why the discrepancy?
src/slave/http.cpp
<https://reviews.apache.org/r/7642/#comment26919>
you can pull this out into a helper too, like you did for completed tasks.
src/slave/http.cpp
<https://reviews.apache.org/r/7642/#comment26921>
sounds like boost::circular_buffer is perfect fit here and in master. not sure if we already pull it, but its a useful data structure to have in our arsenal.
src/slave/http.cpp
<https://reviews.apache.org/r/7642/#comment26922>
ditto
src/slave/slave.hpp
<https://reviews.apache.org/r/7642/#comment26923>
ditto
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/7642/#comment26924>
how can a completed framework have un-completed executors?
- Vinod Kone
On Oct. 18, 2012, 1:49 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 1:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 18, 2012, 6:52 p.m., Benjamin Hindman wrote:
> > src/slave/slave.hpp, line 306
> > <https://reviews.apache.org/r/7642/diff/1/?file=177785#file177785line306>
> >
> > The problem is that a run id can be reused. So, over the course of some framework, it can have an executor with run 0 and uuid == 'aa' and later run 0 and uuid == 'bb' because the initial run directory got cleaned up. This is making me think that the correct strategy is to ditch run numbers all together and look up executors with these uuids. In fact, given this review, I'm pretty sure if an executor with id say 'default' were to die, and another one came up in it's place we would not be able to get to the sandbox of 'default/runs/0' but only 'default/runs/1' (that is, we won't actually be able to see old runs!). This is going to be the common case, so we definitely need to handle it.
Sent out the uuid change in a separate review.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12578
-----------------------------------------------------------
On Oct. 18, 2012, 1:49 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 1:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 18, 2012, 6:52 p.m., Benjamin Hindman wrote:
> >
Alright, as discussed over chat, I'll be sending out a CL to change our run directories to be based on the executor UUID. The master will not know the UUIDs in the first version. I'll then either update this CL separately, or discard this and re-publish the webui portion.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12578
-----------------------------------------------------------
On Oct. 18, 2012, 1:49 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 1:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12578
-----------------------------------------------------------
src/master/master.hpp
<https://reviews.apache.org/r/7642/#comment26848>
Or more simply: Information about a connected or completed framework.
src/messages/messages.proto
<https://reviews.apache.org/r/7642/#comment26849>
See comment below about executor run.
src/slave/slave.hpp
<https://reviews.apache.org/r/7642/#comment26850>
The problem is that a run id can be reused. So, over the course of some framework, it can have an executor with run 0 and uuid == 'aa' and later run 0 and uuid == 'bb' because the initial run directory got cleaned up. This is making me think that the correct strategy is to ditch run numbers all together and look up executors with these uuids. In fact, given this review, I'm pretty sure if an executor with id say 'default' were to die, and another one came up in it's place we would not be able to get to the sandbox of 'default/runs/0' but only 'default/runs/1' (that is, we won't actually be able to see old runs!). This is going to be the common case, so we definitely need to handle it.
- Benjamin Hindman
On Oct. 18, 2012, 1:49 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 1:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 24, 2012, 11:23 p.m., Benjamin Hindman wrote:
> > Just one high-level question: what happens when the webui GC's a directory. How does Files handle that, and what will you see in the webui? (Related, do we ever remove things from Files when the gc runs?)
No action is taken by Files.
This means that the webui simply will show an error browsing this directory, since the directory doesn't exist.
Removing things that get gc'ed is a little tricky, since we don't know the virtual name of the path at that point. Are you concerned about that?
> On Oct. 24, 2012, 11:23 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/slave_executor.html, line 26
> > <https://reviews.apache.org/r/7642/diff/2/?file=178831#file178831line26>
> >
> > What happened here?
Sorry about that, eclipse sometimes converts those unicode x's to that garbage.
> On Oct. 24, 2012, 11:23 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/controllers.js, lines 542-544
> > <https://reviews.apache.org/r/7642/diff/2/?file=178826#file178826line542>
> >
> > I know you don't want me to say it, but the reuse of the SlaveCtrl does appear to be coming to a point where it's very very difficult to grep what's going on. Maybe not for this review, but it's probably time for a FrameworkCtrl and an ExecutorCtrl.
Agreed, this got unwieldy, but since it's O(size(update() of HomeCtrl)) I'll punt with a TODO.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12733
-----------------------------------------------------------
On Oct. 25, 2012, 1:08 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2012, 1:08 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> This addresses bug MESOS-263.
> https://issues.apache.org/jira/browse/MESOS-263
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/#review12733
-----------------------------------------------------------
Ship it!
Just one high-level question: what happens when the webui GC's a directory. How does Files handle that, and what will you see in the webui? (Related, do we ever remove things from Files when the gc runs?)
src/slave/slave.hpp
<https://reviews.apache.org/r/7642/#comment27147>
I think you can kill this comment now. ;)
src/webui/master/static/browse.html
<https://reviews.apache.org/r/7642/#comment27148>
s/+1/ + 1/
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/7642/#comment27149>
I know you don't want me to say it, but the reuse of the SlaveCtrl does appear to be coming to a point where it's very very difficult to grep what's going on. Maybe not for this review, but it's probably time for a FrameworkCtrl and an ExecutorCtrl.
src/webui/master/static/slave_executor.html
<https://reviews.apache.org/r/7642/#comment27150>
What happened here?
src/webui/master/static/slave_framework.html
<https://reviews.apache.org/r/7642/#comment27151>
Also here.
- Benjamin Hindman
On Oct. 23, 2012, 7:40 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7642/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2012, 7:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> -The slave now stores completed frameworks, executors, and tasks in memory.
> -They are also exported via the state JSON endpoint.
> -The webui has been updated accordingly.
>
> This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
>
> Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
>
>
> This addresses bug MESOS-263.
> https://issues.apache.org/jira/browse/MESOS-263
>
>
> Diffs
> -----
>
> src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
> src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
> src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
> src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
> src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
> src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
> src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
> src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
> src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
> src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
> src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
> src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
> src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
> src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
> src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
> src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
> src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
>
> Diff: https://reviews.apache.org/r/7642/diff/
>
>
> Testing
> -------
>
> OSX + CentOS: make check
> local run with long-lived-framework
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/
-----------------------------------------------------------
(Updated Oct. 26, 2012, 12:13 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Now attaching paths as the absolute path. This simplifies things! Thanks vinod.
Description
-------
-The slave now stores completed frameworks, executors, and tasks in memory.
-They are also exported via the state JSON endpoint.
-The webui has been updated accordingly.
This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
This addresses bug MESOS-263.
https://issues.apache.org/jira/browse/MESOS-263
Diffs (updated)
-----
src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
Diff: https://reviews.apache.org/r/7642/diff/
Testing
-------
OSX + CentOS: make check
local run with long-lived-framework
Thanks,
Ben Mahler
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/
-----------------------------------------------------------
(Updated Oct. 25, 2012, 1:08 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Review chain update.
Description
-------
-The slave now stores completed frameworks, executors, and tasks in memory.
-They are also exported via the state JSON endpoint.
-The webui has been updated accordingly.
This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
This addresses bug MESOS-263.
https://issues.apache.org/jira/browse/MESOS-263
Diffs (updated)
-----
src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
Diff: https://reviews.apache.org/r/7642/diff/
Testing
-------
OSX + CentOS: make check
local run with long-lived-framework
Thanks,
Ben Mahler
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/
-----------------------------------------------------------
(Updated Oct. 25, 2012, 12:49 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated from benh review.
Description
-------
-The slave now stores completed frameworks, executors, and tasks in memory.
-They are also exported via the state JSON endpoint.
-The webui has been updated accordingly.
This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
This addresses bug MESOS-263.
https://issues.apache.org/jira/browse/MESOS-263
Diffs (updated)
-----
src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
Diff: https://reviews.apache.org/r/7642/diff/
Testing
-------
OSX + CentOS: make check
local run with long-lived-framework
Thanks,
Ben Mahler
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/
-----------------------------------------------------------
(Updated Oct. 23, 2012, 7:40 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Added bug ID.
Description
-------
-The slave now stores completed frameworks, executors, and tasks in memory.
-They are also exported via the state JSON endpoint.
-The webui has been updated accordingly.
This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
This addresses bug MESOS-263.
https://issues.apache.org/jira/browse/MESOS-263
Diffs
-----
src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
Diff: https://reviews.apache.org/r/7642/diff/
Testing
-------
OSX + CentOS: make check
local run with long-lived-framework
Thanks,
Ben Mahler
Re: Review Request: Exposing completed frameworks, executors, tasks,
and their sandboxes, in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7642/
-----------------------------------------------------------
(Updated Oct. 22, 2012, 10:57 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
This is now based on my executor uuid change.
Updated with trunk and retested briefly.
Description
-------
-The slave now stores completed frameworks, executors, and tasks in memory.
-They are also exported via the state JSON endpoint.
-The webui has been updated accordingly.
This is branched off of vinod's change here: https://reviews.apache.org/r/7638/
Note that the JSON response sizes grow significantly due to this change, I'll be following up with a change to pull in zlib and compress our HTTP Responses.
Diffs (updated)
-----
src/master/constants.hpp 4372f4d9d40b21701feae83ab56dc18afa735899
src/master/http.cpp 9254859a0d4fddf775fd38d0482b4622dc767ab3
src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f
src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868
src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e
src/slave/constants.hpp 4e28d30ebe3490f555a6dd43da9c6c1374ea4883
src/slave/http.cpp d413c3c1bd9b6772d5ebf23fa8ae1bd5ae3870bb
src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177
src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c
src/webui/master/static/browse.html e7e09a28ca9893ba049af100a257631d427ebfa1
src/webui/master/static/controllers.js 02a045d4a2ac01d468adc0885097f9191d7f1f08
src/webui/master/static/framework.html ecbf879b217ab51ea6f2531ebadd8dc09fd8ca54
src/webui/master/static/frameworks.html 4da01583eeb5bcd6ee5a36d4cbd58042bafcab15
src/webui/master/static/home.html 84e9317b1b3bc857d6d6532adb25fd21a7691732
src/webui/master/static/slave.html b96dfe95e08e79f683c622bf0bec96b9342c3be1
src/webui/master/static/slave_executor.html 33fa5f4ba3bacb5bb73849c1b1fa76a417351aa1
src/webui/master/static/slave_framework.html b43bbdcd79fab62d28e8d53737e3c4a083e0812d
Diff: https://reviews.apache.org/r/7642/diff/
Testing
-------
OSX + CentOS: make check
local run with long-lived-framework
Thanks,
Ben Mahler