[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1098: MINIFICPP-1581: set cmake policy CMP0096 to NEW to preserve the leadi…

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1098:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1098#discussion_r646416848



##########
File path: docker/debian/Dockerfile
##########
@@ -28,7 +28,9 @@ ENV MINIFI_BASE_DIR /opt/minifi
 ENV MINIFI_HOME $MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
 ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/
 
-RUN apt-get update && apt-get install -y openjdk-11-jdk openjdk-11-source libpython3.7-dev sudo git maven libarchive13 cmake
+RUN echo "deb http://deb.debian.org/debian buster-backports main" | tee -a /etc/apt/sources.list \
+    && apt-get update && apt-get install -y openjdk-11-jdk openjdk-11-source libpython3.7-dev sudo git maven libarchive13 libtool \ 

Review comment:
       Why are we installing openjdk-11 while setting JAVA_HOME to openjdk-8 three lines above?

##########
File path: CMakeLists.txt
##########
@@ -17,7 +17,8 @@
 # under the License.
 #
 
-cmake_minimum_required(VERSION 3.11)
+cmake_minimum_required(VERSION 3.16)

Review comment:
       When raising cmake or other requirements, it needs to be documented in the README.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org