[GitHub] [beam] robertwb commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders.

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r402668985
 
 

 ##########
 File path: sdks/python/apache_beam/coders/coders.py
 ##########
 @@ -370,7 +370,8 @@ def from_runner_api(cls, coder_proto, context):
     except Exception:
       if context.allow_proto_holders:
         # ignore this typing scenario for now, since it can't be easily tracked
-        return RunnerAPICoderHolder(coder_proto)  # type: ignore
+        return ExternalCoder(
 
 Review comment:
   Thanks. I think it'd be cleaner to just put this `if` instead of the `try`, and not have a broadly-catching "except Exception" block. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services