You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/06/09 23:37:08 UTC

[GitHub] [helix] jiajunwang commented on pull request #1790: Fix import code style in PropertyPathBuilder.

jiajunwang commented on pull request #1790:
URL: https://github.com/apache/helix/pull/1790#issuecomment-858169202


   > LGTM. There are similar mixed usages in PropertyKey.java. Do we want to also clean them?
   
   I see. But since it is clean (all using static import), I think there is no point in changing it now. Once we decide to have a very strict code convention regarding the import, we shall change it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org