You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "David Hawkins (JIRA)" <ji...@codehaus.org> on 2005/11/28 19:26:18 UTC
[jira] Created: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
war includes and excludes don't handle comma separated tokens (patch included)
------------------------------------------------------------------------------
Key: MNG-1696
URL: http://jira.codehaus.org/browse/MNG-1696
Project: Maven 2
Type: Bug
Components: maven-war-plugin
Reporter: David Hawkins
The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
Posted by "Marcel Schutte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52886 ]
Marcel Schutte commented on MNG-1696:
-------------------------------------
Please take a look at EarMojo from maven-ear-plugin as well. This one has similar getExcludes() and getIncludes() methods.
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1696) war includes and excludes don't handle
comma separated tokens (patch included)
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=all ]
Stephane Nicoll updated MNG-1696:
---------------------------------
Component: maven-ear-plugin
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-ear-plugin, maven-war-plugin
> Reporter: David Hawkins
> Assignee: Stephane Nicoll
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52447 ]
Brian Fox commented on MNG-1696:
--------------------------------
What version was this patched on? I applied the patch over svn beta-3 and it breaks at least the excludes. Even single excludes don't seem to work now.
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
Posted by "David Hawkins (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=all ]
David Hawkins updated MNG-1696:
-------------------------------
Attachment: MNG-1696-maven-war-plugin.patch
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MEAR-3) ear includes and excludes don't handle
comma separated tokens
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-3?page=all ]
Stephane Nicoll closed MEAR-3:
------------------------------
Resolution: Fixed
This is fixed. Thanks.
> ear includes and excludes don't handle comma separated tokens
> -------------------------------------------------------------
>
> Key: MEAR-3
> URL: http://jira.codehaus.org/browse/MEAR-3
> Project: Maven 2.x Ear Plugin
> Type: Bug
> Versions: 2.1, 2.0
> Reporter: David Hawkins
> Assignee: Stephane Nicoll
> Fix For: 2.2
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52454 ]
Brian Fox commented on MNG-1696:
--------------------------------
This is a proper patch to the getExcludes method:
List excludeList = new ArrayList( FileUtils.getDefaultExcludesAsList() );
if ( warSourceExcludes != null && !"".equals( warSourceExcludes ) )
{
excludeList.addAll( Arrays.asList( StringUtils.split( warSourceExcludes, "," ) ) );
}
on beta2, I can't seem to get beta3 working though.
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52459 ]
Brian Fox commented on MNG-1696:
--------------------------------
I'm using the trunk version of the source which seems to be called beta3 from here: http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-war-plugin
When I add any excludes with this version, nothing is excluded...with or without your patch even using a single exclude. If I take beta 2 and add the code posted above, then it works using one or more comma separated excludes.
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
Posted by "David Hawkins (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52458 ]
David Hawkins commented on MNG-1696:
------------------------------------
It was developed against repository version 349429. I just reverted my src directory, updated to the latest (350051) and patched my source with the patch. I tested both include and excludes (single and comma separated) and they work properly.
What is the behavior that you are seeing?
As to your second reply, the suggesting of adding:
If ( warSourceExcludes != null && !"".equals( warSourceExcludes ) )
Is taken care of by StringUtils:
if ( StringUtils.isNotEmpty( warSourceExcludes ) )
And there is no need to add the default FileUtils.getDefaultExcludesAsList because they automatically added on line 463 with a call to scanner.addDefaultExcludes();
I think you might be working with an old version of the source or something.
--David
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1696) war includes and excludes don't handle
comma separated tokens (patch included)
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52979 ]
Stephane Nicoll commented on MNG-1696:
--------------------------------------
Indeed. I'll take care of updating war and ear plugin.
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Assignee: Stephane Nicoll
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MEAR-3) ear includes and excludes don't handle
comma separated tokens
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-3?page=comments#action_54133 ]
Stephane Nicoll commented on MEAR-3:
------------------------------------
David, your patch has been applied in the WAR plugin, Thanks!
> ear includes and excludes don't handle comma separated tokens
> -------------------------------------------------------------
>
> Key: MEAR-3
> URL: http://jira.codehaus.org/browse/MEAR-3
> Project: Maven 2.x Ear Plugin
> Type: Bug
> Versions: 2.1, 2.0
> Reporter: David Hawkins
> Assignee: Stephane Nicoll
> Fix For: 2.2
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MEAR-3) ear includes and excludes don't handle
comma separated tokens
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-3?page=all ]
Stephane Nicoll updated MEAR-3:
-------------------------------
Version: 2.1
2.0
Fix Version: 2.2
Summary: ear includes and excludes don't handle comma separated tokens (was: war includes and excludes don't handle comma separated tokens (patch included))
> ear includes and excludes don't handle comma separated tokens
> -------------------------------------------------------------
>
> Key: MEAR-3
> URL: http://jira.codehaus.org/browse/MEAR-3
> Project: Maven 2.x Ear Plugin
> Type: Bug
> Versions: 2.1, 2.0
> Reporter: David Hawkins
> Assignee: Stephane Nicoll
> Fix For: 2.2
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1696) war includes and excludes don't handle comma separated tokens (patch included)
Posted by "David Hawkins (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52464 ]
David Hawkins commented on MNG-1696:
------------------------------------
Well I am not quite sure what else to say here. I am working with 2.0-beta-3-SNAPSHOT from http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-war-plugin
Are you certain that maven is using the plugin that you are compiling? Did you execute a mvn install when you compiled the plugin? What version of the war plugin are you specifying in your pom? You might add a log statement or change an existing one so you can verify that you are executing the version that you think you are. Another option is to run mvn with -X and you should be able to see which version is being configured by the container. I am including a snippet from my test web application pom.xml that I am testing this with to see if it helps.
<plugins>
<plugin>
<artifactId>maven-war-plugin</artifactId>
<version>2.0-beta-3-SNAPSHOT</version>
<configuration>
<excludes>foo.jsp</excludes>
<dependentWarExcludes>**/file1.txt,file2.txt</dependentWarExcludes>
</configuration>
</plugin>
</plugins>
--David
> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
> Key: MNG-1696
> URL: http://jira.codehaus.org/browse/MNG-1696
> Project: Maven 2
> Type: Bug
> Components: maven-war-plugin
> Reporter: David Hawkins
> Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, dependantWarIncludes, and dependantWarExcludes all state something that they support comma delimited tokens but it simply doesn't work when a comma is specified. This patch makes all four parameters properly process comma delimited values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org