You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/20 13:22:35 UTC

[GitHub] HeartSaVioR edited a comment on issue #18410: [SPARK-20971][SS] purge metadata log in FileStreamSource

HeartSaVioR edited a comment on issue #18410: [SPARK-20971][SS] purge metadata log in FileStreamSource
URL: https://github.com/apache/spark/pull/18410#issuecomment-465571238
 
 
   I played a bit with my idea (filter out entities which were in committed batch when compacting), and realized it cannot solve the issue which filtered out files being re-read (not sure I'm just missing here). 
   
   https://github.com/HeartSaVioR/spark/commit/00534b807fa0beec9019a5c15d9056a8d1f9c9bf
   
   Once the files are filtered out in metadata they could be included in source of new batch (even if SeenFilesMap could help a bit, it's not persisted to storage so the issue remains same when query is rerun).
   
   I think the best way to do this safely would be incorporating this to #22952 - when files are successfully archived or deleted, we're safe to filter out them in metadata log as well. I'll address it to #22952.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org