You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/09/26 22:54:40 UTC

Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.


Bugs: MESOS-8017
    https://issues.apache.org/jira/browse/MESOS-8017


Repository: mesos


Description
-------

Adds test module wrapping the basic HTTP authenticatee. Additionally
renames the former testhttpauthenticator library to accomodate for
the added test HTTP authenticatee module.


Diffs
-----

  src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
  src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
  src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
  src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
  src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 


Diff: https://reviews.apache.org/r/62595/diff/1/


Testing
-------

Integration test in external project. Further tests upcoming.


Thanks,

Till Toenshoff

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187387
-----------------------------------------------------------




src/examples/test_http_authenticator_module.cpp
Lines 68 (patched)
<https://reviews.apache.org/r/62595/#comment264350>

    Hmm.. is there a reason that this uses `const mesos::Parameters&`, while the signature of `createHttpAuthenticator` uses `const Parameters&`?


- Greg Mann


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test module wrapping the basic HTTP authenticatee.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/2/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187292
-----------------------------------------------------------



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN      ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[       OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[       OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN      ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[       OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN      ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[       OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[       OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN      ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[       OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN      ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[       OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[       OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage (941 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[       OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage (1060 ms)
[ RUN      ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[       OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN      ] FaultToleranceTest.SchedulerExit
[       OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN      ] FaultToleranceTest.SlaveReliableRegistration
[       OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN      ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[       OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN      ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[       OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN      ] FaultToleranceTest.SplitBrainMasters
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:13.007899 39284 master.cpp:1303] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 8c8fa538-3ba3-4608-8e12-2ba9b5151087 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memor
 y" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\master" --zk_session_timeout="10secs"
I1006 17:26:13.223922 44660 master.cpp:496] Master only allowing authenticated frameworks to register
I1006 17:26:13.223922 44660 master.cpp:502] Master only allowing authenticated agents to register
I1006 17:26:13.223922 44660 master.cpp:508] Master only allowing authenticated HTTP frameworks to register
I1006 17:26:13.223922 44660 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials'
I1006 17:26:13.235913 44660 master.cpp:552] Using default 'crammd5' authenticator
I1006 17:26:13.236914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I1006 17:26:13.237915 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I1006 17:26:13.238914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I1006 17:26:13.239914 44660 master.cpp:631] Authorization enabled
I1006 17:26:13.270947 45764 master.cpp:2198] Elected as the leading master!
I1006 17:26:13.270947 45764 master.cpp:1687] Recovering from registrar
I1006 17:26:13.273921 39284 registrar.cpp:391] Successfully fetched the registry (0B) in 1.97504ms
I1006 17:26:13.273921 39284 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I1006 17:26:13.275921 21464 registrar.cpp:552] Successfully updated the registry in 999936ns
I1006 17:26:13.276916 21464 registrar.cpp:424] Success```

- Mesos Reviewbot Windows


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test module wrapping the basic HTTP authenticatee.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/2/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review188654
-----------------------------------------------------------



LGTM.

- Armand Grillet


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/3/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187291
-----------------------------------------------------------



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN      ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[       OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[       OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN      ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[       OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN      ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[       OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[       OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN      ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[       OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN      ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[       OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[       OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage (941 ms)
[ RUN      ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[       OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage (1060 ms)
[ RUN      ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[       OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN      ] FaultToleranceTest.SchedulerExit
[       OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN      ] FaultToleranceTest.SlaveReliableRegistration
[       OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN      ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[       OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN      ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[       OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN      ] FaultToleranceTest.SplitBrainMasters
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:13.007899 39284 master.cpp:1303] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 8c8fa538-3ba3-4608-8e12-2ba9b5151087 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memor
 y" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\master" --zk_session_timeout="10secs"
I1006 17:26:13.223922 44660 master.cpp:496] Master only allowing authenticated frameworks to register
I1006 17:26:13.223922 44660 master.cpp:502] Master only allowing authenticated agents to register
I1006 17:26:13.223922 44660 master.cpp:508] Master only allowing authenticated HTTP frameworks to register
I1006 17:26:13.223922 44660 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials'
I1006 17:26:13.235913 44660 master.cpp:552] Using default 'crammd5' authenticator
I1006 17:26:13.236914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I1006 17:26:13.237915 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I1006 17:26:13.238914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I1006 17:26:13.239914 44660 master.cpp:631] Authorization enabled
I1006 17:26:13.270947 45764 master.cpp:2198] Elected as the leading master!
I1006 17:26:13.270947 45764 master.cpp:1687] Recovering from registrar
I1006 17:26:13.273921 39284 registrar.cpp:391] Successfully fetched the registry (0B) in 1.97504ms
I1006 17:26:13.273921 39284 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I1006 17:26:13.275921 21464 registrar.cpp:552] Successfully updated the registry in 999936ns
I1006 17:26:13.276916 21464 registrar.cpp:424] Success```

- Mesos Reviewbot Windows


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test module wrapping the basic HTTP authenticatee.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/2/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Till Toenshoff <to...@me.com>.

> On Sept. 27, 2017, 10:17 p.m., Greg Mann wrote:
> > src/examples/test_http_authenticator_module.cpp
> > Line 30 (original), 34 (patched)
> > <https://reviews.apache.org/r/62595/diff/1/?file=1836121#file1836121line36>
> >
> >     Is there a reason to have `using namespace mesos` here instead of `namespace mesos {`?

This is not really a part of Mesos but example code. None of our (module) examples put their code into the `mesos` namespace.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review186495
-----------------------------------------------------------


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds test module wrapping the basic HTTP authenticatee. Additionally
> renames the former testhttpauthenticator library to accomodate for
> the added test HTTP authenticatee module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review186495
-----------------------------------------------------------




src/examples/test_http_authenticator_module.cpp
Line 30 (original), 34 (patched)
<https://reviews.apache.org/r/62595/#comment263070>

    Is there a reason to have `using namespace mesos` here instead of `namespace mesos {`?


- Greg Mann


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds test module wrapping the basic HTTP authenticatee. Additionally
> renames the former testhttpauthenticator library to accomodate for
> the added test HTTP authenticatee module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187324
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62587, 62591, 62592, 62594, 62595]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test module wrapping the basic HTTP authenticatee.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/2/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review188655
-----------------------------------------------------------


Ship it!




Ship It!

- Armand Grillet


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/3/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187487
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62587, 62591, 62592, 62594, 62595]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 26, 2017, 3:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 3:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/3/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187473
-----------------------------------------------------------



PASS: Mesos patch 62595 was successfully built and tested.

Reviews applied: `['62587', '62591', '62592', '62594', '62595']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62595

- Mesos Reviewbot Windows


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/3/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review186835
-----------------------------------------------------------



LGTM.

- Armand Grillet


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds test module wrapping the basic HTTP authenticatee. Additionally
> renames the former testhttpauthenticator library to accomodate for
> the added test HTTP authenticatee module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review186359
-----------------------------------------------------------



PASS: Mesos patch 62595 was successfully built and tested.

Reviews applied: `['62587', '62591', '62592', '62594', '62595']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62595

- Mesos Reviewbot Windows


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds test module wrapping the basic HTTP authenticatee. Additionally
> renames the former testhttpauthenticator library to accomodate for
> the added test HTTP authenticatee module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>