You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Chris Morgan (JIRA)" <ji...@apache.org> on 2011/02/08 16:36:57 UTC
[jira] Created: (THRIFT-1055) csharp TServerSocket and TSocket do
not disable Nagle via Socket.NoDelay = true like cpp and java do
csharp TServerSocket and TSocket do not disable Nagle via Socket.NoDelay = true like cpp and java do
----------------------------------------------------------------------------------------------------
Key: THRIFT-1055
URL: https://issues.apache.org/jira/browse/THRIFT-1055
Project: Thrift
Issue Type: Bug
Components: C# - Library
Affects Versions: 0.7
Environment: Kubuntu Maverick (10.10)
Reporter: Chris Morgan
https://issues.apache.org/jira/browse/THRIFT-904 resulted in TFramedTransport being improved so it wasn't necessary to disable Nagle.
For the case of TServerSocket and TSocket, a simple server case, performance is still very poor, ~30 msg/sec vs. ~11k msg/sec with NoDelay = true.
Java and cpp disable nagle in their TSocket and TServerSocket implementations and performance is MUCH improved with nagle disabled for csharp so I'm proposing that csharp should also disable nagle.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (THRIFT-1055) csharp TServerSocket and TSocket do
not disable Nagle via Socket.NoDelay = true like cpp and java do
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1055.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Chris Morgan
I just committed this. Thanks for the patch, Chris.
> csharp TServerSocket and TSocket do not disable Nagle via Socket.NoDelay = true like cpp and java do
> ----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1055
> URL: https://issues.apache.org/jira/browse/THRIFT-1055
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.7
> Environment: Kubuntu Maverick (10.10)
> Reporter: Chris Morgan
> Assignee: Chris Morgan
> Fix For: 0.7
>
> Attachments: nodelay_enable.patch
>
>
> https://issues.apache.org/jira/browse/THRIFT-904 resulted in TFramedTransport being improved so it wasn't necessary to disable Nagle.
> For the case of TServerSocket and TSocket, a simple server case, performance is still very poor, ~30 msg/sec vs. ~11k msg/sec with NoDelay = true.
> Java and cpp disable nagle in their TSocket and TServerSocket implementations and performance is MUCH improved with nagle disabled for csharp so I'm proposing that csharp should also disable nagle.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1055) csharp TServerSocket and TSocket do
not disable Nagle via Socket.NoDelay = true like cpp and java do
Posted by "Chris Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Morgan updated THRIFT-1055:
---------------------------------
Patch Info: [Patch Available]
> csharp TServerSocket and TSocket do not disable Nagle via Socket.NoDelay = true like cpp and java do
> ----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1055
> URL: https://issues.apache.org/jira/browse/THRIFT-1055
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.7
> Environment: Kubuntu Maverick (10.10)
> Reporter: Chris Morgan
> Attachments: nodelay_enable.patch
>
>
> https://issues.apache.org/jira/browse/THRIFT-904 resulted in TFramedTransport being improved so it wasn't necessary to disable Nagle.
> For the case of TServerSocket and TSocket, a simple server case, performance is still very poor, ~30 msg/sec vs. ~11k msg/sec with NoDelay = true.
> Java and cpp disable nagle in their TSocket and TServerSocket implementations and performance is MUCH improved with nagle disabled for csharp so I'm proposing that csharp should also disable nagle.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1055) csharp TServerSocket and TSocket do
not disable Nagle via Socket.NoDelay = true like cpp and java do
Posted by "Chris Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Morgan updated THRIFT-1055:
---------------------------------
Attachment: nodelay_enable.patch
Prototype patch for the issue.
> csharp TServerSocket and TSocket do not disable Nagle via Socket.NoDelay = true like cpp and java do
> ----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1055
> URL: https://issues.apache.org/jira/browse/THRIFT-1055
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.7
> Environment: Kubuntu Maverick (10.10)
> Reporter: Chris Morgan
> Attachments: nodelay_enable.patch
>
>
> https://issues.apache.org/jira/browse/THRIFT-904 resulted in TFramedTransport being improved so it wasn't necessary to disable Nagle.
> For the case of TServerSocket and TSocket, a simple server case, performance is still very poor, ~30 msg/sec vs. ~11k msg/sec with NoDelay = true.
> Java and cpp disable nagle in their TSocket and TServerSocket implementations and performance is MUCH improved with nagle disabled for csharp so I'm proposing that csharp should also disable nagle.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira