You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/08 09:30:25 UTC

[GitHub] [arrow] jorisvandenbossche opened a new pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

jorisvandenbossche opened a new pull request #7675:
URL: https://github.com/apache/arrow/pull/7675


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou closed pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #7675:
URL: https://github.com/apache/arrow/pull/7675


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#discussion_r451768761



##########
File path: ci/scripts/integration_dask.sh
##########
@@ -32,7 +32,11 @@ python -c "import dask.dataframe"
 # pytest -sv --pyargs dask.bytes.tests.test_hdfs
 # pytest -sv --pyargs dask.bytes.tests.test_local
 
-pytest -v --pyargs dask.dataframe.tests.test_dataframe
+# skip failing pickle test, see https://github.com/dask/dask/issues/6374
+pytest -v --pyargs dask.dataframe.tests.test_dataframe -k "not test_dataframe_picklable"
 pytest -v --pyargs dask.dataframe.io.tests.test_orc
+# skip failing parquet tests, see https://github.com/dask/dask/issues/6243
+# test_illegal_column_name can be removed once next dask release is out
+# (https://github.com/dask/dask/pull/6378)
 pytest -v --pyargs dask.dataframe.io.tests.test_parquet \
-  -k "not test_timestamp_index and not test_roundtrip_from_pandas"
+  -k "not test_to_parquet_pyarrow_w_inconsistent_schema_by_partition_fails_by_default and not test_timeseries_nulls_in_schema and not test_illegal_column_name"

Review comment:
       Not familiar enough with sh to know if there is a way to split this string on multiple lines (but also not the most important issue I think for this bash script)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on a change in pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#discussion_r452112505



##########
File path: ci/scripts/integration_dask.sh
##########
@@ -32,7 +32,11 @@ python -c "import dask.dataframe"
 # pytest -sv --pyargs dask.bytes.tests.test_hdfs
 # pytest -sv --pyargs dask.bytes.tests.test_local
 
-pytest -v --pyargs dask.dataframe.tests.test_dataframe
+# skip failing pickle test, see https://github.com/dask/dask/issues/6374
+pytest -v --pyargs dask.dataframe.tests.test_dataframe -k "not test_dataframe_picklable"
 pytest -v --pyargs dask.dataframe.io.tests.test_orc
+# skip failing parquet tests, see https://github.com/dask/dask/issues/6243
+# test_illegal_column_name can be removed once next dask release is out
+# (https://github.com/dask/dask/pull/6378)
 pytest -v --pyargs dask.dataframe.io.tests.test_parquet \
-  -k "not test_timestamp_index and not test_roundtrip_from_pandas"
+  -k "not test_to_parquet_pyarrow_w_inconsistent_schema_by_partition_fails_by_default and not test_timeseries_nulls_in_schema and not test_illegal_column_name"

Review comment:
       Not important IMO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche commented on pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#issuecomment-655423250


   So both are now only failing for the ``test_illegal_column_name`` test (which I didn't skip yet as I don't understand why it is failing)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#issuecomment-655406130


   https://issues.apache.org/jira/browse/ARROW-9353


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche commented on pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#issuecomment-655406331


   @github-actions crossbow submit test-conda-python-3.7-dask-latest test-conda-python-3.8-dask-master
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#issuecomment-655640336


   Revision: ae6b8ed68a570760bab2014e74d65b04ae455a0d
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-392](https://github.com/ursa-labs/crossbow/branches/all?query=actions-392)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.7-dask-latest|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-392-github-test-conda-python-3.7-dask-latest)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-392-github-test-conda-python-3.7-dask-latest)|
   |test-conda-python-3.8-dask-master|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-392-github-test-conda-python-3.8-dask-master)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-392-github-test-conda-python-3.8-dask-master)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#issuecomment-655407279


   Revision: 56d6e36137ca35ec3520362d0177c4874ab239b8
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-388](https://github.com/ursa-labs/crossbow/branches/all?query=actions-388)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.7-dask-latest|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-388-github-test-conda-python-3.7-dask-latest)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-388-github-test-conda-python-3.7-dask-latest)|
   |test-conda-python-3.8-dask-master|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-388-github-test-conda-python-3.8-dask-master)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-388-github-test-conda-python-3.8-dask-master)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche commented on pull request #7675: ARROW-9353: [Python][CI] Disable known failures in dask integration tests

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7675:
URL: https://github.com/apache/arrow/pull/7675#issuecomment-655639520


   @github-actions crossbow submit test-conda-python-3.7-dask-latest test-conda-python-3.8-dask-master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org