You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/15 08:50:25 UTC

[GitHub] tillrohrmann commented on a change in pull request #6839: [FLINK-10253] Run MetricQueryService with lower priority

tillrohrmann commented on a change in pull request #6839: [FLINK-10253] Run MetricQueryService with lower priority
URL: https://github.com/apache/flink/pull/6839#discussion_r225082915
 
 

 ##########
 File path: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala
 ##########
 @@ -291,12 +291,22 @@ object AkkaUtils {
     ConfigFactory.parseString(config)
   }
 
-  def getThreadPoolExecutorConfig: Config = {
+  def getThreadPoolExecutorConfig(configuration: Configuration): Config = {
+    val priority = configuration.getInteger(MetricOptions.QUERY_SERVICE_THREAD_PRIORITY)
 
 Review comment:
   I would prefer to pass in the the thread priority as a parameter of the `getThreadPoolExecutorConfig` because otherwise we couple all `ThreadPoolExecutors` to the `MetricOptions.QUERY_SERVICE_THREAD_PRIORITY`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services