You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2016/01/05 09:22:30 UTC
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/10594
[SPARK-12570] [ML] [Doc] DecisionTreeRegressor: provide variance of prediction: user guide update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark spark-12570
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10594.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10594
----
commit 94273d1512eded0148d02b7a76925ee4a40d8039
Author: Yanbo Liang <yb...@gmail.com>
Date: 2016-01-05T08:21:33Z
DecisionTreeRegressor: provide variance of prediction: user guide update
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-169137124
**[Test build #2329 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2329/consoleFull)** for PR 10594 at commit [`94273d1`](https://github.com/apache/spark/commit/94273d1512eded0148d02b7a76925ee4a40d8039).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-169137240
LGTM pending tests
(There's an indentation bug in the table, but it's fine for now.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-168935497
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10594#discussion_r48823622
--- Diff: docs/ml-classification-regression.md ---
@@ -535,7 +535,9 @@ The main differences between this API and the [original MLlib Decision Tree API]
* use of DataFrame metadata to distinguish continuous and categorical features
-The Pipelines API for Decision Trees offers a bit more functionality than the original API. In particular, for classification, users can get the predicted probability of each class (a.k.a. class conditional probabilities).
+The Pipelines API for Decision Trees offers a bit more functionality than the original API.
+In particular, for classification, users can get the predicted probability of each class (a.k.a. class conditional probabilities);
--- End diff --
This is not the end, it will concat with the next line in the generated doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-169152922
Merging with master
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-169140841
**[Test build #2329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2329/consoleFull)** for PR 10594 at commit [`94273d1`](https://github.com/apache/spark/commit/94273d1512eded0148d02b7a76925ee4a40d8039).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `In particular, for classification, users can get the predicted probability of each class (a.k.a. class conditional probabilities); `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-168936363
Lgtm except for one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-168935501
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48752/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10594#discussion_r48822844
--- Diff: docs/ml-classification-regression.md ---
@@ -535,7 +535,9 @@ The main differences between this API and the [original MLlib Decision Tree API]
* use of DataFrame metadata to distinguish continuous and categorical features
-The Pipelines API for Decision Trees offers a bit more functionality than the original API. In particular, for classification, users can get the predicted probability of each class (a.k.a. class conditional probabilities).
+The Pipelines API for Decision Trees offers a bit more functionality than the original API.
+In particular, for classification, users can get the predicted probability of each class (a.k.a. class conditional probabilities);
--- End diff --
Line ends with ";".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...
Posted by BenFradet <gi...@git.apache.org>.
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10594#discussion_r48824613
--- Diff: docs/ml-classification-regression.md ---
@@ -535,7 +535,9 @@ The main differences between this API and the [original MLlib Decision Tree API]
* use of DataFrame metadata to distinguish continuous and categorical features
-The Pipelines API for Decision Trees offers a bit more functionality than the original API. In particular, for classification, users can get the predicted probability of each class (a.k.a. class conditional probabilities).
+The Pipelines API for Decision Trees offers a bit more functionality than the original API.
+In particular, for classification, users can get the predicted probability of each class (a.k.a. class conditional probabilities);
--- End diff --
My bad, I didnt understand the sentence correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org