You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Peeyush Bishnoi <bp...@yahoo.co.in> on 2015/09/17 09:07:17 UTC
Review Request 38448: Documentation for Falcon Email notification
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1426
https://issues.apache.org/jira/browse/FALCON-1426
Repository: falcon-git
Description
-------
FALCON-1426: Documentation for Falcon Email notification
Diffs
-----
docs/src/site/twiki/EntitySpecification.twiki bf45598
docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
Diff: https://reviews.apache.org/r/38448/diff/
Testing
-------
Yes.
Thanks,
Peeyush Bishnoi
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote:
> >
Thanks Scott for reviewing the doc. I have incorporated your comments.
> On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote:
> > docs/src/site/twiki/FalconEmailNotification.twiki, line 3
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line3>
> >
> > Recommend text change:
> > Change "sending email based notification from Falcon when scheduled feed/process instance completed"
> >
> > To:
> > "sending email notifications when scheduled feed/process instances complete."
Done.
> On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote:
> > docs/src/site/twiki/FalconEmailNotification.twiki, line 14
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line14>
> >
> > Recommend a text change:
> > "specifies the address to send notifications to; multiple recipients may be provided as a comma-separated list"
Done.
> On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote:
> > docs/src/site/twiki/FalconEmailNotification.twiki, line 8
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line8>
> >
> > Will it confuse users that the "to" part looks like a literal e-mail address? Will people think that's the value they should use, rather than the intended recipient address?
I have put more realistic email address to avoid confusion.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99390
-----------------------------------------------------------
On Sept. 17, 2015, 7:07 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 7:07 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1426
> https://issues.apache.org/jira/browse/FALCON-1426
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1426: Documentation for Falcon Email notification
>
>
> Diffs
> -----
>
> docs/src/site/twiki/EntitySpecification.twiki bf45598
> docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
> docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38448/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Scott Preece <se...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99390
-----------------------------------------------------------
docs/src/site/twiki/FalconEmailNotification.twiki (line 3)
<https://reviews.apache.org/r/38448/#comment156272>
Recommend text change:
Change "sending email based notification from Falcon when scheduled feed/process instance completed"
To:
"sending email notifications when scheduled feed/process instances complete."
docs/src/site/twiki/FalconEmailNotification.twiki (line 8)
<https://reviews.apache.org/r/38448/#comment156273>
Will it confuse users that the "to" part looks like a literal e-mail address? Will people think that's the value they should use, rather than the intended recipient address?
docs/src/site/twiki/FalconEmailNotification.twiki (line 14)
<https://reviews.apache.org/r/38448/#comment156271>
Recommend a text change:
"specifies the address to send notifications to; multiple recipients may be provided as a comma-separated list"
- Scott Preece
On Sept. 17, 2015, 7:07 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 7:07 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1426
> https://issues.apache.org/jira/browse/FALCON-1426
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1426: Documentation for Falcon Email notification
>
>
> Diffs
> -----
>
> docs/src/site/twiki/EntitySpecification.twiki bf45598
> docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
> docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38448/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> >
Thanks Pallavi for reviewing the doc. I have incorporated your comments.
> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> > docs/src/site/twiki/FalconEmailNotification.twiki, line 22
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line22>
> >
> > Change to : Boolean propety that specifies if authentication....
Done.
> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> > docs/src/site/twiki/EntitySpecification.twiki, line 841
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075833#file1075833line841>
> >
> > Specifying the notification element with "type" property allows users to receive email notification when a scheduled process instance completes.
Done.
> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> > docs/src/site/twiki/EntitySpecification.twiki, line 265
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075833#file1075833line265>
> >
> > Change to :
> > Specifying the notification element with "type" property allows users to receive email notification when a scheduled feed instance completes.
done.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99509
-----------------------------------------------------------
On Sept. 17, 2015, 7:07 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 7:07 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1426
> https://issues.apache.org/jira/browse/FALCON-1426
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1426: Documentation for Falcon Email notification
>
>
> Diffs
> -----
>
> docs/src/site/twiki/EntitySpecification.twiki bf45598
> docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
> docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38448/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99509
-----------------------------------------------------------
docs/src/site/twiki/EntitySpecification.twiki (line 265)
<https://reviews.apache.org/r/38448/#comment156399>
Change to :
Specifying the notification element with "type" property allows users to receive email notification when a scheduled feed instance completes.
docs/src/site/twiki/EntitySpecification.twiki (line 841)
<https://reviews.apache.org/r/38448/#comment156400>
Specifying the notification element with "type" property allows users to receive email notification when a scheduled process instance completes.
docs/src/site/twiki/FalconEmailNotification.twiki (line 22)
<https://reviews.apache.org/r/38448/#comment156401>
Change to : Boolean propety that specifies if authentication....
- Pallavi Rao
On Sept. 17, 2015, 7:07 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 7:07 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1426
> https://issues.apache.org/jira/browse/FALCON-1426
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1426: Documentation for Falcon Email notification
>
>
> Diffs
> -----
>
> docs/src/site/twiki/EntitySpecification.twiki bf45598
> docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
> docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38448/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Sept. 18, 2015, 10:23 p.m., Sowmya Ramesh wrote:
> >
Thanks, Sowmya for the review.
> On Sept. 18, 2015, 10:23 p.m., Sowmya Ramesh wrote:
> > docs/src/site/twiki/EntitySpecification.twiki, line 265
> > <https://reviews.apache.org/r/38448/diff/2/?file=1076677#file1076677line265>
> >
> > IS it only for feed instances? If not please change the wording.
Already I have defined similar statement for process instance as well in process section. Please just check.
> On Sept. 18, 2015, 10:23 p.m., Sowmya Ramesh wrote:
> > docs/src/site/twiki/FalconEmailNotification.twiki, line 29
> > <https://reviews.apache.org/r/38448/diff/2/?file=1076679#file1076679line29>
> >
> > How to enable? Can you explicitly specify to add *.monitoring.plugins to startup properties?
*.monitoring.plugins is already added in startup properties along with SMTP parameters.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99619
-----------------------------------------------------------
On Sept. 18, 2015, 11:36 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 11:36 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1426
> https://issues.apache.org/jira/browse/FALCON-1426
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1426: Documentation for Falcon Email notification
>
>
> Diffs
> -----
>
> docs/src/site/twiki/EntitySpecification.twiki bf45598
> docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
> docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38448/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99619
-----------------------------------------------------------
docs/src/site/twiki/EntitySpecification.twiki (line 265)
<https://reviews.apache.org/r/38448/#comment156557>
IS it only for feed instances? If not please change the wording.
docs/src/site/twiki/FalconEmailNotification.twiki (line 29)
<https://reviews.apache.org/r/38448/#comment156559>
How to enable? Can you explicitly specify to add *.monitoring.plugins to startup properties?
- Sowmya Ramesh
On Sept. 18, 2015, 11:36 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 11:36 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1426
> https://issues.apache.org/jira/browse/FALCON-1426
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1426: Documentation for Falcon Email notification
>
>
> Diffs
> -----
>
> docs/src/site/twiki/EntitySpecification.twiki bf45598
> docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
> docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38448/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99545
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Sept. 18, 2015, 11:36 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 11:36 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1426
> https://issues.apache.org/jira/browse/FALCON-1426
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1426: Documentation for Falcon Email notification
>
>
> Diffs
> -----
>
> docs/src/site/twiki/EntitySpecification.twiki bf45598
> docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
> docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38448/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38448: Documentation for Falcon Email notification
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 11:36 a.m.)
Review request for Falcon.
Bugs: FALCON-1426
https://issues.apache.org/jira/browse/FALCON-1426
Repository: falcon-git
Description
-------
FALCON-1426: Documentation for Falcon Email notification
Diffs (updated)
-----
docs/src/site/twiki/EntitySpecification.twiki bf45598
docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2
docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION
Diff: https://reviews.apache.org/r/38448/diff/
Testing
-------
Yes.
Thanks,
Peeyush Bishnoi