[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191

[vongosling <gi...@git.apache.org>]

Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/100
  
    That's a good polish, but I must point out the 2 point for this optimization. 1. please comply with PR best practice for title as you have corrected before. 2. you can consider the order when many logic and operator together, such as 0&&1&&1(similar 1||0||0, nor 0||0||1), making your logic more effective. For this context, linux platform and netty epoll judge, which one happen to 0 more easily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---