You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Smith <an...@tinnedfruit.org> on 2015/08/22 05:53:26 UTC

Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37700/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-3305
    https://issues.apache.org/jira/browse/MESOS-3305


Repository: mesos


Description
-------

Document libsasl2-modules as a required dependency when building on ubuntu.


Diffs
-----

  docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 

Diff: https://reviews.apache.org/r/37700/diff/


Testing
-------


Thanks,

Andrew Smith

Re: Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37700/#review97221
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37700]

All tests passed.

- Mesos ReviewBot


On Aug. 22, 2015, 3:53 a.m., Andrew Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37700/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 3:53 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3305
>     https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document libsasl2-modules as a required dependency when building on ubuntu.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 
> 
> Diff: https://reviews.apache.org/r/37700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Smith
> 
>

Re: Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

Posted by Andrew Smith <an...@tinnedfruit.org>.


> On Aug. 31, 2015, 10:47 p.m., Vinod Kone wrote:
> > Our ASF Docker build that tests unbuntu 14.04 doesn't have this dependency explicitly specified! https://github.com/apache/mesos/blob/master/support/jenkins_build.sh
> > 
> > Are you sure the CRAM-MD5 module is not automatically installed when you install "libsasl2-dev"? cc @till
> 
> Andrew Smith wrote:
>     I wasn't able to proceed with the build until I added the aforementioned module in this issue. From the docs for the package (at http://packages.ubuntu.com/trusty/amd64/libsasl2-modules/filelist), it lists /usr/lib/x86_64-linux-gnu/sasl2/libcrammd5.so as a provided file.

Correct URL is http://packages.ubuntu.com/trusty/amd64/libsasl2-modules/filelist


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37700/#review97179
-----------------------------------------------------------


On Aug. 22, 2015, 3:53 a.m., Andrew Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37700/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 3:53 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3305
>     https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document libsasl2-modules as a required dependency when building on ubuntu.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 
> 
> Diff: https://reviews.apache.org/r/37700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Smith
> 
>

Re: Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

Posted by Andrew Smith <an...@tinnedfruit.org>.


> On Aug. 31, 2015, 10:47 p.m., Vinod Kone wrote:
> > Our ASF Docker build that tests unbuntu 14.04 doesn't have this dependency explicitly specified! https://github.com/apache/mesos/blob/master/support/jenkins_build.sh
> > 
> > Are you sure the CRAM-MD5 module is not automatically installed when you install "libsasl2-dev"? cc @till

I wasn't able to proceed with the build until I added the aforementioned module in this issue. From the docs for the package (at http://packages.ubuntu.com/trusty/amd64/libsasl2-modules/filelist), it lists /usr/lib/x86_64-linux-gnu/sasl2/libcrammd5.so as a provided file.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37700/#review97179
-----------------------------------------------------------


On Aug. 22, 2015, 3:53 a.m., Andrew Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37700/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 3:53 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3305
>     https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document libsasl2-modules as a required dependency when building on ubuntu.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 
> 
> Diff: https://reviews.apache.org/r/37700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Smith
> 
>

Re: Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37700/#review97179
-----------------------------------------------------------


Our ASF Docker build that tests unbuntu 14.04 doesn't have this dependency explicitly specified! https://github.com/apache/mesos/blob/master/support/jenkins_build.sh

Are you sure the CRAM-MD5 module is not automatically installed when you install "libsasl2-dev"? cc @till

- Vinod Kone


On Aug. 22, 2015, 3:53 a.m., Andrew Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37700/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 3:53 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3305
>     https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document libsasl2-modules as a required dependency when building on ubuntu.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 
> 
> Diff: https://reviews.apache.org/r/37700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Smith
> 
>