[GitHub] cyy0714 commented on a change in pull request #3689: [TE] detection - update tunable interface

[GitBox <gi...@apache.org>]

cyy0714 commented on a change in pull request #3689: [TE] detection - update tunable interface
URL: https://github.com/apache/incubator-pinot/pull/3689#discussion_r248018364
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spi/components/Tunable.java
 ##########
 @@ -33,7 +31,9 @@
   /**
    * Returns the new spec for the component it's tuning
    * @param currentSpec current spec for the component. empty if not exist
+   * @param tuningWindow the tuning window
+   * @param metricUrn the metric detection runs on
 
 Review comment:
   should be the metric tuning runs on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org