You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/06/02 18:03:58 UTC

Review Request 22140: Nagios templates for 1.x and 2.x stacks contain irrelevant services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22140/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-5990
    https://issues.apache.org/jira/browse/AMBARI-5990


Repository: ambari


Description
-------

Currently, Nagios templates for 1.x and 2.x stacks are (almost ?) the same. That means that we have Resource Manager/Node Manager alert definitions at 1.3.2 stack and Job Tracker/Task Tracker alerts definitions at 2.0.6 stack.
Exact files are
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 5df2767 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 74e6e48 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 a42d795 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 92886ab 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 007cc78 

Diff: https://reviews.apache.org/r/22140/diff/


Testing
-------

----------------------------------------------------------------------
Ran 207 tests in 1.763s

OK
----------------------------------------------------------------------
Total run:560
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko


Re: Review Request 22140: Nagios templates for 1.x and 2.x stacks contain irrelevant services

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22140/#review44502
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On June 2, 2014, 4:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22140/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 4:03 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-5990
>     https://issues.apache.org/jira/browse/AMBARI-5990
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently, Nagios templates for 1.x and 2.x stacks are (almost ?) the same. That means that we have Resource Manager/Node Manager alert definitions at 1.3.2 stack and Job Tracker/Task Tracker alerts definitions at 2.0.6 stack.
> Exact files are
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 5df2767 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 74e6e48 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 a42d795 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 92886ab 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 007cc78 
> 
> Diff: https://reviews.apache.org/r/22140/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 207 tests in 1.763s
> 
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>