[jira] [Commented] (NIFI-3293) Expose counter repository to reporting tasks

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286922#comment-16286922 ] 

ASF GitHub Bot commented on NIFI-3293:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1403#discussion_r156247918
  
    --- Diff: nifi-api/src/main/java/org/apache/nifi/counter/Counter.java ---
    @@ -14,7 +14,7 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.nifi.controller;
    +package org.apache.nifi.counter;
    --- End diff --
    
    Can/should we make these kinds of API changes at a minor/dot release? I think it might have to wait for a major release?


> Expose counter repository to reporting tasks
> --------------------------------------------
>
>                 Key: NIFI-3293
>                 URL: https://issues.apache.org/jira/browse/NIFI-3293
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Minor
>
> At the moment a {{ReportingTask}} cannot access {{CounterRepository}}. It would be nice to add this feature allowing reporting tasks to send counters data.
> A first implementation would be to add counters data in metrics sent by the Ambari Reporting Task so that custom graphs can be easily added in tools such as Grafana.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)