[jira] Commented: (MECLIPSE-184) Ear utility-jar are put in WEB-INF/lib of the wtp ear

["Thierry Levieux (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MECLIPSE-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101297 ] 

Thierry Levieux commented on MECLIPSE-184:
------------------------------------------

... In my opinion MECLIPSE-167 is another issue (cross-plugin issue)

I agree with Elid.

The problem is caused by the chain:

EclipseWtpComponentWriter::writeModuleTypeComponent() -> writeWarOrEarResources() -> addDependency() - > "deploy-path"="/WEB-INF/lib"


- To solve this issue I suggest to replace any call to writeWarOrEarResources() 
by two dedicated methods:
writeWarResources()
writeEarResources()
- Change the AbstractWtpResourceWriter::addDependency() signature by adding a 'deployPath' parameter

writeWarResources -> addDependency(..., "/WEB-INF/lib")
writeEarResources -> addDependency(..., "/")

- then modify addDependency()'s body 
writer.addAttribute( ATTR_DEPLOY_PATH, "/WEB-INF/lib")  => writer.addAttribute( ATTR_DEPLOY_PATH, deployPath)

Thierry

> Ear utility-jar are put in WEB-INF/lib of the wtp ear
> -----------------------------------------------------
>
>                 Key: MECLIPSE-184
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-184
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>          Components: WTP support
>    Affects Versions: 2.3
>         Environment: Tested on Windows XP and Linux Ubuntu Dapper Drake
>            Reporter: Elid OR
>            Priority: Critical
>
> It seems that the maven eclipse plugin add ear jar dependencies in the 
> WEB-INF/lib directory.
> I've used the following command : mvn eclipse:clean 
> eclipse:eclipse -Dwtpversion=1.0 (I've also tried 1.5 with the snapshot 
> version)
> And when deploy the ear project through WTP in a J2EE Server I see the 
> following structure :
> my-ear
>   |---- my-ejb.jar
>   |---- my-webapp.war
>   |---- META-INF/
>                 |---- application.xml
>                 |---- MANIFEST.MF
>   |
>   |----- WEB-INF/
>                 |---- lib
>                         |---- dependency-1.jar
>                         |---- dependency-2.jar
> But I don't expect these dependencies to be here, I expect something like 
> this :
> my-ear
>   |---- my-ejb.jar
>   |---- my-webapp.war
>   |---- META-INF/
>                 |---- application.xml
>                 |---- MANIFEST.MF
>   |
>   |----- dependency-1.jar
>   |----- dependency-2.jar
> So I've checked quickly the SVN repository and it seems that the directory in 
> which we put "ear utility jar" is hard coded as "WEB-INF/lib" (-> 
> AbstractWtpResourceWritter.addDependency() which is the same for the war and the ear ... )
> Are you OK with this packaging ? It can be a good thing if we could configure where wtp will 
> put these ear utility-jars and by default it would be in "/" or "lib".
> Thanks In Advance
> Elid OR 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira