FW: Old Comment Servlet?

[Matthew Schmidt <ma...@javalobby.org>]

Hi guys.  This is a forwarded message from a discussion with Dave.  It seems
some themes are posting to the old comment servlet.  Also, could we do away
with the exception when there is a null website or null weblog in the
comment posting?

Thanks,
Matt

-----Original Message-----
From: Dave Johnson [mailto:dave.johnson@rollerweblogger.org] 
Sent: Monday, January 09, 2006 11:11 AM
To: Matthew P. Schmidt
Subject: Re: Old Comment Servlet?


On Jan 9, 2006, at 4:36 AM, Matthew P. Schmidt wrote:

> WARN  2006-01-09 04:35:10,576 | CommentServlet:doPost | null is  
> posting to the OLD CommentServlet
> [04:35:10.579] CommentServlet: init
> ERROR 2006-01-09 04:35:10,580 | CommentServlet:doPost | ERROR  
> posting comment
> org.roller.RollerException: Unable to find WeblogEntry for null
>
>
> How would someone be posting with a null website to the comment  
> servlet?  We get that pretty frequently and it causes Roller to  
> throw a full exception.  Maybe it shouldn't?  Also, what is this  
> old CommentServlet and why do all the skins seem to post to it?

Do the themes we ship now post to it? They should all be posting to  
the main servlet.

It's probably better to post these questions to the roller-dev list  
so everybody can get a shot at answering them. Allen did the new  
comment servlet work.

- Dave

Re: FW: Old Comment Servlet?

[Allen Gilliland <Al...@Sun.COM>]

we should double check it, but i don't think the problem is that there
are themes still posting to the old comment servlet.  the problem is
more likely that some users with older blogs have customized their
templates to post to the old comments servlet.  unfortunately there is
no easy way to sift through user templates and find who has hacked them
to point to the old comment servlet and update them.

it *should* be fairly unlikely that people have manually put the old
comment form in their templates, but that's the only explanation i
have.  the #showCommentsForm() macro has the correct url and that macro
is only called from a couple places.

-- Allen


On Mon, 2006-01-09 at 08:15, Matthew Schmidt wrote:
> Hi guys.  This is a forwarded message from a discussion with Dave.  It seems
> some themes are posting to the old comment servlet.  Also, could we do away
> with the exception when there is a null website or null weblog in the
> comment posting?
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Dave Johnson [mailto:dave.johnson@rollerweblogger.org] 
> Sent: Monday, January 09, 2006 11:11 AM
> To: Matthew P. Schmidt
> Subject: Re: Old Comment Servlet?
> 
> 
> On Jan 9, 2006, at 4:36 AM, Matthew P. Schmidt wrote:
> 
> > WARN  2006-01-09 04:35:10,576 | CommentServlet:doPost | null is  
> > posting to the OLD CommentServlet
> > [04:35:10.579] CommentServlet: init
> > ERROR 2006-01-09 04:35:10,580 | CommentServlet:doPost | ERROR  
> > posting comment
> > org.roller.RollerException: Unable to find WeblogEntry for null
> >
> >
> > How would someone be posting with a null website to the comment  
> > servlet?  We get that pretty frequently and it causes Roller to  
> > throw a full exception.  Maybe it shouldn't?  Also, what is this  
> > old CommentServlet and why do all the skins seem to post to it?
> 
> Do the themes we ship now post to it? They should all be posting to  
> the main servlet.
> 
> It's probably better to post these questions to the roller-dev list  
> so everybody can get a shot at answering them. Allen did the new  
> comment servlet work.
> 
> - Dave
> 
> 
>