[GitHub] [apisix] tzssangglass commented on a diff in pull request #7727: feat: upgrade response rewrite plugin and add test cases

[GitBox <gi...@apache.org>]

tzssangglass commented on code in PR #7727:
URL: https://github.com/apache/apisix/pull/7727#discussion_r949992831


##########
t/plugin/response-rewrite.t:
##########
@@ -699,3 +699,26 @@ X-A: 127.0.0.1
 X-B: from 127.0.0.1 to 127.0.0.1:1980
 --- no_error_log
 [error]
+
+
+
+=== TEST 25: set an nil body with setting body_base64 to false
+--- config
+    location /t {
+        content_by_lua_block {
+            local plugin = require("apisix.plugins.response-rewrite")
+            local ok, err = plugin.check_schema({
+                            body_base64 = false
+            })
+            if not ok then
+                ngx.say(err)
+                return
+            end
+        }
+    }
+--- request
+GET /t
+--- response_body
+
+--- no_error_log
+[error]

Review Comment:
   This test case would have passed even without the code changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org